New issue
Advanced search Search tips

Issue 769384 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Convert Target command handler to use UberDispatcher

Project Member Reported by sadrul@chromium.org, Sep 27 2017

Issue description

ChromeDevToolsManagerDelegate currently explicitly handles the Target.setRemoteLocations command [1]. However, now that there is an UberDispatcher [2], and Page and Browser commands are handled through that [3], it is possible to convert the Target command handler to also use UberDispatcher.

However, this code is a little tricky: ChromeDevToolsManagerDelegate manages a list of all remote locations across all sessions [4]. It also keeps a ref on all related devtool hosts [5] (I assume to keep them alive, but it's not clear why that is necessary). So even if there is a separate TargetHandler (similar to BrowserHandler etc.) for handling Target.setRemoteLocations(), all such instances of TargetHandler would need to talk back to the ChromeDevToolsManagerDelegate instance (or some other singleton instance) to manage these global lists.

[1] https://cs.chromium.org/chromium/src/chrome/browser/devtools/chrome_devtools_manager_delegate.cc?l=119
[2] https://chromium-review.googlesource.com/c/chromium/src/+/674263
[3] https://chromium-review.googlesource.com/c/chromium/src/+/676144
[4] https://cs.chromium.org/chromium/src/chrome/browser/devtools/chrome_devtools_manager_delegate.h?l=77
[5] https://cs.chromium.org/chromium/src/chrome/browser/devtools/chrome_devtools_manager_delegate.h?l=76
 
Cc: -dgozman@chromium.org
Owner: dgozman@chromium.org
Status: Assigned (was: Available)
I'll do this.
Status: Fixed (was: Assigned)
Pavel actually did this.

Sign in to add a comment