No menu arrows in chrome more menu in rtl. |
|||
Issue descriptionWhat steps will reproduce the problem? (1) Switch to RTL language (arabic, hebrew) (2) Open chrome, open chrome more menu (top right 3 vertical dots). (3) Look at history, bookmarks, help menu items. What is the expected result? A arrow indicating there is a submenu. What happens instead? No arrows Not sure if this is a regression, or if this shows up in non chromeOS OSes.
,
Sep 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7fde4b94712922ea68b740dd7e5d0db914b82d3 commit f7fde4b94712922ea68b740dd7e5d0db914b82d3 Author: Sammie Quon <sammiequon@google.com> Date: Wed Sep 27 21:36:47 2017 vector icon: Switch ordering of transforms in rtl paint vector icon. Vector icons with FLIPS_IN_RTL get shown. Right now there are only the submenu arrow and the tablet mode back button which uses this command. This also only happens when using the 2x icon. The current transforms applied on rtl 2x icons are: - scale down by factor of 2 - scale by -1 - translate by the canvas size This results in the icon being translated out of its bounds and not being shown. This cl does the scaling down after the translation. Test: gfx_unittests VectorIconTest.FlipsInRtl Bug: 769366 , 768059 Change-Id: I67e748ea23c9020f13a693546db2fade07e05ae6 Reviewed-on: https://chromium-review.googlesource.com/687826 Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#504776} [modify] https://crrev.com/f7fde4b94712922ea68b740dd7e5d0db914b82d3/ui/gfx/paint_vector_icon.cc [modify] https://crrev.com/f7fde4b94712922ea68b740dd7e5d0db914b82d3/ui/gfx/paint_vector_icon_unittest.cc
,
Oct 13 2017
,
Nov 14 2017
Submenu arrows are shown for rtl languages, on M64 dev build (10124.0.0, 64.0.3265.0).
,
Nov 14 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by sammiequon@chromium.org
, Sep 27 2017