New issue
Advanced search Search tips

Issue 769353 link

Starred by 3 users
Status: Fixed
Owner:
est...@chromium.org
Closed: Oct 2017
Cc:
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

chromeos system notifications offer to be disabled but it doesn't work

Project Member Reported by est...@chromium.org, Sep 27 2017 
ChromeOS system notifications (e.g. the one you see for downloads) can be right clicked on and disabled. This will dismiss the notification, but it doesn't actually disable said notification. Even if it did work, there would be no way to re-enable the notification because it doesn't show up in the settings panel (where, mysteriously, only screenshot shows up -- see  bug 766846 ).

We should just disallow system notifications from being blocked.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b46b61255b476c7d8c75026227daf39d223ff35

commit 8b46b61255b476c7d8c75026227daf39d223ff35
Author: Evan Stade <estade@chromium.org>
Date: Mon Oct 02 21:23:14 2017

Remove ash system screenshot from blockable notification list.

Bug:  766846 ,  769353 
Change-Id: I48a8b72f787c4e96f517ee2ed60be32bc977f550
Reviewed-on: https://chromium-review.googlesource.com/689743
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505788}
[modify] https://crrev.com/8b46b61255b476c7d8c75026227daf39d223ff35/chrome/browser/BUILD.gn
[modify] https://crrev.com/8b46b61255b476c7d8c75026227daf39d223ff35/chrome/browser/notifications/message_center_settings_controller.cc
[modify] https://crrev.com/8b46b61255b476c7d8c75026227daf39d223ff35/chrome/browser/notifications/message_center_settings_controller_unittest.cc
[modify] https://crrev.com/8b46b61255b476c7d8c75026227daf39d223ff35/chrome/browser/notifications/notifier_state_tracker.cc
[modify] https://crrev.com/8b46b61255b476c7d8c75026227daf39d223ff35/chrome/browser/notifications/notifier_state_tracker.h
[delete] https://crrev.com/a77e434c2c222ede9780ca292510692f601acca5/chrome/browser/notifications/system_component_notifier_controller_chromeos.cc
[delete] https://crrev.com/a77e434c2c222ede9780ca292510692f601acca5/chrome/browser/notifications/system_component_notifier_controller_chromeos.h
[modify] https://crrev.com/8b46b61255b476c7d8c75026227daf39d223ff35/chrome/browser/ui/ash/chrome_screenshot_grabber.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f09e3340b2f3ca0d4973264386e69504de1997a8

commit f09e3340b2f3ca0d4973264386e69504de1997a8
Author: Evan Stade <estade@chromium.org>
Date: Mon Oct 09 19:48:07 2017

Only show context menu on notifications that have a settings button.

Thus system notifications, which can't be disabled anyway, stop showing
a context menu that is at best irrelevant and at worst broken.

TBR: sky@chromium.org,rsesek@chromium.org
Bug:  769353 , 769355 
Change-Id: Ic0310be63f4f245b0a2f2cd2ccd3bc06b116b717
Reviewed-on: https://chromium-review.googlesource.com/702641
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507453}
[modify] https://crrev.com/f09e3340b2f3ca0d4973264386e69504de1997a8/ash/message_center/message_center_view.cc
[modify] https://crrev.com/f09e3340b2f3ca0d4973264386e69504de1997a8/ash/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/f09e3340b2f3ca0d4973264386e69504de1997a8/ash/system/web_notification/web_notification_tray.h
[modify] https://crrev.com/f09e3340b2f3ca0d4973264386e69504de1997a8/chrome/browser/ui/cocoa/notifications/message_center_tray_bridge.h
[modify] https://crrev.com/f09e3340b2f3ca0d4973264386e69504de1997a8/chrome/browser/ui/cocoa/notifications/message_center_tray_bridge.mm
[modify] https://crrev.com/f09e3340b2f3ca0d4973264386e69504de1997a8/chrome/browser/ui/views/message_center/web_notification_tray.cc
[modify] https://crrev.com/f09e3340b2f3ca0d4973264386e69504de1997a8/chrome/browser/ui/views/message_center/web_notification_tray.h
[modify] https://crrev.com/f09e3340b2f3ca0d4973264386e69504de1997a8/ui/message_center/fake_message_center_tray_delegate.cc
[modify] https://crrev.com/f09e3340b2f3ca0d4973264386e69504de1997a8/ui/message_center/fake_message_center_tray_delegate.h
[modify] https://crrev.com/f09e3340b2f3ca0d4973264386e69504de1997a8/ui/message_center/message_center_tray.cc
[modify] https://crrev.com/f09e3340b2f3ca0d4973264386e69504de1997a8/ui/message_center/message_center_tray_delegate.h
[modify] https://crrev.com/f09e3340b2f3ca0d4973264386e69504de1997a8/ui/message_center/message_center_tray_unittest.cc
[modify] https://crrev.com/f09e3340b2f3ca0d4973264386e69504de1997a8/ui/message_center/notification_delegate.h
[modify] https://crrev.com/f09e3340b2f3ca0d4973264386e69504de1997a8/ui/message_center/views/message_popup_collection.cc

Comment 3 by est...@chromium.org, Oct 9 2017

Status: Fixed (was: Assigned)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 5 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
►

Sign in to add a comment