New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 769348 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 718154


Participants' hotlists:
media-router-fixit


Sign in to add a comment

[chrome.dial] Remove chrome.dial

Project Member Reported by mfo...@chromium.org, Sep 27 2017

Issue description

Once Bug 718154 is fully launched we should track down any other usages of this API (Cast Setup?) and remove their dependency.  Then we can remove this API completely.  This bug tracks the removal.
 

Comment 1 by mfo...@chromium.org, Sep 27 2017

Blockedon: 718154
Status: Assigned (was: Untriaged)
[Extensions triage] Marking it as assigned to get it out of triage queue.
Labels: -Pri-3 M-67 Pri-2
Usage has essentially dropped to zero in M65 beta as expected: this is a private whitelisted API and we have removed use from the Media Router component.

So this should be safe to delete.

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/904a5dd4bc9642cadfdcc5059b96d175ec87ad49

commit 904a5dd4bc9642cadfdcc5059b96d175ec87ad49
Author: mark a. foltz <mfoltz@chromium.org>
Date: Thu Mar 22 18:41:29 2018

[chrome.dial] Remove chrome.dial.

Media Router has launched in-browser discovery of DIAL devices in M63, and
removed usage of chrome.dial from the Media Router component extension.

This removes the API from Chrome as there are no more users.

Bug:  769348 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9bde034fb42ffb05aef1a8d3666775d83cbd1337
Reviewed-on: https://chromium-review.googlesource.com/964800
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Adam Parker <amp@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545170}
[modify] https://crrev.com/904a5dd4bc9642cadfdcc5059b96d175ec87ad49/chrome/browser/extensions/BUILD.gn
[delete] https://crrev.com/89b0c2eb6c0a69d59c90e354b192d1a4d1106c0b/chrome/browser/extensions/api/dial/OWNERS
[delete] https://crrev.com/89b0c2eb6c0a69d59c90e354b192d1a4d1106c0b/chrome/browser/extensions/api/dial/dial_api.cc
[delete] https://crrev.com/89b0c2eb6c0a69d59c90e354b192d1a4d1106c0b/chrome/browser/extensions/api/dial/dial_api.h
[delete] https://crrev.com/89b0c2eb6c0a69d59c90e354b192d1a4d1106c0b/chrome/browser/extensions/api/dial/dial_api_factory.cc
[delete] https://crrev.com/89b0c2eb6c0a69d59c90e354b192d1a4d1106c0b/chrome/browser/extensions/api/dial/dial_api_factory.h
[delete] https://crrev.com/89b0c2eb6c0a69d59c90e354b192d1a4d1106c0b/chrome/browser/extensions/api/dial/dial_apitest.cc
[modify] https://crrev.com/904a5dd4bc9642cadfdcc5059b96d175ec87ad49/chrome/browser/extensions/browser_context_keyed_service_factories.cc
[modify] https://crrev.com/904a5dd4bc9642cadfdcc5059b96d175ec87ad49/chrome/browser/resources/media_router/extension/manifest.yaml
[modify] https://crrev.com/904a5dd4bc9642cadfdcc5059b96d175ec87ad49/chrome/common/extensions/api/BUILD.gn
[modify] https://crrev.com/904a5dd4bc9642cadfdcc5059b96d175ec87ad49/chrome/common/extensions/api/_api_features.json
[modify] https://crrev.com/904a5dd4bc9642cadfdcc5059b96d175ec87ad49/chrome/common/extensions/api/_permission_features.json
[delete] https://crrev.com/89b0c2eb6c0a69d59c90e354b192d1a4d1106c0b/chrome/common/extensions/api/dial.idl
[modify] https://crrev.com/904a5dd4bc9642cadfdcc5059b96d175ec87ad49/chrome/common/extensions/permissions/chrome_api_permissions.cc
[modify] https://crrev.com/904a5dd4bc9642cadfdcc5059b96d175ec87ad49/chrome/common/extensions/permissions/permission_set_unittest.cc
[modify] https://crrev.com/904a5dd4bc9642cadfdcc5059b96d175ec87ad49/chrome/test/BUILD.gn
[delete] https://crrev.com/89b0c2eb6c0a69d59c90e354b192d1a4d1106c0b/chrome/test/data/extensions/api_test/dial/experimental/device_list.html
[delete] https://crrev.com/89b0c2eb6c0a69d59c90e354b192d1a4d1106c0b/chrome/test/data/extensions/api_test/dial/experimental/device_list.js
[delete] https://crrev.com/89b0c2eb6c0a69d59c90e354b192d1a4d1106c0b/chrome/test/data/extensions/api_test/dial/experimental/discovery.html
[delete] https://crrev.com/89b0c2eb6c0a69d59c90e354b192d1a4d1106c0b/chrome/test/data/extensions/api_test/dial/experimental/discovery.js
[delete] https://crrev.com/89b0c2eb6c0a69d59c90e354b192d1a4d1106c0b/chrome/test/data/extensions/api_test/dial/experimental/discovery_no_listeners.html
[delete] https://crrev.com/89b0c2eb6c0a69d59c90e354b192d1a4d1106c0b/chrome/test/data/extensions/api_test/dial/experimental/discovery_no_listeners.js
[delete] https://crrev.com/89b0c2eb6c0a69d59c90e354b192d1a4d1106c0b/chrome/test/data/extensions/api_test/dial/experimental/fetch_device_description.html
[delete] https://crrev.com/89b0c2eb6c0a69d59c90e354b192d1a4d1106c0b/chrome/test/data/extensions/api_test/dial/experimental/fetch_device_description.js
[delete] https://crrev.com/89b0c2eb6c0a69d59c90e354b192d1a4d1106c0b/chrome/test/data/extensions/api_test/dial/experimental/manifest.json
[delete] https://crrev.com/89b0c2eb6c0a69d59c90e354b192d1a4d1106c0b/chrome/test/data/extensions/api_test/dial/experimental/on_error.html
[delete] https://crrev.com/89b0c2eb6c0a69d59c90e354b192d1a4d1106c0b/chrome/test/data/extensions/api_test/dial/experimental/on_error.js
[delete] https://crrev.com/89b0c2eb6c0a69d59c90e354b192d1a4d1106c0b/chrome/test/data/extensions/api_test/dial/whitelist/manifest.json
[delete] https://crrev.com/89b0c2eb6c0a69d59c90e354b192d1a4d1106c0b/chrome/test/data/extensions/api_test/dial/whitelist/runtest.js
[modify] https://crrev.com/904a5dd4bc9642cadfdcc5059b96d175ec87ad49/extensions/common/permissions/api_permission.h
[modify] https://crrev.com/904a5dd4bc9642cadfdcc5059b96d175ec87ad49/tools/metrics/histograms/enums.xml

Comment 5 by grt@chromium.org, Mar 23 2018

This CL seems to have landed prematurely. The "Chrome Media Router" extension requests the "dial" permission, and therefore hits this DCHECK:

[5488:1860:0323/125303.711:FATAL:permissions_parser.cc(124)] Check failed: feature. Could not find feature for dial
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/865158a6fd96cc4fa16e58765ddc8287a2092fc9

commit 865158a6fd96cc4fa16e58765ddc8287a2092fc9
Author: mark a. foltz <mfoltz@chromium.org>
Date: Fri Mar 23 16:44:24 2018

Revert "[chrome.dial] Remove chrome.dial."

This reverts commit 904a5dd4bc9642cadfdcc5059b96d175ec87ad49.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> [chrome.dial] Remove chrome.dial.
> 
> Media Router has launched in-browser discovery of DIAL devices in M63, and
> removed usage of chrome.dial from the Media Router component extension.
> 
> This removes the API from Chrome as there are no more users.
> 
> Bug:  769348 
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: I9bde034fb42ffb05aef1a8d3666775d83cbd1337
> Reviewed-on: https://chromium-review.googlesource.com/964800
> Commit-Queue: mark a. foltz <mfoltz@chromium.org>
> Reviewed-by: mark a. foltz <mfoltz@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
> Reviewed-by: Adam Parker <amp@chromium.org>
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#545170}

TBR=lazyboy@chromium.org,mfoltz@chromium.org,isherman@chromium.org,rockot@chromium.org,amp@chromium.org

Change-Id: I036449eae45fae20e3f60f43a71d9dc4e709a3b4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  769348 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/978481
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545484}
[modify] https://crrev.com/865158a6fd96cc4fa16e58765ddc8287a2092fc9/chrome/browser/extensions/BUILD.gn
[add] https://crrev.com/865158a6fd96cc4fa16e58765ddc8287a2092fc9/chrome/browser/extensions/api/dial/OWNERS
[add] https://crrev.com/865158a6fd96cc4fa16e58765ddc8287a2092fc9/chrome/browser/extensions/api/dial/dial_api.cc
[add] https://crrev.com/865158a6fd96cc4fa16e58765ddc8287a2092fc9/chrome/browser/extensions/api/dial/dial_api.h
[add] https://crrev.com/865158a6fd96cc4fa16e58765ddc8287a2092fc9/chrome/browser/extensions/api/dial/dial_api_factory.cc
[add] https://crrev.com/865158a6fd96cc4fa16e58765ddc8287a2092fc9/chrome/browser/extensions/api/dial/dial_api_factory.h
[add] https://crrev.com/865158a6fd96cc4fa16e58765ddc8287a2092fc9/chrome/browser/extensions/api/dial/dial_apitest.cc
[modify] https://crrev.com/865158a6fd96cc4fa16e58765ddc8287a2092fc9/chrome/browser/extensions/browser_context_keyed_service_factories.cc
[modify] https://crrev.com/865158a6fd96cc4fa16e58765ddc8287a2092fc9/chrome/browser/resources/media_router/extension/manifest.yaml
[modify] https://crrev.com/865158a6fd96cc4fa16e58765ddc8287a2092fc9/chrome/common/extensions/api/BUILD.gn
[modify] https://crrev.com/865158a6fd96cc4fa16e58765ddc8287a2092fc9/chrome/common/extensions/api/_api_features.json
[modify] https://crrev.com/865158a6fd96cc4fa16e58765ddc8287a2092fc9/chrome/common/extensions/api/_permission_features.json
[add] https://crrev.com/865158a6fd96cc4fa16e58765ddc8287a2092fc9/chrome/common/extensions/api/dial.idl
[modify] https://crrev.com/865158a6fd96cc4fa16e58765ddc8287a2092fc9/chrome/common/extensions/permissions/chrome_api_permissions.cc
[modify] https://crrev.com/865158a6fd96cc4fa16e58765ddc8287a2092fc9/chrome/common/extensions/permissions/permission_set_unittest.cc
[modify] https://crrev.com/865158a6fd96cc4fa16e58765ddc8287a2092fc9/chrome/test/BUILD.gn
[add] https://crrev.com/865158a6fd96cc4fa16e58765ddc8287a2092fc9/chrome/test/data/extensions/api_test/dial/experimental/device_list.html
[add] https://crrev.com/865158a6fd96cc4fa16e58765ddc8287a2092fc9/chrome/test/data/extensions/api_test/dial/experimental/device_list.js
[add] https://crrev.com/865158a6fd96cc4fa16e58765ddc8287a2092fc9/chrome/test/data/extensions/api_test/dial/experimental/discovery.html
[add] https://crrev.com/865158a6fd96cc4fa16e58765ddc8287a2092fc9/chrome/test/data/extensions/api_test/dial/experimental/discovery.js
[add] https://crrev.com/865158a6fd96cc4fa16e58765ddc8287a2092fc9/chrome/test/data/extensions/api_test/dial/experimental/discovery_no_listeners.html
[add] https://crrev.com/865158a6fd96cc4fa16e58765ddc8287a2092fc9/chrome/test/data/extensions/api_test/dial/experimental/discovery_no_listeners.js
[add] https://crrev.com/865158a6fd96cc4fa16e58765ddc8287a2092fc9/chrome/test/data/extensions/api_test/dial/experimental/fetch_device_description.html
[add] https://crrev.com/865158a6fd96cc4fa16e58765ddc8287a2092fc9/chrome/test/data/extensions/api_test/dial/experimental/fetch_device_description.js
[add] https://crrev.com/865158a6fd96cc4fa16e58765ddc8287a2092fc9/chrome/test/data/extensions/api_test/dial/experimental/manifest.json
[add] https://crrev.com/865158a6fd96cc4fa16e58765ddc8287a2092fc9/chrome/test/data/extensions/api_test/dial/experimental/on_error.html
[add] https://crrev.com/865158a6fd96cc4fa16e58765ddc8287a2092fc9/chrome/test/data/extensions/api_test/dial/experimental/on_error.js
[add] https://crrev.com/865158a6fd96cc4fa16e58765ddc8287a2092fc9/chrome/test/data/extensions/api_test/dial/whitelist/manifest.json
[add] https://crrev.com/865158a6fd96cc4fa16e58765ddc8287a2092fc9/chrome/test/data/extensions/api_test/dial/whitelist/runtest.js
[modify] https://crrev.com/865158a6fd96cc4fa16e58765ddc8287a2092fc9/extensions/common/permissions/api_permission.h
[modify] https://crrev.com/865158a6fd96cc4fa16e58765ddc8287a2092fc9/tools/metrics/histograms/enums.xml

Comment 7 by mfo...@chromium.org, Mar 23 2018

Labels: -M-67 M-68
It may be safest to wait until M67 branches, to guarantee that all users get a component with the permission removed.
 
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c4a4beaf3feb5f0e9b16b2e71aa1065c4d6c28c

commit 1c4a4beaf3feb5f0e9b16b2e71aa1065c4d6c28c
Author: mark a. foltz <mfoltz@chromium.org>
Date: Wed Mar 28 03:21:42 2018

Reland "[chrome.dial] Remove chrome.dial."

This reverts commit 865158a6fd96cc4fa16e58765ddc8287a2092fc9.

Reason for revert: Fix DCHECK by removing kDial from chrome_api_permissions.cc.

Original change's description:
> Revert "[chrome.dial] Remove chrome.dial."
>
> This reverts commit 904a5dd4bc9642cadfdcc5059b96d175ec87ad49.
>
> Reason for revert: ChromeOS developers with older Media Router component extensions hit DCHECK.
>
> Original change's description:
> > [chrome.dial] Remove chrome.dial.
> >
> > Media Router has launched in-browser discovery of DIAL devices in M63, and
> > removed usage of chrome.dial from the Media Router component extension.
> >
> > This removes the API from Chrome as there are no more users.
> >
> > Bug:  769348 
> > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> > Change-Id: I9bde034fb42ffb05aef1a8d3666775d83cbd1337
> > Reviewed-on: https://chromium-review.googlesource.com/964800
> > Commit-Queue: mark a. foltz <mfoltz@chromium.org>
> > Reviewed-by: mark a. foltz <mfoltz@chromium.org>
> > Reviewed-by: Ilya Sherman <isherman@chromium.org>
> > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
> > Reviewed-by: Adam Parker <amp@chromium.org>
> > Reviewed-by: Ken Rockot <rockot@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#545170}
>
> TBR=lazyboy@chromium.org,mfoltz@chromium.org,isherman@chromium.org,rockot@chromium.org,amp@chromium.org
>
> Change-Id: I036449eae45fae20e3f60f43a71d9dc4e709a3b4
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  769348 
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Reviewed-on: https://chromium-review.googlesource.com/978481
> Reviewed-by: mark a. foltz <mfoltz@chromium.org>
> Commit-Queue: mark a. foltz <mfoltz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#545484}

Bug:  769348 
Change-Id: I6698158cc20978abb2f45a1af56d63001850abbf
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/982413
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Adam Parker <amp@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546388}
[modify] https://crrev.com/1c4a4beaf3feb5f0e9b16b2e71aa1065c4d6c28c/chrome/browser/extensions/BUILD.gn
[delete] https://crrev.com/7b9cdd7b9011e0d87f4c15944cdde333e83ba758/chrome/browser/extensions/api/dial/OWNERS
[delete] https://crrev.com/7b9cdd7b9011e0d87f4c15944cdde333e83ba758/chrome/browser/extensions/api/dial/dial_api.cc
[delete] https://crrev.com/7b9cdd7b9011e0d87f4c15944cdde333e83ba758/chrome/browser/extensions/api/dial/dial_api.h
[delete] https://crrev.com/7b9cdd7b9011e0d87f4c15944cdde333e83ba758/chrome/browser/extensions/api/dial/dial_api_factory.cc
[delete] https://crrev.com/7b9cdd7b9011e0d87f4c15944cdde333e83ba758/chrome/browser/extensions/api/dial/dial_api_factory.h
[delete] https://crrev.com/7b9cdd7b9011e0d87f4c15944cdde333e83ba758/chrome/browser/extensions/api/dial/dial_apitest.cc
[modify] https://crrev.com/1c4a4beaf3feb5f0e9b16b2e71aa1065c4d6c28c/chrome/browser/extensions/browser_context_keyed_service_factories.cc
[modify] https://crrev.com/1c4a4beaf3feb5f0e9b16b2e71aa1065c4d6c28c/chrome/browser/resources/media_router/extension/manifest.yaml
[modify] https://crrev.com/1c4a4beaf3feb5f0e9b16b2e71aa1065c4d6c28c/chrome/common/extensions/api/BUILD.gn
[modify] https://crrev.com/1c4a4beaf3feb5f0e9b16b2e71aa1065c4d6c28c/chrome/common/extensions/api/_api_features.json
[modify] https://crrev.com/1c4a4beaf3feb5f0e9b16b2e71aa1065c4d6c28c/chrome/common/extensions/api/_permission_features.json
[delete] https://crrev.com/7b9cdd7b9011e0d87f4c15944cdde333e83ba758/chrome/common/extensions/api/dial.idl
[modify] https://crrev.com/1c4a4beaf3feb5f0e9b16b2e71aa1065c4d6c28c/chrome/common/extensions/permissions/chrome_api_permissions.cc
[modify] https://crrev.com/1c4a4beaf3feb5f0e9b16b2e71aa1065c4d6c28c/chrome/common/extensions/permissions/permission_set_unittest.cc
[modify] https://crrev.com/1c4a4beaf3feb5f0e9b16b2e71aa1065c4d6c28c/chrome/test/BUILD.gn
[delete] https://crrev.com/7b9cdd7b9011e0d87f4c15944cdde333e83ba758/chrome/test/data/extensions/api_test/dial/experimental/device_list.html
[delete] https://crrev.com/7b9cdd7b9011e0d87f4c15944cdde333e83ba758/chrome/test/data/extensions/api_test/dial/experimental/device_list.js
[delete] https://crrev.com/7b9cdd7b9011e0d87f4c15944cdde333e83ba758/chrome/test/data/extensions/api_test/dial/experimental/discovery.html
[delete] https://crrev.com/7b9cdd7b9011e0d87f4c15944cdde333e83ba758/chrome/test/data/extensions/api_test/dial/experimental/discovery.js
[delete] https://crrev.com/7b9cdd7b9011e0d87f4c15944cdde333e83ba758/chrome/test/data/extensions/api_test/dial/experimental/discovery_no_listeners.html
[delete] https://crrev.com/7b9cdd7b9011e0d87f4c15944cdde333e83ba758/chrome/test/data/extensions/api_test/dial/experimental/discovery_no_listeners.js
[delete] https://crrev.com/7b9cdd7b9011e0d87f4c15944cdde333e83ba758/chrome/test/data/extensions/api_test/dial/experimental/fetch_device_description.html
[delete] https://crrev.com/7b9cdd7b9011e0d87f4c15944cdde333e83ba758/chrome/test/data/extensions/api_test/dial/experimental/fetch_device_description.js
[delete] https://crrev.com/7b9cdd7b9011e0d87f4c15944cdde333e83ba758/chrome/test/data/extensions/api_test/dial/experimental/manifest.json
[delete] https://crrev.com/7b9cdd7b9011e0d87f4c15944cdde333e83ba758/chrome/test/data/extensions/api_test/dial/experimental/on_error.html
[delete] https://crrev.com/7b9cdd7b9011e0d87f4c15944cdde333e83ba758/chrome/test/data/extensions/api_test/dial/experimental/on_error.js
[delete] https://crrev.com/7b9cdd7b9011e0d87f4c15944cdde333e83ba758/chrome/test/data/extensions/api_test/dial/whitelist/manifest.json
[delete] https://crrev.com/7b9cdd7b9011e0d87f4c15944cdde333e83ba758/chrome/test/data/extensions/api_test/dial/whitelist/runtest.js
[modify] https://crrev.com/1c4a4beaf3feb5f0e9b16b2e71aa1065c4d6c28c/extensions/common/permissions/api_permission.h
[modify] https://crrev.com/1c4a4beaf3feb5f0e9b16b2e71aa1065c4d6c28c/tools/metrics/histograms/enums.xml

Comment 9 by mfo...@chromium.org, Mar 31 2018

Status: Fixed (was: Assigned)

Sign in to add a comment