Issue metadata
Sign in to add a comment
|
tools/perf/run_benchmark fails with --mus and --mash |
||||||||||||||||||||||
Issue descriptionThis check fails: https://cs.chromium.org/chromium/src/services/ui/ws/event_dispatcher.cc?l=315 Unfortunately I have not been able to reproduce the error by just running the chrome --mus. So far, the only way I was able to reproduce the error is by running: tools/perf/run_benchmark run system_health.memory_desktop --story-filter=browse:news:cnn --browser-executable=out/mash/chrome --browser-logging-verbosity=non-verbose --pageset-repeat=1 --extra-browser-args="--gpu-no-complete-info-collection --mus" It seems to be caused by https://chromium-review.googlesource.com/c/chromium/src/+/659103 (I can run benchmarks with --mus and --mash if I sync before that). sky@ could you please take a look? The stack trace is (full log is attached): [1732:1774:0927/113212.377295:FATAL:event_dispatcher.cc(315)] Check failed: event_location.location == event.AsPointerEvent()->location_f(). #0 0x7fb1285078ec base::debug::StackTrace::StackTrace() #1 0x7fb12852d41c logging::LogMessage::~LogMessage() #2 0x009b167d5e0e <unknown> #3 0x009b167b8763 <unknown> #4 0x009b167b802a <unknown> #5 0x009b167d3e8d <unknown> #6 0x009b167b1b77 <unknown> #7 0x009b14836a36 <unknown> #8 0x009b14e103a6 <unknown> #9 0x7fb12772deec mojo::InterfaceEndpointClient::HandleValidatedMessage() #10 0x7fb12772d846 mojo::FilterChain::Accept() #11 0x7fb12772f235 mojo::InterfaceEndpointClient::HandleIncomingMessage() #12 0x7fb127739154 mojo::internal::MultiplexRouter::ProcessIncomingMessage() #13 0x7fb1277386a4 mojo::internal::MultiplexRouter::Accept() #14 0x7fb12772d846 mojo::FilterChain::Accept() #15 0x7fb127728a45 mojo::Connector::ReadSingleMessage() #16 0x7fb127729531 mojo::Connector::ReadAllAvailableMessages() #17 0x7fb1277293d9 mojo::Connector::OnHandleReadyInternal() #18 0x7fb127729b85 mojo::SimpleWatcher::DiscardReadyState() #19 0x7fb1276f2e74 mojo::SimpleWatcher::OnHandleReady() #20 0x7fb1276f33b1 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo13SimpleWatcherEFvijRKNS3_18HandleSignalsStateEEJNS_7WeakPtrIS4_EEijS5_EEEFvvEE7RunImplIRKS9_RKNSt3__15tupleIJSB_ijS5_EEEJLm0ELm1ELm2ELm3EEEEvOT_OT0_NSI_16integer_sequenceImJXspT1_EEEE #21 0x7fb12850817f base::debug::TaskAnnotator::RunTask() #22 0x7fb128537ab9 base::internal::IncomingTaskQueue::RunTask() #23 0x7fb128539d63 base::MessageLoop::RunTask() #24 0x7fb12853a48e base::MessageLoop::DoWork() #25 0x7fb12853cd29 base::MessagePumpLibevent::Run() #26 0x7fb128539872 base::MessageLoop::Run() #27 0x7fb12856db8f base::RunLoop::Run() #28 0x7fb1285aaea7 base::Thread::Run() #29 0x7fb1285ab45c base::Thread::ThreadMain() #30 0x7fb1285a281f base::(anonymous namespace)::ThreadFunc() #31 0x7fb12867e184 start_thread #32 0x7fb11c618ffd clone Thanks a lot!
,
Sep 27 2017
'test_chrome' should be the only target you need to build.
Note that running the telemetry tests with the 'chrome' binary will not work all the time (e.g. tests that do input event injection will not work). So we need to always use 'test_chrome' binary for that.
So:
. build 'test_chrome' target.
. Use 'test_chrome' binary to run the test, i.e.
tools/perf/run_benchmark run system_health.memory_desktop \
--story-filter=browse:news:cnn \
--browser=exact \
--browser-executable=out/mash/test_chrome \ # Note 'test_chrome', not 'chrome'
--browser-logging-verbosity=non-verbose \
--pageset-repeat=1 \
--extra-browser-args="--gpu-no-complete-info-collection --mus"
,
Sep 29 2017
,
Nov 2 2017
,
Feb 26 2018
,
Aug 3
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
,
Nov 5
You can now run these tests with single-process-mash, so moving to fixed. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sky@chromium.org
, Sep 27 2017