[LUCI-Beta-Bug] Builder overview missing useful information about failures |
||||||||
Issue descriptionTalking about this view: https://ci.chromium.org/buildbucket/luci.chromium.try/linux_chromium_rel_ng?limit=100 All of the information there may be useful in some capacity, but contrast this with the old Buildbot view: https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng?numbuilds=100 When sheriffing or trying to understand CQ failures on my own WIP CLs, I have found the "Info" column in the Buildbot view to be incredibly useful for quick diagnosis. It often provides a clear and immediate signal that a given failure is either isolated or ongoing; and if the latter, it's also often quite easy to see approximately or exactly when the failure started. The new UI seems to require a navigation to individual build pages to get that much information, and this seems like a noticeably less efficient workflow.
,
Sep 28 2017
,
Sep 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/003997a03ad29f413bc85816cb6928d350deb349 commit 003997a03ad29f413bc85816cb6928d350deb349 Author: Nodir Turakulov <nodir@google.com> Date: Fri Sep 29 00:20:44 2017 [kitchen] populate root annotation step text Set root annotation step text to a list of failed steps R=iannucci@chromium.org Bug: 769338 Change-Id: Icf40c8a0cf30c5f418716e3aa69fbfeecc6c19d6 Reviewed-on: https://chromium-review.googlesource.com/691296 Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org> [modify] https://crrev.com/003997a03ad29f413bc85816cb6928d350deb349/go/src/infra/tools/kitchen/cook.go
,
Oct 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/3fcdd4db20d660afd545d7809d678e0db7276203 commit 3fcdd4db20d660afd545d7809d678e0db7276203 Author: Nodir Turakulov <nodir@google.com> Date: Wed Oct 04 19:48:58 2017 [buildbucket] include annotations in Build Milo builder page that sends a query to buildbucket, needs to render "Info" column which is annotation's root step Text. (that's what build page does). For that it needs an annotation in the buildbucket repsonse. The annotation were excluded because we might hit the datastore entity size limit. iannucci@ and nodir@ made estimations based on one of long builds, compressed it and we were still way below limit. Even if we hit the limit, pubsub handler will start failing for that particular build and the build won't be updated. We will be able to apply a fix and eventually the build will be processed. Stop excluding annotation from build_run_result and compress result_details property. R=iannucci@chromium.org Bug: 769338 Change-Id: I8261e0544a36e3c62f59da6fd7fdd50002d8f8ef Reviewed-on: https://chromium-review.googlesource.com/691203 Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org> [modify] https://crrev.com/3fcdd4db20d660afd545d7809d678e0db7276203/appengine/cr-buildbucket/swarming/swarming.py [modify] https://crrev.com/3fcdd4db20d660afd545d7809d678e0db7276203/appengine/cr-buildbucket/model.py
,
Oct 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-go.git/+/08cf3585764b0e215589c9c34773201f7f9525bf commit 08cf3585764b0e215589c9c34773201f7f9525bf Author: Nodir Turakulov <nodir@google.com> Date: Fri Oct 06 05:06:26 2017 [milo] include completed builds in builder tests buildbucket/builder_test.go ignores test data of completed builds. Include them in tests R=iannucci@chromium.org Bug: 769338 Change-Id: I19325060550c80a2b065be3ac0b55354a7111030 Reviewed-on: https://chromium-review.googlesource.com/692578 Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org> [modify] https://crrev.com/08cf3585764b0e215589c9c34773201f7f9525bf/milo/buildsource/buildbucket/builder_test.go [modify] https://crrev.com/08cf3585764b0e215589c9c34773201f7f9525bf/milo/buildsource/buildbucket/expectations/master.tryserver.infra/InfraPresubmit.Swarming.json [modify] https://crrev.com/08cf3585764b0e215589c9c34773201f7f9525bf/milo/buildsource/buildbucket/expectations/master.tryserver.infra/InfraPresubmit.json
,
Oct 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-go.git/+/f92b785f558a6fbf1e431ceb2fc4af59a2a5daa8 commit f92b785f558a6fbf1e431ceb2fc4af59a2a5daa8 Author: Nodir Turakulov <nodir@google.com> Date: Fri Oct 06 06:30:56 2017 [milo] report failure reason in builder view Display the most essentialy info about the builder, stored in the annotation root step text, in the builder view's info column R=iannucci@chromium.org Bug: 769338 Change-Id: Ida7659b40a4cf2f09995683cf8b285f7eaf8a9f2 Reviewed-on: https://chromium-review.googlesource.com/687855 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/f92b785f558a6fbf1e431ceb2fc4af59a2a5daa8/milo/buildsource/buildbucket/builder.go [modify] https://crrev.com/f92b785f558a6fbf1e431ceb2fc4af59a2a5daa8/milo/buildsource/buildbucket/expectations/master.tryserver.infra/InfraPresubmit.Swarming.json [modify] https://crrev.com/f92b785f558a6fbf1e431ceb2fc4af59a2a5daa8/milo/buildsource/buildbucket/expectations/master.tryserver.infra/InfraPresubmit.json [modify] https://crrev.com/f92b785f558a6fbf1e431ceb2fc4af59a2a5daa8/milo/buildsource/buildbucket/properties.go [modify] https://crrev.com/f92b785f558a6fbf1e431ceb2fc4af59a2a5daa8/milo/buildsource/buildbucket/testdata/master.tryserver.infra/InfraPresubmit.Swarming.json
,
Oct 7 2017
,
Oct 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/a7ec722fce57a6d3f5157c8c984122c9c941e02c commit a7ec722fce57a6d3f5157c8c984122c9c941e02c Author: Nodir Turakulov <nodir@google.com> Date: Sat Oct 07 00:51:23 2017 [kithen] fix build info generation TBR=iannucci@chromium.org, hinoka@chromium.org Bug: 769338 Change-Id: I0dba9f923d683e42c3b3c6bf26d04d8791a730de Reviewed-on: https://chromium-review.googlesource.com/706185 Reviewed-by: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org> [modify] https://crrev.com/a7ec722fce57a6d3f5157c8c984122c9c941e02c/go/src/infra/tools/kitchen/cook.go
,
Oct 7 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/0dd76fb868d56766656b6cd7e3b414970177644b commit 0dd76fb868d56766656b6cd7e3b414970177644b Author: Nodir Turakulov <nodir@google.com> Date: Sat Oct 07 02:15:23 2017
,
Oct 10 2017
,
Oct 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/eda873ef31a7fa0ac9e5ef8a4761dd9b7df23086 commit eda873ef31a7fa0ac9e5ef8a4761dd9b7df23086 Author: Nodir Turakulov <nodir@google.com> Date: Tue Oct 17 21:19:55 2017 [kitchen] omit "Failure reason" step Recipe engine produces synthetic step "Failure reason" in the end of a failed run. Currently it causes "Failure Failure reason" on build pages: https://ci.chromium.org/buildbucket/luci.webrtc.try/android_rel Exclude it from the root step text. TBR=iannucci@chromium.org Bug: 769338 Change-Id: Ib6ab141c49015c9b26c9dadb584f5a24d7592889 Reviewed-on: https://chromium-review.googlesource.com/716303 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org> [modify] https://crrev.com/eda873ef31a7fa0ac9e5ef8a4761dd9b7df23086/go/src/infra/tools/kitchen/cook.go
,
Oct 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/f07f4a1446eadefed3d8e8315810b078bc9350ca commit f07f4a1446eadefed3d8e8315810b078bc9350ca Author: Nodir Turakulov <nodir@google.com> Date: Mon Oct 23 16:11:25 2017 Revert "[buildbucket] include annotations in Build" This reverts commit 3fcdd4db20d660afd545d7809d678e0db7276203. Reason for revert: suspecting that it caused 18K times higher OOM rate Original change's description: > [buildbucket] include annotations in Build > > Milo builder page that sends a query to buildbucket, needs to render "Info" > column which is annotation's root step Text. (that's what build page does). > For that it needs an annotation in the buildbucket repsonse. > > The annotation were excluded because we might hit the datastore entity size > limit. iannucci@ and nodir@ made estimations based on one of long builds, > compressed it and we were still way below limit. Even if we hit the limit, > pubsub handler will start failing for that particular build and the build > won't be updated. We will be able to apply a fix and eventually the build will > be processed. > > Stop excluding annotation from build_run_result and compress result_details > property. > > R=iannucci@chromium.org > Bug: 769338 > Change-Id: I8261e0544a36e3c62f59da6fd7fdd50002d8f8ef > Reviewed-on: https://chromium-review.googlesource.com/691203 > Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> > Commit-Queue: Nodir Turakulov <nodir@chromium.org> TBR=iannucci@chromium.org,vadimsh@chromium.org,nodir@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 769338 , 777271 Change-Id: I71a35d5fd7f548b2ab3defbf21ebbbcfb49135d3 Reviewed-on: https://chromium-review.googlesource.com/731796 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org> [modify] https://crrev.com/f07f4a1446eadefed3d8e8315810b078bc9350ca/appengine/cr-buildbucket/swarming/swarming.py [modify] https://crrev.com/f07f4a1446eadefed3d8e8315810b078bc9350ca/appengine/cr-buildbucket/model.py
,
Oct 23 2017
we will implement this feature in a slightly different way
,
Oct 24 2017
https://chromium-review.googlesource.com/c/infra/infra/+/731861 was related to this bug
,
Oct 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-go.git/+/9fa383ade49a39de14447614128a8889a9041d09 commit 9fa383ade49a39de14447614128a8889a9041d09 Author: Nodir Turakulov <nodir@google.com> Date: Tue Oct 24 03:02:16 2017 [milo] parse new result_details.ui.text https://chromium-review.googlesource.com/c/infra/infra/+/731796 and https://chromium-review.googlesource.com/c/infra/infra/+/731861 rename the location of build info in result_details. Update Milo code. Bug: 769338 Change-Id: I03f6ce1e59823a697376a09482944c723e9ede6c Reviewed-on: https://chromium-review.googlesource.com/734705 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/9fa383ade49a39de14447614128a8889a9041d09/milo/buildsource/buildbucket/builder.go [modify] https://crrev.com/9fa383ade49a39de14447614128a8889a9041d09/milo/buildsource/buildbucket/expectations/master.tryserver.infra/InfraPresubmit.Swarming.json [modify] https://crrev.com/9fa383ade49a39de14447614128a8889a9041d09/milo/buildsource/buildbucket/testdata/master.tryserver.infra/InfraPresubmit.Swarming.json
,
Oct 24 2017
,
Jan 31 2018
,
Feb 13 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by no...@chromium.org
, Sep 27 2017Labels: Pri-1 Type-Feature
Owner: no...@chromium.org
Status: Started (was: Untriaged)