factory: Better sync time goofy plugin |
||
Issue descriptionContinue work for https://chromium-review.googlesource.com/c/chromiumos/platform/factory/+/686335/ Stimim and I reviewed the time_sanitizer plugin and found that it's not enabled by default today (periodic=0) , and even if we enable it, it's still probably not very helpful. Currently time sanitizer will try to reach factory server, and retry after periodic_secs, and will stop syncing if it has synced successfully one time. However, for most factories, DUT will boot without network, and will only be connected for certain tests (for example sync_factory_server). This makes the sanitizer plugin useless because it's hard to set periodic_secs. As a result, we think the plugin should be changed to wait until network is considered as available (should be notified instead of polling), start the sync, then stop. Also, using htpdate is better than the poor python implementation.
,
Sep 7
,
Sep 28
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/b42a98e5f2ec841785dd3383b64357ee4df14d49 commit b42a98e5f2ec841785dd3383b64357ee4df14d49 Author: Hsin-Yi, Wang <hsinyi@google.com> Date: Fri Sep 28 17:10:59 2018 time_sanitizer: Add htpdate method to sync time with factory server. Replace original python proxy implementation with htpdate method. BUG=chromium:769337 TEST=manually Change-Id: I66ee918dc90c1cc6301670ab349f1f12db01fcb2 Reviewed-on: https://chromium-review.googlesource.com/1183264 Commit-Ready: Hsin-Yi Wang <hsinyi@chromium.org> Tested-by: Hsin-Yi Wang <hsinyi@chromium.org> Reviewed-by: Youcheng Syu <youcheng@chromium.org> [modify] https://crrev.com/b42a98e5f2ec841785dd3383b64357ee4df14d49/py/utils/net_utils.py [modify] https://crrev.com/b42a98e5f2ec841785dd3383b64357ee4df14d49/py/goofy/plugins/goofy_plugin_chromeos.json [modify] https://crrev.com/b42a98e5f2ec841785dd3383b64357ee4df14d49/py/tools/time_sanitizer_unittest.py [modify] https://crrev.com/b42a98e5f2ec841785dd3383b64357ee4df14d49/py/test/utils/time_utils.py [modify] https://crrev.com/b42a98e5f2ec841785dd3383b64357ee4df14d49/py/tools/time_sanitizer.py [modify] https://crrev.com/b42a98e5f2ec841785dd3383b64357ee4df14d49/py/goofy/plugins/time_sanitizer.py
,
Today
(3 hours ago)
@hsinyi, is this completed? |
||
►
Sign in to add a comment |
||
Comment 1 by hungte@chromium.org
, Aug 15Owner: hsinyi@chromium.org