New issue
Advanced search Search tips

Issue 769336 link

Starred by 1 user
Status: Verified
Owner:
mahmadi@chromium.org
Closed: Sep 2017
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

PaymentsTextItem has extraneous right padding in RTL

Project Member Reported by mahmadi@chromium.org, Sep 27 2017 
PaymentsTextItem should have a trailing padding instead of a right padding. A right padding breaks the UI in RTL.
rtl-padding.png
88.4 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d50fe026a4f7e1da89ad90770500867282c3b2e

commit 4d50fe026a4f7e1da89ad90770500867282c3b2e
Author: Mohamad Ahmadi <mahmadi@chromium.org>
Date: Wed Sep 27 16:55:37 2017

[Payment Request] Fixes the PaymentsTextItem's extra right padding in RTL

Bug:  769336 
Change-Id: I218395e5538f8d58a35dcd4fe359de7080d788af
Reviewed-on: https://chromium-review.googlesource.com/687615
Reviewed-by: Marc-Antoine Courteau <macourteau@chromium.org>
Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504707}
[modify] https://crrev.com/4d50fe026a4f7e1da89ad90770500867282c3b2e/ios/chrome/browser/ui/payments/cells/payments_text_item.mm

Comment 2 by mahmadi@chromium.org, Sep 27 2017

Status: Fixed (was: Started)

Comment 3 by shbarezer@chromium.org, Nov 13 2017

Status: Verified (was: Fixed)
Verified in 63.0.3239.48 beta, iPhone 6 iOS 10.3.3, iPhone 7 iOS11, iPad Pro iOS11
Indent is consistent through PaymentsTextItem  when in RTL, tested in Hebrew.
►

Sign in to add a comment