yah, we need to switch over to sdy's cool TabbedBrowserWindowFrame and friends that were added in r492972. (i.e. use it in chrome/browser/ui/views/frame/browser_frame_mac.mm rather than the [[content_view superview] addSubview:..] hack that's still being used in BrowserFrameMac::InitNativeWidget

and... then properly obey params to use a titlebar or not.

MacViews triage: this reproduces; assigning to sdy@ for M-68.

** Bulk Edit **

FYI: Starting 04/13 M68 will be in canary, M68 Dev promotion will be on 04/26.

 Issue 834275  has been merged into this issue.

Bumping this to Pri-1, since it also affects detached dev tools.

 Issue 835069  has been merged into this issue.

Pls mark the bug as fixed if CL is landed in trunk and nothing else is pending. Thank you.

 Issue 837102  has been merged into this issue.

 Issue 837468  has been merged into this issue.

 Issue 837601  has been merged into this issue.

 Issue 831483  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5a640ce8c4fcbe9053db4b617538e5cdcf36471

commit d5a640ce8c4fcbe9053db4b617538e5cdcf36471
Author: Sidney San Martín <sdy@chromium.org>
Date: Wed May 02 13:44:54 2018

Bring back title bars on popup windows in MacViews.

The fix is to use BrowserNativeWidgetWindow only for tabbed windows.

Bug:  769327 
Change-Id: Ice36d327c2c27411ed2a4d15a8c6a78a9e55e347
Reviewed-on: https://chromium-review.googlesource.com/1038545
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555372}
[modify] https://crrev.com/d5a640ce8c4fcbe9053db4b617538e5cdcf36471/chrome/browser/ui/views/frame/browser_frame_mac.mm

Able to reproduce the issue on mac 10.13.3 using the build without fix.

Verified the fix on Mac 10.13.3 using Chrome version #68.0.3418.0 as per the comment #0.
Attaching screen shot for reference.
Observed that the resulting window has title bar as expected.
Hence, the fix is working as expected. 
Adding the verified labels.

Thanks...!!

Deleted: 769327.png 529 KB

	769327.png 529 KB View Download

Thanks for verifying!

Would it be possible to enable the AppLocationBar test in BrowserFocusTest?

https://cs.chromium.org/chromium/src/chrome/browser/ui/browser_focus_uitest.cc?q=browser_focus_uitest.cc&sq=package:chromium&dr&l=838

#17: That test seems to still not work on Mac even with this fix :( it hangs in the final PressTabAndWait(), it's not quite clear to me why.

sdy@, can you take a quick peek there?

:( I was hoping that fixing this issue would make the test work. The test might not be working because of:

https://cs.chromium.org/chromium/src/chrome/browser/ui/browser_focus_uitest.cc?q=browser_focus_uitest.cc&sq=package:chromium&dr&l=148

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8d652b1a25a8496a2d2c2b201d90b2f77564451

commit b8d652b1a25a8496a2d2c2b201d90b2f77564451
Author: Trent Apted <tapted@chromium.org>
Date: Mon May 28 06:12:32 2018

Disable flaky BrowserFocusTest.PopupLocationBar

TBR=ortuno@chromium.org

Bug:  846848 ,  769327 ,  831483 
Change-Id: Iaebe8329099b47a369322541eabb50b8307eca41
Reviewed-on: https://chromium-review.googlesource.com/1074891
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562192}
[modify] https://crrev.com/b8d652b1a25a8496a2d2c2b201d90b2f77564451/chrome/browser/ui/browser_focus_uitest.cc