New issue
Advanced search Search tips

Issue 769323 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

media/controls/captions-menu-always-visible.html flaky on Mac dbg

Project Member Reported by xidac...@chromium.org, Sep 27 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Sep 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8175eb5b610bba08650e92deb140b6fd5265b02

commit a8175eb5b610bba08650e92deb140b6fd5265b02
Author: Xida Chen <xidachen@chromium.org>
Date: Wed Sep 27 15:55:57 2017

Mark media/controls/captions-menu-always-visible.html as flaky on Mac dbg

NOTRY=true
TBR=mlamouri@chromium.org

Bug:  769323 
Change-Id: I8d7e94ba162481c2a73c5164a557f3c85abd2619
Reviewed-on: https://chromium-review.googlesource.com/687279
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504690}
[modify] https://crrev.com/a8175eb5b610bba08650e92deb140b6fd5265b02/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a72d0df644c39679f606e3bb084a8fa20fd9a3db

commit a72d0df644c39679f606e3bb084a8fa20fd9a3db
Author: Xida Chen <xidachen@chromium.org>
Date: Thu Sep 28 13:16:27 2017

Label virtual/new-remote-playback-pipeline/media/controls/captions-menu-always-visible.html flaky

TBR=melandory@chromium.org
NOTRY=true

Bug:  769323 
Change-Id: I7c35b4d4a172fb8ea3e3c978442811c29c4d620b
Reviewed-on: https://chromium-review.googlesource.com/690315
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504996}
[modify] https://crrev.com/a72d0df644c39679f606e3bb084a8fa20fd9a3db/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1d9de6a8a92efed7b8719802b12574695068230

commit c1d9de6a8a92efed7b8719802b12574695068230
Author: Yuta Kitamura <yutak@chromium.org>
Date: Mon Oct 23 09:19:13 2017

Layout test captions-menu-always-visible.html is flaky.

TBR=battre@chromium.org

Bug:  776107 ,  769323 
Change-Id: Ib0ee750a8415af498fc403eb218a96214b4d233c
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/732868
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510744}
[modify] https://crrev.com/c1d9de6a8a92efed7b8719802b12574695068230/third_party/WebKit/LayoutTests/TestExpectations

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e2127f5b969f54e31f4e81fd414949cf7833ad9

commit 4e2127f5b969f54e31f4e81fd414949cf7833ad9
Author: Dominic Battre <battre@chromium.org>
Date: Mon Oct 23 10:24:28 2017

Layout test media/controls/overflow-menu-always-visible.html is flaky

TBR=yutak@chromium.org

Bug:  776107 ,  769323 
Change-Id: I9eead8bb9b927a68bfc90aa3332d3217f1d60aff
Reviewed-on: https://chromium-review.googlesource.com/732658
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510751}
[modify] https://crrev.com/4e2127f5b969f54e31f4e81fd414949cf7833ad9/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e9451814cc0329083e6a3eeac30cfb67ab75c46

commit 2e9451814cc0329083e6a3eeac30cfb67ab75c46
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Mon Oct 23 14:00:10 2017

Media Controls: fix flakyness when testing if menu is always on top.

This is fixed by disabling pointer events on the text track and
overflow menus. The :hover effect would otherwise apply randomly,
breaking the pixel comparison tests.

Bug:  776107 ,  769323 
Change-Id: I6aded9a5bf21af062ee3c0cff7770189f63d2cca
Reviewed-on: https://chromium-review.googlesource.com/728219
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510782}
[modify] https://crrev.com/2e9451814cc0329083e6a3eeac30cfb67ab75c46/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/2e9451814cc0329083e6a3eeac30cfb67ab75c46/third_party/WebKit/LayoutTests/media/controls/captions-menu-always-visible-expected.html
[modify] https://crrev.com/2e9451814cc0329083e6a3eeac30cfb67ab75c46/third_party/WebKit/LayoutTests/media/controls/captions-menu-always-visible.html
[modify] https://crrev.com/2e9451814cc0329083e6a3eeac30cfb67ab75c46/third_party/WebKit/LayoutTests/media/controls/overflow-menu-always-visible-expected.html
[modify] https://crrev.com/2e9451814cc0329083e6a3eeac30cfb67ab75c46/third_party/WebKit/LayoutTests/media/controls/overflow-menu-always-visible.html
[modify] https://crrev.com/2e9451814cc0329083e6a3eeac30cfb67ab75c46/third_party/WebKit/LayoutTests/media/media-controls.js

Status: Fixed (was: Started)

Sign in to add a comment