New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 769304 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 756688



Sign in to add a comment

Missing file //build/config/gclient_args.gni in project depending on build subtree mirror

Project Member Reported by oprypin@chromium.org, Sep 27 2017

Issue description

https://chromium-review.googlesource.com/681854 adds a dependency on build/config/gclient_args.gni but it is not present in the build repository: https://chromium.googlesource.com/chromium/src/build/+/master/config/gclient_args.gni

WebRTC (and possibly other projects depending on this repository) is unable to build with this change.

Example of failure:
https://webrtc-review.googlesource.com/c/src/+/4000

/b/c/b/linux_rel/src/buildtools/linux64/gn gen //out/Release --check --runtime-deps-list-file=/b/c/b/linux_rel/src/out/Release/runtime_deps
  -> returned 1
ERROR at //build/config/features.gni:19:1: Can't load input file.
import("//build/config/gclient_args.gni")
^---------------------------------------
Unable to load:
  /b/c/b/linux_rel/src/build/config/gclient_args.gni
I also checked in the secondary tree for:
  /b/c/b/linux_rel/src/build/secondary/build/config/gclient_args.gni
See //webrtc.gni:10:1: whence it was imported.
import("//build/config/features.gni")
^-----------------------------------
See //BUILD.gn:11:1: whence it was imported.
import("webrtc.gni")
^------------------


Please revert or fix this.
 
Labels: -Pri-3 Pri-1
Cc: dpranke@chromium.org
Cc: phajdan@google.com
Looking (feel free to ping me on IM).
Blocking: 756688
Components: Infra>Client>WebRTC
Labels: -Pri-1 Pri-2
It appears this missing file is supposed to be generated during gclient sync, so we should look into why we don't get it in our WebRTC checkouts. I assume we might just need to add a DEPS entry and/or other configuration.

Downgrading as this only blocks us from rolling our DEPS.
Didn't reverting the change fix things?
It did. All is green in https://webrtc-review.googlesource.com/c/src/+/4220
Thanks
Owner: oprypin@chromium.org
Status: Assigned (was: Untriaged)
Do we know which files were including features.gni? Ideally that'd be a chrome-specific file and not in //build at all. I wouldn't be surprised if WebRTC had dependencies on it either directly or indirectly, though, and I'd like to figure out how to remove them.
This is still appears to be an issue.

[364/364] c++ -pthread -o gn -Wl,--start-group tools/gn/gn_main.o libevent.a base.a xdg_user_dirs.a gn_lib.a dynamic_annotations.a -Wl,--end-group -lrt -latomic
DEBUG:root:Running: /tmp/tmpJsNG3z/gn gen /home/chromium/rpmbuild/BUILD/chromium-65.0.3284.0.fc26/out/Release --args= enable_nacl=true enable_extensions=true enable_plugins=true enable_hangout_services_extension=true enable_nacl=true enable_webrtc=true enable_widevine=true fatal_linker_warnings=false ffmpeg_branding="Chrome" fieldtrial_testing_like_official_build=false use_gold=false google_api_key="AIzaSyAyodftWUaa60mRyIg3yQf6qTyoqG6onoA" google_default_client_id="455952514983-bkdti85j7d5mepifnbd4g0i0q5jhqrk6.apps.googleusercontent.com" google_default_client_secret="qlboaV9RDmU3RBWmbi-pkW2y" is_clang=false is_component_ffmpeg=false is_debug=false use_gnome_keyring=false proprietary_codecs=true remove_webcore_debug_symbols=true target_cpu="x64" target_os="linux" treat_warnings_as_errors=false use_allocator="none" use_cups=true use_gconf=true use_gtk3=true use_libfuzzer=false use_pulseaudio=true use_sanitizer_coverage=false use_sysroot=false use_system_harfbuzz=true use_system_libjpeg=true use_libjpeg_turbo=true use_system_sqlite=false use_system_zlib=true symbol_level=0 is_official_build=false is_debug=false
ERROR at //components/nacl/features.gni:6:1: Can't load input file.
import("//build/config/gclient_args.gni")
^---------------------------------------
Unable to load:
  /home/chromium/rpmbuild/BUILD/chromium-65.0.3284.0.fc26/build/config/gclient_args.gni
I also checked in the secondary tree for:
  /home/chromium/rpmbuild/BUILD/chromium-65.0.3284.0.fc26/build/secondary/build/config/gclient_args.gni
See //BUILD.gn:15:1: whence it was imported.
import("//components/nacl/features.gni")
^--------------------------------------


I haven't been able to build for some time now.  It always seems to be building the build tool which causes grief.

Version 63.0.3213.0 (Developer Build) 4.12.8-300.fc26.x86_64 gcc 7.1.1 2017-09-10 13:24:31 CDT Zippy Dufus (64-bit)
Status: Fixed (was: Assigned)
You seem to be having a nacl issue though, and this issue was for WebRTC. Right?

This bug appears to be closed from #7-8.

Sign in to add a comment