org.chromium.base.DiscardableReferencePoolTest#testReferenceGCd is flaky |
|||||
Issue description
,
Sep 27 2017
Disabling the test.
,
Sep 27 2017
The CL is https://chromium-review.googlesource.com/c/chromium/src/+/687015. Instead of disabling I disaded to add @RetryOnFailure.
,
Sep 27 2017
bauerb@, could you have a look (since you've added the test)?
,
Sep 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/57b6178a21fd401555a43125548250c30656456b commit 57b6178a21fd401555a43125548250c30656456b Author: vitaliii <vitaliii@chromium.org> Date: Wed Sep 27 13:24:15 2017 Retry on failure DiscardableReferencePoolTest#testReferenceGCd (flaky). org.chromium.base.DiscardableReferencePoolTest#testReferenceGCd is very lightly flaky (2 fails out of 30 builds), thus, not disabling, but retrying. TBR: bauerb@chromium.org,agrieve@chromium.org Bug: 769274 Change-Id: Ibe00fbc87796ca2571b9b9d8312ac37c248f00cb Reviewed-on: https://chromium-review.googlesource.com/687015 Reviewed-by: vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#504643} [modify] https://crrev.com/57b6178a21fd401555a43125548250c30656456b/base/android/junit/src/org/chromium/base/DiscardableReferencePoolTest.java
,
Sep 27 2017
,
Sep 27 2017
Ugh, garbage collection :-( This is probably one of those things where the method doesn't actually _guarantee_ that a GC is going to happen... Adding some random people who might know more about JVM (note that these tests are running on a Linux desktop and _not_ on the Android JVM, BTW).
,
Sep 28 2017
,
Sep 28 2017
Some commentary about this here: https://stackoverflow.com/questions/28475391/why-this-code-does-not-ensure-that-a-full-garbage-collection-has-been-done I'd guess this test is never not going to be flakey, so we should just delete it (or disable it so that it can be manually run if ever changed).
,
Sep 8
Bulk edit: Moving back into the untriaged pool, as I'm leaving the project. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by vitaliii@chromium.org
, Sep 27 2017