Issue metadata
Sign in to add a comment
|
chrome_public_test_apk failing on 2 builders |
||||||||||||||||||||
Issue descriptionchrome_public_test_apk failing on 2 builders Builders failed on: - Android Tests: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests - Android Tests (dbg): https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29 Multiple tests flaky.
,
Sep 27 2017
Failing tests summary https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/46299 org.chromium.chrome.browser.suggestions.TileGridLayoutTest#testModernTileGridAppearance_Two https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/46301org.chromium.chrome.browser.ntp.NewTabPageTest#testRender https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/46303 org.chromium.chrome.browser.ntp.NewTabPageTest#testRender org.chromium.chrome.browser.ntp.snippets.ArticleSnippetsTest#testPersonalizedSigninPromosWithAccount__ChromeHomeDisabled org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest#testTapLimitForUndecided https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/46304 org.chromium.chrome.browser.ntp.NewTabPageTest#testRender https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/46305 org.chromium.chrome.browser.ntp.NewTabPageTest#testRender org.chromium.chrome.browser.util.FeatureUtilitiesTest#testCachedSpeechFeatureAvailability https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/46306 org.chromium.chrome.browser.ntp.NewTabPageTest#testRender https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/46307 org.chromium.chrome.browser.ntp.NewTabPageTest#testRender https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/46308 org.chromium.chrome.browser.ntp.NewTabPageTest#testRender https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/46309 org.chromium.chrome.browser.ntp.NewTabPageTest#testRender https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/46310 org.chromium.chrome.browser.ntp.NewTabPageTest#testRender https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/46313 org.chromium.base.DiscardableReferencePoolTest#testReferenceGCd org.chromium.chrome.browser.ntp.NewTabPageTest#testRender https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/46314 org.chromium.chrome.browser.ntp.NewTabPageTest#testRender https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/46315 org.chromium.chrome.browser.ntp.NewTabPageTest#testRender https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/46316 org.chromium.chrome.browser.ntp.NewTabPageTest#testRender https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/46317 org.chromium.base.DiscardableReferencePoolTest#testReferenceGCd org.chromium.chrome.browser.ntp.NewTabPageTest#testRender https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/46318 org.chromium.chrome.browser.ntp.NewTabPageTest#testRender https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/46319 org.chromium.chrome.browser.ntp.NewTabPageTest#testRender https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/46320 org.chromium.chrome.browser.ntp.NewTabPageTest#testRender https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/46324 org.chromium.chrome.browser.ntp.NewTabPageTest#testRender https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/46325 org.chromium.chrome.browser.ntp.NewTabPageTest#testRender https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/46326 org.chromium.chrome.browser.ntp.NewTabPageTest#testRender org.chromium.chrome.browser.suggestions.ContentSuggestionsTest#testRemoteSuggestionsEnabled https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/46327 org.chromium.chrome.browser.ntp.NewTabPageTest#testRender https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/46328 org.chromium.chrome.browser.ntp.NewTabPageTest#testRender https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/46329 org.chromium.chrome.browser.ntp.NewTabPageTest#testRender https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/46330 org.chromium.chrome.browser.ntp.NewTabPageTest#testRender https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/46331 org.chromium.chrome.browser.ntp.NewTabPageTest#testRender https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/46332 org.chromium.chrome.browser.ntp.NewTabPageTest#testRender org.chromium.chrome.browser.sync.AutofillTest#testDownloadAutofillModification https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/46333 org.chromium.chrome.browser.ntp.NewTabPageTest#testRender
,
Sep 27 2017
org.chromium.chrome.browser.ntp.NewTabPageTest#testRender is being handled by the owner in https://chromium-review.googlesource.com/c/chromium/src/+/686760 (issue 762932).
,
Sep 27 2017
I filled issue 769274 for org.chromium.base.DiscardableReferencePoolTest#testReferenceGCd.
,
Sep 27 2017
Let's have a look at Android Tests Dbg now. (I exclude org.chromium.chrome.browser.ntp.NewTabPageTest#testRender) https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/45884 org.chromium.chrome.browser.FullscreenActivityTest#testNoIntentWhenInBackground https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/45889 org.chromium.chrome.browser.searchwidget.SearchActivityTest#testRealPromoDialogInterruption https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/45891 org.chromium.chrome.browser.ntp.snippets.ArticleSnippetsTest#testSnippetAppearance__ChromeHomeDisabled org.chromium.chrome.browser.ntp.snippets.ArticleSnippetsTest#testPersonalizedSigninPromosWithAccount__ChromeHomeEnabled https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/45894 org.chromium.chrome.browser.IntentHandlerTest#testGeneratedReferrer https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/45895 org.chromium.chrome.browser.suggestions.TileGridLayoutTest#testTileGridAppearance_Full https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/45896 org.chromium.chrome.browser.gsa.GSAAccountChangeListenerTest#testReceivesBroadcastIntents https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/45897 org.chromium.chrome.browser.contextmenu.TabularContextMenuUiTest#testHeaderIsNotShownWhenThereIsNoParams https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/45898 org.chromium.chrome.browser.suggestions.TileGridLayoutTest#testModernTileGridAppearance_Full
,
Sep 27 2017
Everything fails once :( Let's have a look at earlier builds. https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/45872 org.chromium.chrome.browser.suggestions.TileGridLayoutTest#testTileGridAppearance_Two https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/45868 org.chromium.chrome.browser.payments.PaymentRequestJourneyLoggerTest#testUserDidNotHaveCompleteSuggestions_ShippingAndPayment_IncompleteCard https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/45860 org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest#testChainedSearchCreatesNewContent org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest#testTapLimitForUndecided org.chromium.chrome.browser.ntp.snippets.ArticleSnippetsTest#testGenericSigninPromo__ChromeHomeEnabled https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/45859 org.chromium.content.browser.input.ImeTest#testSetComposingTextForNewCursorPositions https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/45858 org.chromium.chrome.browser.suggestions.TileGridLayoutTest#testTileGridAppearance_Two https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/45853 org.chromium.chrome.browser.suggestions.TileGridLayoutTest#testTileGridAppearance_Two https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/45846 org.chromium.chrome.browser.browseractions.BrowserActionActivityTest#testOpenTabInBackgroundWithInitialization https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/45834 org.chromium.chrome.browser.suggestions.TileGridLayoutTest#testTileGridAppearance_Full https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/45826 org.chromium.chrome.browser.crash.MinidumpUploadServiceTest#testTryUploadAllCrashDumps
,
Sep 27 2017
There is a bug for TileGridLayoutTest already, it is issue 768779.
,
Sep 27 2017
Assigning to the next sheriff in case there are more flakes. The fix for org.chromium.chrome.browser.ntp.NewTabPageTest#testRender has landed. @RetryOnFailure for TileGridLayoutTest has landed as well. Feel free to close.
,
Sep 27 2017
vitaliii@: thanks, I will wait for another 1-2 cycles to make sure that it is green.
,
Sep 27 2017
STill not green.
,
Sep 27 2017
Not sure what to do to fix.... exploring now.
,
Sep 27 2017
,
Sep 28 2017
Assigning back to the owner
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56e512088c2d555de9e8172d8540629b3ff74632 commit 56e512088c2d555de9e8172d8540629b3ff74632 Author: Xida Chen <xidachen@chromium.org> Date: Thu Sep 28 01:51:47 2017 Disable org.chromium.chrome.browser.ntp.NewTabPageTest#testRender This test has been flaky for many cycles: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29 Disabling it for now is probably the best option. This CL disables it according to the instruction here: https://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/handling-a-failing-test TBR=dgn@chromium.org NOTRY=true Bug: 769265 Change-Id: Ieeeeb6e3bd56b5878ce4cc7e687c9f69abc08bdd Reviewed-on: https://chromium-review.googlesource.com/688582 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#504863} [modify] https://crrev.com/56e512088c2d555de9e8172d8540629b3ff74632/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b12dca10a0ba9ea37254c72b270d0b99104f6b7e commit b12dca10a0ba9ea37254c72b270d0b99104f6b7e Author: Nicolas Dossou-gbete <dgn@chromium.org> Date: Thu Sep 28 11:37:16 2017 Reland "📰 Use standard styles for classic action items" This reverts 2 CLs, https://crrev.com/c/688582 and https://crrev.com/c/688160. The fix for the failure was landed in https://crrev.com/c/688076 Original change's description: > 📰 Use standard styles for classic action items > > Updates the SuggestionCardActionModern style to be more generic and > be usable for classic cards, use it for the classic generic signin > promo and the action item. > > Preview: https://photos.app.goo.gl/GC9l01D8QI7YSLtI2 > Bug: None > Change-Id: If1a007ad4288cc88511845b3ac89a9c8f2f1cbab > Reviewed-on: https://chromium-review.googlesource.com/674691 > Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> > Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#504678} > Bug: 769403 , 769265 Change-Id: I8c1883181a506e6392e74439984620f0705acd37 Reviewed-on: https://chromium-review.googlesource.com/689515 Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/master@{#504971} [modify] https://crrev.com/b12dca10a0ba9ea37254c72b270d0b99104f6b7e/chrome/android/java/res/layout/content_suggestions_action_card_modern.xml [modify] https://crrev.com/b12dca10a0ba9ea37254c72b270d0b99104f6b7e/chrome/android/java/res/layout/content_suggestions_status_card_modern.xml [modify] https://crrev.com/b12dca10a0ba9ea37254c72b270d0b99104f6b7e/chrome/android/java/res/layout/new_tab_page_action_card.xml [modify] https://crrev.com/b12dca10a0ba9ea37254c72b270d0b99104f6b7e/chrome/android/java/res/layout/new_tab_page_status_card.xml [modify] https://crrev.com/b12dca10a0ba9ea37254c72b270d0b99104f6b7e/chrome/android/java/res/values-v17/styles.xml [modify] https://crrev.com/b12dca10a0ba9ea37254c72b270d0b99104f6b7e/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java [modify] https://crrev.com/b12dca10a0ba9ea37254c72b270d0b99104f6b7e/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-signin_promo.Nexus_5-19.png [modify] https://crrev.com/b12dca10a0ba9ea37254c72b270d0b99104f6b7e/chrome/test/data/android/render_tests/ArticleSnippetsTest.signin_promo.Nexus_5-19.png
,
Sep 28 2017
,
Sep 28 2017
,
Sep 28 2017
already having bugs for the test owner. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by vitaliii@chromium.org
, Sep 27 2017