New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 769258 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Fix and promote Android Archive bot

Project Member Reported by kjellander@chromium.org, Sep 27 2017

Issue description

The bot in https://build.chromium.org/p/client.webrtc.fyi/builders/Android%20Archive/
was running green for a long time, until it broke in
https://build.chromium.org/p/client.webrtc.fyi/builders/Android%20Archive/builds/2531

This wasn't noticed since it lives in client.webrtc.fyi.

This bugs tracks fixing it (should be simple) and promoting it to the main waterfall.
 
What does this bot do?
Builds the Android AAR archive (for use as an SDK library in Android Studio etc)
Instead of adding a new bot for this I think we should just add this to the Android Release bot (and android_rel) trybot. Since those tests are executed in Swarming, the building machine is usually sitting idle waiting for the swarming jobs to execute (except running the android_junit_tests, which is very quick). Then we could just run the archive script. Preferably without using a temp folder (which is the current default) so we'd benefit from incremental builds.

That will be fast except in the cases where all Android tests are returning from cached results (i.e. a binary with the same sha1 hash had already run), but I think that's pretty uncommon.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 27 2017

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/03ec4f818807808d6e983fe80b1adb0af27b6ea4

commit 03ec4f818807808d6e983fe80b1adb0af27b6ea4
Author: Henrik Kjellander <kjellander@webrtc.org>
Date: Wed Sep 27 14:40:16 2017

Update build_aar.py after webrtc/ dir was removed.

BUG= chromium:769258 
NOTRY=True

Change-Id: Ibdc36b3a962a980460147f907353461d29da628c
Reviewed-on: https://webrtc-review.googlesource.com/4142
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Commit-Queue: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20001}
[modify] https://crrev.com/03ec4f818807808d6e983fe80b1adb0af27b6ea4/tools_webrtc/android/build_aar.py

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/58a0923e5ee98bbe674b785012b51a21edcfb2dc

commit 58a0923e5ee98bbe674b785012b51a21edcfb2dc
Author: Henrik Kjellander <kjellander@chromium.org>
Date: Fri Sep 29 18:04:19 2017

WebRTC: Retire Android Archive bot and add step to one Android commit+trybot.

The running of https://webrtc.googlesource.com/src/+/master/tools_webrtc/android/build_aar.py
is now added as a new step on:
* Android32 (M Nexus5X) in client.webrtc
* android_rel in tryserver.webrtc

The only change from where it ran before is that for the trybot, --build-dir is passed
so it can benefit from incremental builds (for speed). The regular commit bot always
does a clean build in a temp dir to ensure no undesired old objects are packaged.

BUG= 769258 

Change-Id: I2a420cf2ca81858456889981eb055dc08080f88b
Reviewed-on: https://chromium-review.googlesource.com/689517
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

[delete] https://crrev.com/58b941cfa60ccf3d39be63230a3f991abed00c9c/scripts/slave/recipes/webrtc/android_archive.expected/trybot_build.json
[modify] https://crrev.com/58a0923e5ee98bbe674b785012b51a21edcfb2dc/scripts/slave/recipe_modules/webrtc/builders.py
[modify] https://crrev.com/58a0923e5ee98bbe674b785012b51a21edcfb2dc/masters/master.client.webrtc.fyi/master_android_cfg.py
[delete] https://crrev.com/58b941cfa60ccf3d39be63230a3f991abed00c9c/scripts/slave/recipes/webrtc/android_archive.py
[modify] https://crrev.com/58a0923e5ee98bbe674b785012b51a21edcfb2dc/masters/master.client.webrtc.fyi/slaves.cfg
[modify] https://crrev.com/58a0923e5ee98bbe674b785012b51a21edcfb2dc/scripts/slave/README.recipes.md
[modify] https://crrev.com/58a0923e5ee98bbe674b785012b51a21edcfb2dc/scripts/slave/recipes/webrtc/standalone.py
[add] https://crrev.com/58a0923e5ee98bbe674b785012b51a21edcfb2dc/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32__m_nexus5x__failing_archive.json
[modify] https://crrev.com/58a0923e5ee98bbe674b785012b51a21edcfb2dc/scripts/slave/recipe_modules/webrtc/__init__.py
[modify] https://crrev.com/58a0923e5ee98bbe674b785012b51a21edcfb2dc/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32__m_nexus5x_.json
[modify] https://crrev.com/58a0923e5ee98bbe674b785012b51a21edcfb2dc/scripts/slave/recipe_modules/webrtc/api.py
[delete] https://crrev.com/58b941cfa60ccf3d39be63230a3f991abed00c9c/scripts/slave/recipes/webrtc/android_archive.expected/build_ok.json
[delete] https://crrev.com/58b941cfa60ccf3d39be63230a3f991abed00c9c/scripts/slave/recipes/webrtc/android_archive.expected/build_failure.json
[modify] https://crrev.com/58a0923e5ee98bbe674b785012b51a21edcfb2dc/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_rel.json

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/e31209531942766c4cadd32e754642290ad9b112

commit e31209531942766c4cadd32e754642290ad9b112
Author: Henrik Kjellander <kjellander@chromium.org>
Date: Mon Oct 02 11:33:08 2017

WebRTC: Move .aar and AppRTC build+upload to after triggering of tests

As of https://chromium-review.googlesource.com/c/chromium/tools/build/+/689517/8
the build and upload of the Android .aar file takes place before
the swarming tests are triggered. This is wasting a lot of time
blocking the bot. These steps should take place after the
swarming tests have been triggered, for shorter build cycles.

This change also moves the AppRTCMobile upload to take place after
the test tasks are triggered.

BUG= 769258 

Change-Id: I9551b1f9c90f87811b496f8ea2ced363a9c3dff3
Reviewed-on: https://chromium-review.googlesource.com/693096
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>

[modify] https://crrev.com/e31209531942766c4cadd32e754642290ad9b112/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64__m_nexus5x_.json
[modify] https://crrev.com/e31209531942766c4cadd32e754642290ad9b112/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32__m_nexus5x__dbg_.json
[modify] https://crrev.com/e31209531942766c4cadd32e754642290ad9b112/scripts/slave/README.recipes.md
[modify] https://crrev.com/e31209531942766c4cadd32e754642290ad9b112/scripts/slave/recipes/webrtc/standalone.py
[modify] https://crrev.com/e31209531942766c4cadd32e754642290ad9b112/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32__m_nexus5x__failing_archive.json
[modify] https://crrev.com/e31209531942766c4cadd32e754642290ad9b112/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32__m_nexus5x_.json
[modify] https://crrev.com/e31209531942766c4cadd32e754642290ad9b112/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64__m_nexus5x__dbg_.json
[modify] https://crrev.com/e31209531942766c4cadd32e754642290ad9b112/scripts/slave/recipe_modules/webrtc/api.py
[modify] https://crrev.com/e31209531942766c4cadd32e754642290ad9b112/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_rel.json

Status: Fixed (was: Assigned)

Sign in to add a comment