New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 769255 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unable to play the dino game when chrome://dino page is zoomed to 25%

Project Member Reported by rkalavakuntla@chromium.org, Sep 27 2017

Issue description

Chrome Version:62.0.3202.38 Beta
OS:Ubuntu 14.04,Windows 7

What steps will reproduce the problem?
(1)Launch chrome,navigate to chrome://dino page >> zoom the page to 25% and Observe(kindly refer video)

Actual:Unable to view or play the game 
Expected:Should be able to view and play the game

This is a Regression issue broken in M-61

Manual Bisect Info:
-------------------
Good Build:61.0.3154.0 dev
Bad Build :61.0.3155.0 dev

Using per-revision bisect providing the bisect results:

You are probably looking for a change made after 485575 (known good), but no later than 485576 (first known bad).
CHANGELOG URL:
 https://chromium.googlesource.com/chromium/src/+log/8909a54471f168be1300c13aaecd2a2985e960ad..5d7f712b4d54e0127f78f8529046db80b2c1a975

Suspecting: https://chromium.googlesource.com/chromium/src/+/5d7f712b4d54e0127f78f8529046db80b2c1a975
Review-Url: https://codereview.chromium.org/2955153002

edwardjung@:Could you please take a look into this issue and reassign if this issue is not related to your change.

Thanks..!!





 
Actual.webm
769 KB View Download
Expected.webm
1.6 MB View Download
Labels: hasbisect-per-revision
This arcade feature was introduced specifically for users accessing chrome://dino just to play the game. Those wanting a smaller screen experience, can resize the window as the game scales to the window. It doesn't affect the normal offline interstitial at chrome://network-error/-106 in any way. 

However I can see the game isn't correctly positioned so I'll adjust the top margin taking into account the scaling.

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8f4729f10179523ae8b1979803bed234ab8d284

commit b8f4729f10179523ae8b1979803bed234ab8d284
Author: Edward Jung <edwardjung@chromium.org>
Date: Tue Oct 10 16:05:39 2017

chrome://dino Fix top position calculation when the user has scaled the page

Bug:  769255 
Change-Id: Ia9106e8155f969b18b574145e9d52c0cc0f9e1cc
Reviewed-on: https://chromium-review.googlesource.com/705294
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Edward Jung <edwardjung@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507681}
[modify] https://crrev.com/b8f4729f10179523ae8b1979803bed234ab8d284/components/neterror/resources/offline.js

Status: Fixed (was: Assigned)

Comment 5 by dchau...@etouch.net, Oct 12 2017

Labels: TE-Verified-63.0.3238.0 TE-Verified-M63
Update : 
Retested This issue on Windows(7,8,10),Mac(10.12.6) and Linux (14.04 LTS) OS using latest Chrome Canary build #63.0.3238.0 and issue seems to be fixed i.e. able to play the dino game after zooming out the page to 25%

Kindly review an attached screen cast.

Thank you!
Latest Canary behavior.mp4
614 KB View Download

Sign in to add a comment