New issue
Advanced search Search tips

Issue 769249 link

Starred by 1 user
Status: Fixed
Owner:
beccahughes@chromium.org
Closed: Sep 2017
Cc:
mlamouri@chromium.org
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 746872



Sign in to add a comment

UA CSS resources are incorrectly flagged as a resource leak

Project Member Reported by beccahughes@chromium.org, Sep 27 2017 
User Agent stylesheets will load image resources and hold onto them beyond a page navigation because the parsed stylesheets are retained in memory. This means that the leak detection in Blink will incorrectly identify flag them as a resource leak and the tests will break.

This is blocking the new media controls work from landing as they use images in UA CSS.

The proposed fix is to count the number of resources originating from UA CSS that should be long lived, and subtract them from the total.

Marking them as a "LeakExpectation" is also not suitable as it may hide actual leaks.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df35ca0c4c57ce22fb03310bcfb2125d983e6ee9

commit df35ca0c4c57ce22fb03310bcfb2125d983e6ee9
Author: Becca Hughes <beccahughes@chromium.org>
Date: Wed Sep 27 16:34:58 2017

Media Controls: UA CSS resources are flagged as a leak.

User-Agent CSS resources are incorrectly flagged as a leak because
they persist beyond a page navigation. This CL will count the
number of live resources originating from UA CSS and exclude them
from the test.

BUG= 769249 

Change-Id: I5b7233d0740b9411bc836b301fdc96459ef2cb7f
Reviewed-on: https://chromium-review.googlesource.com/686714
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504701}
[modify] https://crrev.com/df35ca0c4c57ce22fb03310bcfb2125d983e6ee9/content/shell/renderer/layout_test/leak_detector.cc
[modify] https://crrev.com/df35ca0c4c57ce22fb03310bcfb2125d983e6ee9/third_party/WebKit/LayoutTests/inspector-protocol/performance/perf-metrics-expected.txt
[modify] https://crrev.com/df35ca0c4c57ce22fb03310bcfb2125d983e6ee9/third_party/WebKit/LayoutTests/inspector-protocol/performance/perf-push-metrics-expected.txt
[modify] https://crrev.com/df35ca0c4c57ce22fb03310bcfb2125d983e6ee9/third_party/WebKit/Source/core/css/CSSImageSetValue.cpp
[modify] https://crrev.com/df35ca0c4c57ce22fb03310bcfb2125d983e6ee9/third_party/WebKit/Source/core/css/CSSImageSetValue.h
[modify] https://crrev.com/df35ca0c4c57ce22fb03310bcfb2125d983e6ee9/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
[modify] https://crrev.com/df35ca0c4c57ce22fb03310bcfb2125d983e6ee9/third_party/WebKit/Source/core/leak_detector/WebLeakDetector.cpp
[modify] https://crrev.com/df35ca0c4c57ce22fb03310bcfb2125d983e6ee9/third_party/WebKit/Source/core/style/StyleImage.cpp
[modify] https://crrev.com/df35ca0c4c57ce22fb03310bcfb2125d983e6ee9/third_party/WebKit/Source/core/style/StyleImage.h
[modify] https://crrev.com/df35ca0c4c57ce22fb03310bcfb2125d983e6ee9/third_party/WebKit/Source/platform/InstanceCounters.h
[modify] https://crrev.com/df35ca0c4c57ce22fb03310bcfb2125d983e6ee9/third_party/WebKit/public/web/WebLeakDetector.h

Comment 2 by beccahughes@chromium.org, Sep 28 2017

Cc: mlamouri@chromium.org
Status: Fixed (was: Started)
►

Sign in to add a comment