Issue metadata
Sign in to add a comment
|
Regression : Tab Focus is seen missing on 'Sign out' immediately after focus is on 'Date' option in Uber Tray |
||||||||||||||||||||||
Issue descriptionChrome Version: 61.0.3163.108/9765.72.0 Beta-channel Daisy,Candy and Peppy OS: Chrome What steps will reproduce the problem? (1)Sign into User -> Now click on Uber Tray -> Press 'Tab' button until focus is on 'Date' option (2)Now again press 'Tab' button and observe Focus is not seen anywhere and now again press 'Tab' button -> Observe focus is on 'Sign out' option(Please refer Video) Expected: After Focus is on 'Date' option and on pressing 'Tab' Focus should be seen on 'Sign out' option Actual: Instead After 'Date' option Focus is seen missing on 'Sign out' option and on again pressing 'Tab' focus is seen This is Regression issue as same is working fine in M-55 @tbuckley : Please confirm the Issue Note: 1.Issue is also seen on latest M-63 Build 2.issue is seen on M-56 also
,
Nov 2 2017
,
Nov 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f38c9a754438b6111c91d87a910c288f472a49d4 commit f38c9a754438b6111c91d87a910c288f472a49d4 Author: Sammie Quon <sammiequon@google.com> Date: Thu Nov 02 18:35:37 2017 tray: Fix focus rectangle for tray_info_label. See bug 771102 for screenshots. The label covers some of the of the focus rectangle. Changed to use box layout so the label does not take up more space than it needs. Fix two other small bugs. 1) Strings for updating flash cutoff in German. Add label multiline for that label. 2) Tab focus going on power, even though it is not a button. Users using tab require to tabs to go from the last highlighted region (time) to the next (sign out). Test: manual Bug: 771102 , 742283 , 769240 Change-Id: I9bc25be80166afcdff2664a457c1f775a8065456 Reviewed-on: https://chromium-review.googlesource.com/750066 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#513560} [modify] https://crrev.com/f38c9a754438b6111c91d87a910c288f472a49d4/ash/system/power/power_status_view.cc [modify] https://crrev.com/f38c9a754438b6111c91d87a910c288f472a49d4/ash/system/tray/tray_info_label.cc [modify] https://crrev.com/f38c9a754438b6111c91d87a910c288f472a49d4/ash/system/update/tray_update.cc
,
Nov 2 2017
,
Nov 13 2017
This issue still seems to be existing. I can see that the tab focus doesn't shift immediately to sign out from the last highlighted region (i.e. date). It requires 2 tabs to go to Sign out button (as in M64) and 3tabs to go from date region to Sign out button as in M63. Also there is a focus miss while navigating from mute icon to settings icon in M64. I think even this needs to be fixed as the tab focus must immediately shift from mute icon to settings icon on uber tray.
,
Nov 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac9b2b4eade6c978204662cf6c0e08b5129fabb8 commit ac9b2b4eade6c978204662cf6c0e08b5129fabb8 Author: Sammie Quon <sammiequon@google.com> Date: Mon Nov 13 22:13:18 2017 [merge to m63] tray: Fix focus rectangle for tray_info_label. See bug 771102 for screenshots. The label covers some of the of the focus rectangle. Changed to use box layout so the label does not take up more space than it needs. Fix two other small bugs. 1) Strings for updating flash cutoff in German. Add label multiline for that label. 2) Tab focus going on power, even though it is not a button. Users using tab require to tabs to go from the last highlighted region (time) to the next (sign out). TBR=sammiequon@google.com (cherry picked from commit f38c9a754438b6111c91d87a910c288f472a49d4) TBR: stevenjb@chromium.org Test: manual Bug: 771102 , 742283 , 769240 Change-Id: I9bc25be80166afcdff2664a457c1f775a8065456 Reviewed-on: https://chromium-review.googlesource.com/750066 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#513560} Reviewed-on: https://chromium-review.googlesource.com/767113 Reviewed-by: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#472} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/ac9b2b4eade6c978204662cf6c0e08b5129fabb8/ash/system/power/power_status_view.cc [modify] https://crrev.com/ac9b2b4eade6c978204662cf6c0e08b5129fabb8/ash/system/tray/tray_info_label.cc [modify] https://crrev.com/ac9b2b4eade6c978204662cf6c0e08b5129fabb8/ash/system/update/tray_update.cc
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d8563a3c3e82d734a1c6f2da922a6a47e8fdecd5 commit d8563a3c3e82d734a1c6f2da922a6a47e8fdecd5 Author: Sammie Quon <sammiequon@google.com> Date: Tue Nov 14 22:37:01 2017 tray: Do not hide the focus rectangle on the user card when it is focused. When cycling through system tray with tab, there is now a focus rectangle on the user card when it is clickable (multi user can be used to test this). Test: manual Bug: 769240 Change-Id: Iaeb486a9cfc1ba89a74ba6fb25b533291261a468 Reviewed-on: https://chromium-review.googlesource.com/769162 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#516471} [modify] https://crrev.com/d8563a3c3e82d734a1c6f2da922a6a47e8fdecd5/ash/system/user/user_card_view.cc
,
Nov 15 2017
now should work if user card is a button (multiple users) |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by tbuck...@chromium.org
, Oct 11 2017Owner: zork@chromium.org