New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 769234 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : Unnecessarily two pointers are seen in color picker window while dragging in devtools.

Reported by rp...@etouch.net, Sep 27 2017

Issue description

Version: 62.0.3202.38 07acaf2e3d9da74d8348a65e7a2e5adf7ee4c662-refs/branch-heads/3202@{#463}
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6)

What steps will reproduce the problem?
1. Launch chrome, navigate to NTP and open devtools.
2. Now click on 'Add background color' in styles to open color picker window and drag mouse pointer over color,observe 

Actual: Unnecessarily two pointer(Hand pointer and arrow pointer) are seen at the same time while dragging
Expected: Unnecessarily two pointer(Hand pointer and arrow pointer) shouldn't be seen at the same time while dragging

This is regression issue, broken in ‘M 62’ and will soon update other info :
Good build:62.0.3167.0
Bad build: 62.0.3168.0
 
Actual_video.mp4
1.0 MB View Download
Expected_video.mp4
714 KB View Download

Comment 1 by rp...@etouch.net, Sep 27 2017

Labels: hasbisect-per-revision
Owner: aboxhall@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 62.0.3167.0 (Revision: 489500).
Bad build: 62.0.3168.0 (Revision: 489803).

You are probably looking for a change made after 489730 (known good), but no lat
er than 489731 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/01e3c1935289cf4b6bfcc3bf42bd8e1e498b445f..2f925c9a0144adf5823e14217e74854df82a51e4

From the CL above, assigning the issue to the concern owner 

@aboxhall- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Suspect : https://chromium.googlesource.com/chromium/src/+/2f925c9a0144adf5823e14217e74854df82a51e4

Thanks!
Labels: ReleaseBlock-Stable
Adding RB Label as this is a recent Regression. Please remove if not required.
Thank You.
aboxhall@ Able to reproduce this issue on chrome latest dev #63.0.3231.0. This issue is marked as RB-Stable, could you please let us know is there any latest update available on this issue?

Thanks!
Labels: -ReleaseBlock-Stable
This shouldn't be a 'RB-Stable'.
Owner: pfeldman@chromium.org
The '.spectrum-dragger' (circle) element has a 'cursor: pointer' style, while the spectrum itself has a 'cursor: default' style. As you drag the dragger, the mouse pointer may get ahead of the dragger, causing the default cursor to show up.

My change may well have made this more noticeable by slowing down the position update in some cases.

However, I'm not sure of the best fix here, so I'm reassigning to pfeldman@ for advice. Please feel free to reassign it to me if there's a fix I can do.
Owner: l...@chromium.org
We should set the spectrum's cursor to pointer while dragging...
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cdd1c27807529108d2d45243fcd9d3378e857661

commit cdd1c27807529108d2d45243fcd9d3378e857661
Author: Erik Luo <luoe@chromium.org>
Date: Tue Dec 12 02:04:56 2017

DevTools: use cursor pointer while dragging color picker spectrum

The spectrum dragger circle already has cursor: pointer style, but the
user can see flickering between two cursors because the container still
has default pointer.

This CL ensures that the container has cursor: pointer while dragging,
and default pointer when hovering without dragging.

Bug:  769234 
Change-Id: I68fb7cbe5fdc0360311fb59d11c434d3aec013ec
Reviewed-on: https://chromium-review.googlesource.com/818283
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523300}
[modify] https://crrev.com/cdd1c27807529108d2d45243fcd9d3378e857661/third_party/WebKit/Source/devtools/front_end/color_picker/Spectrum.js

Comment 8 by l...@chromium.org, Dec 12 2017

Labels: -Pri-1 Pri-2
Status: Fixed (was: Assigned)

Comment 9 by rp...@etouch.net, Dec 13 2017

Update :
Rechecked the above issue with latest canary chrome version : 65.0.3293.0 on Windows (7,8,8.1,10),Mac OS X(10.12.6) OS and the issue is not reproduced.Kindly refer attached screen cast for reference.
Actual_video.mov
2.6 MB Download

Comment 10 by rp...@etouch.net, Dec 13 2017

NOTE: Linux build is not yet available, so not added TE-Verified labels.

Comment 11 by rp...@etouch.net, Dec 14 2017

Labels: TE-Verified-M65 TE-Verified-65.0.3294.0
Update :
Rechecked the above issue with latest canary chrome version : 65.0.3294.0 on Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1) OS and the issue is not reproduced.Kindly refer attached screen cast for reference.

Sign in to add a comment