Issue metadata
Sign in to add a comment
|
Regression: Different context menu is seen for setting menu button on right click.
Reported by
aiman.an...@etouch.net,
Sep 27 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version: 62.0.3202.38 (Official Build)07acaf2e3d9da74d8348a65e7a2e5adf7ee4c662-refs/branch-heads/3202@{#463} (64-bit) OS: Mac(10.12.6, 10.13). Steps to reproduce: 1.Launch Chrome, go to chrome://settings, press tab until focus reaches Setting Menu Button. 2.right Click with mouse and observe Context Menu. Actual Result: Different context menu is seen. Expected Result: Different context menu should not be seen. This is regression issue broken in ‘M-62’ and below per-revision bisect result Using the per-revision bisect providing the bisect results, Good Build: 62.0.3173.0(Revision:490803). Bad Build: 62.0.3174.0(Revision:491203). You are probably looking for a change made after 491191 (known good), but no later than 491192 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/594f4118d05c0d3289503a8bdf00fad04354e00f..2672be183a7c6760f0163892b7633db9880c8c65 Suspect: https://chromium.googlesource.com/chromium/src/+/2672be183a7c6760f0163892b7633db9880c8c65 @dschuyler: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thank You!
,
Sep 27 2017
,
Sep 27 2017
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/602197592af6c99b68390ef5d3bd77e8d1285c6f commit 602197592af6c99b68390ef5d3bd77e8d1285c6f Author: Dave Schuyler <dschuyler@chromium.org> Date: Thu Sep 28 01:01:15 2017 [cr webui] no selection of icon buttons This CL sets user-select: none; on icon buttons. There doesn't appear to be a need/reason to do selection of a icon button (when drag selecting for example). This change is primarily to make the context menu (right- click menu) show options for a button rather than selected text. Bug: 769209 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I64013d3f087ff6cd3c33b513acc2c2d340406202 Reviewed-on: https://chromium-review.googlesource.com/688499 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#504846} [modify] https://crrev.com/602197592af6c99b68390ef5d3bd77e8d1285c6f/ui/webui/resources/cr_elements/cr_icons_css.html
,
Sep 28 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by manoranj...@chromium.org
, Sep 27 2017