New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 769207 link

Starred by 1 user
Status: Fixed
Owner:
gambard@chromium.org
Closed: Sep 2017
Cc:
ios-bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Recent Tabs app bar does not respect the safe area.

Project Member Reported by gambard@chromium.org, Sep 27 2017 
iPhone X only.

What steps will reproduce the problem?
(1) Open recent tabs in landscape

What is the expected result?
The app bar title and done button should be inside the safe area.

What happens instead?
They are displayed outside  the safe area.
Simulator Screen Shot - iPhone X - 2017-09-27 at 10.17.45.png
127 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0f35629dbc4d02666df30a22cee5d218e2f7a84

commit e0f35629dbc4d02666df30a22cee5d218e2f7a84
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed Sep 27 08:51:51 2017

Let Recent Tabs app bar respect the safe area

The Recent Tabs app bar needs to take into account the safe area in
landscape. The control and the title need to be displayed inside.

Before: https://drive.google.com/open?id=0B21N-0pPGAuJal9xbkJ6Y0s1amc
After: https://drive.google.com/open?id=0B21N-0pPGAuJY1JmWU1zZ0FKQkU

Bug:  769207 
Change-Id: Iff14f51b417905ee490b3d62250a0433b10367c5
Reviewed-on: https://chromium-review.googlesource.com/685661
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504602}
[modify] https://crrev.com/e0f35629dbc4d02666df30a22cee5d218e2f7a84/ios/chrome/browser/ui/ntp/recent_tabs/views/panel_bar_view.mm

Comment 2 by gambard@chromium.org, Sep 27 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment