New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 769158 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocked on:
issue 718694
issue 769160



Sign in to add a comment

Provide regional language based on coarse device location

Project Member Reported by amoylan@chromium.org, Sep 27 2017

Issue description

As part of improving the client-side model of user's language preferences (both for offering Translate actions, and as part of the more general Chrome language model), we want to use the approximate device location (regional/country level) to map to local languages.

Detailed design doc to follow.
 
Blockedon: 769160
Blockedon: 718694
Cc: napper@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0663bc78138a9525211a0d0d2bc509502a2607f

commit b0663bc78138a9525211a0d0d2bc509502a2607f
Author: Renjie Liu <renjieliu@chromium.org>
Date: Wed Oct 18 00:51:34 2017

Add partial traffic annotation to network_location_request

This is for
https://docs.google.com/document/d/1oSQM3GEMTL1raWLYv8S6_Yyt93FF2zQbANI4bKJ6LDs/edit?pli=1#heading=h.2st2zzoz32x8
and that we plan to reuse NetworkLocationRequest from there,
and a different "setting" and/or "chrome_policy" field will be
appropriate depending on the caller.

Bug:  718694 , 769158 
Change-Id: Ie966a1ec6139f1d613ba2e0c5f83d02b9dc42ace
Reviewed-on: https://chromium-review.googlesource.com/717596
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Renjie Liu <renjieliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509632}
[modify] https://crrev.com/b0663bc78138a9525211a0d0d2bc509502a2607f/device/geolocation/network_location_provider.cc
[modify] https://crrev.com/b0663bc78138a9525211a0d0d2bc509502a2607f/device/geolocation/network_location_request.cc
[modify] https://crrev.com/b0663bc78138a9525211a0d0d2bc509502a2607f/device/geolocation/network_location_request.h

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b81abebc56a42328483292d9b8342253f244f2ee

commit b81abebc56a42328483292d9b8342253f244f2ee
Author: Renjie Liu <renjieliu@chromium.org>
Date: Sat Nov 18 01:19:28 2017

PublicIpAddressLocationNotifier implementation

Original owner: amoylan@chromium.org
Original cl: https://chromium-review.googlesource.com/c/chromium/src/+/754254

This CL is part of the implementation of public-IP-only geolocation
as described in the design doc:
https://docs.google.com/document/d/1oSQM3GEMTL1raWLYv8S6_Yyt93FF2zQbANI4bKJ6LDs

This part is the implementation of the centralized
PublicIpAddressLocationNotifier that issues IP-geolocation requests
to handle any/all clients.

This reuses the NetworkLocationRequest class from the existing
Geolocation service (which provides web-platform geolocation)
in //device/geolocation.

This CL creates //services/device/geolocation/ and includes a "+net"
DEPS entry. (This "+net" dependency, among others, will eventually be
needed when all of //device/geolocation eventually moves into
//services/device/geolocation as part of Geolocation Servicification.)

Tests: Unit tests for PublicIpAddressGeolocationNotifier covering the
logic to do with responding to different sequences of "network change
detected" and "client wants a new/next position".

Add PartialNetworkTrafficAnnotation as well.

Bug:  718694 ,  769158 

Bug: 
Change-Id: I792a1793a54b283949b97f411b70a71ea27ec6c8
Reviewed-on: https://chromium-review.googlesource.com/757821
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Renjie Liu <renjieliu@chromium.org>
Commit-Queue: Renjie Liu <renjieliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517661}
[modify] https://crrev.com/b81abebc56a42328483292d9b8342253f244f2ee/device/geolocation/BUILD.gn
[modify] https://crrev.com/b81abebc56a42328483292d9b8342253f244f2ee/device/geolocation/network_location_request.h
[modify] https://crrev.com/b81abebc56a42328483292d9b8342253f244f2ee/services/device/BUILD.gn
[add] https://crrev.com/b81abebc56a42328483292d9b8342253f244f2ee/services/device/geolocation/BUILD.gn
[add] https://crrev.com/b81abebc56a42328483292d9b8342253f244f2ee/services/device/geolocation/DEPS
[add] https://crrev.com/b81abebc56a42328483292d9b8342253f244f2ee/services/device/geolocation/public_ip_address_location_notifier.cc
[add] https://crrev.com/b81abebc56a42328483292d9b8342253f244f2ee/services/device/geolocation/public_ip_address_location_notifier.h
[add] https://crrev.com/b81abebc56a42328483292d9b8342253f244f2ee/services/device/geolocation/public_ip_address_location_notifier_unittest.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b08f01ba16baffa0783efd5696a2c652facde0b9

commit b08f01ba16baffa0783efd5696a2c652facde0b9
Author: Renjie Liu <renjieliu@chromium.org>
Date: Wed Nov 22 22:57:02 2017

PublicIpAddressGeolocator implementation

original owner: amoylan@chromium.org
original cl: https://chromium-review.googlesource.com/c/chromium/src/+/754153

This CL is part of the implementation of public-IP-only geolocation
as described in the design doc:
https://docs.google.com/document/d/1oSQM3GEMTL1raWLYv8S6_Yyt93FF2zQbANI4bKJ6LDs

This part is an implementation of the mojom::Geolocation interface
that is separate from the existing web-platform implementation of
that interface (which lives in //device/geolocation currently).

This implementation uses the PublicIpAddressLocationNotifier
(upstream dependent CL) to provide IP-only geolocation.

Tested: Basic unit tests added.

Bug:  718694 ,  769158 
Change-Id: I716b52d8ea21cb8ad4f94b128fddc0c0cef967a3
Reviewed-on: https://chromium-review.googlesource.com/770306
Commit-Queue: Renjie Liu <renjieliu@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518784}
[modify] https://crrev.com/b08f01ba16baffa0783efd5696a2c652facde0b9/services/device/BUILD.gn
[modify] https://crrev.com/b08f01ba16baffa0783efd5696a2c652facde0b9/services/device/geolocation/BUILD.gn
[add] https://crrev.com/b08f01ba16baffa0783efd5696a2c652facde0b9/services/device/geolocation/public_ip_address_geolocator.cc
[add] https://crrev.com/b08f01ba16baffa0783efd5696a2c652facde0b9/services/device/geolocation/public_ip_address_geolocator.h
[add] https://crrev.com/b08f01ba16baffa0783efd5696a2c652facde0b9/services/device/geolocation/public_ip_address_geolocator_unittest.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b34d5365079be9b65905b0ba9204305e527d776

commit 9b34d5365079be9b65905b0ba9204305e527d776
Author: Renjie Liu <renjieliu@chromium.org>
Date: Mon Dec 18 23:48:38 2017

Provide PublicIpAddressGeolocationProvider in DeviceService

original owner: amoylan@chromium.org
orginal cl: https://chromium-review.googlesource.com/c/chromium/src/+/754256

This CL is part of the implementation of public-IP-only geolocation
as described in the design doc:
https://docs.google.com/document/d/1oSQM3GEMTL1raWLYv8S6_Yyt93FF2zQbANI4bKJ6LDs

This final part changes DeviceService to serve requests for
PublicIpAddressGeolocationProvider. The necessary dependencies (context
for URL requests, and Google API Key for geolocation queries) are injected
during the construction of DeviceService (currently hosted by browser
process).

In a subsequent CL, this new capability will be used to implement
GeoLanguageProvider, as described in this design doc:
https://docs.google.com/document/d/18WqVHz5F9vaUiE32E8Ge6QHmku2QSJKvlqB9JjnIM-g

Bug:  718694 ,  769158 
Change-Id: I79e96d482955260184bf5b4653b79d02b1ee75c7
Reviewed-on: https://chromium-review.googlesource.com/798993
Commit-Queue: Renjie Liu <renjieliu@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Ke He <ke.he@intel.com>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524863}
[modify] https://crrev.com/9b34d5365079be9b65905b0ba9204305e527d776/content/browser/service_manager/service_manager_context.cc
[modify] https://crrev.com/9b34d5365079be9b65905b0ba9204305e527d776/services/device/DEPS
[modify] https://crrev.com/9b34d5365079be9b65905b0ba9204305e527d776/services/device/device_service.cc
[modify] https://crrev.com/9b34d5365079be9b65905b0ba9204305e527d776/services/device/device_service.h
[modify] https://crrev.com/9b34d5365079be9b65905b0ba9204305e527d776/services/device/device_service_test_base.cc
[modify] https://crrev.com/9b34d5365079be9b65905b0ba9204305e527d776/services/device/geolocation/public_ip_address_geolocation_provider.cc
[modify] https://crrev.com/9b34d5365079be9b65905b0ba9204305e527d776/services/device/geolocation/public_ip_address_geolocation_provider.h
[modify] https://crrev.com/9b34d5365079be9b65905b0ba9204305e527d776/services/device/manifest.json

Status: Fixed (was: Started)

Sign in to add a comment