Missing WaitSyncToken call in Canvas2DLayerBridge |
||||||||
Issue descriptionThis CL removed critical GPU channel synchronization in the resource release callback in Canvas2DLayerBridge: https://chromium-review.googlesource.com/c/chromium/src/+/579690 Without the required WaitSyncToken there may be be flickering and data leakage in 2D canvases.
,
Sep 27 2017
,
Sep 27 2017
The bug is marked as P3 or Feature. It should not be merged as M62 is in beta. Please contact the approriate milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 29 2017
,
Sep 29 2017
This bug requires manual review: M62 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 29 2017
What is the risk associated with merging this cl into M62 at this time?
,
Sep 29 2017
The fix adds a synchronization primitive that was there before (for several years) and was removed by accident, so risk is extremely low.
,
Sep 29 2017
,
Oct 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e973fe29902695113010b2ec127260f0d3b08b15 commit e973fe29902695113010b2ec127260f0d3b08b15 Author: Justin Novosad <junov@chromium.org> Date: Mon Oct 02 17:48:59 2017 Add missing synchronization in 2d canvas resource release Call to WaitSyncTokenCHROMIUM was removed by mistake in: https://chromium-review.googlesource.com/c/chromium/src/+/579690 BUG= 769155 , 766611 TBR=junov@chromium.org (cherry picked from commit 3caef7b900b16af22a5eba78a27aef5516011e52) Change-Id: I25a95c79755801463b15fb12047458c594bf24d6 Reviewed-on: https://chromium-review.googlesource.com/685379 Commit-Queue: Xida Chen <xidachen@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Reviewed-by: Xida Chen <xidachen@chromium.org> Reviewed-by: Olivia Lai <xlai@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#504748} Reviewed-on: https://chromium-review.googlesource.com/695881 Reviewed-by: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#541} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/e973fe29902695113010b2ec127260f0d3b08b15/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
,
Oct 2 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Sep 27 2017