New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 769154 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 769153

Blocking:
issue 769137


Show other hotlists

Hotlists containing this issue:
EnamelAndFriendsFixIt


Sign in to add a comment

VariationsService::OnURLFetchComplete should retry over HTTP on failure

Project Member Reported by carlosil@chromium.org, Sep 27 2017

Issue description

If a fetch was unsuccessful, OnURLFetchComplete should check if it was unable to reach the server and it was using an HTTPS URL to reach it, if so, it should call DoActualFetch with the fallback HTTP URL
 
Blocking: 769137
Blockedon: 769153

Comment 3 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a03ca60d8d44b15a2857e8ab52307947646ee98a

commit a03ca60d8d44b15a2857e8ab52307947646ee98a
Author: Carlos IL <carlosil@chromium.org>
Date: Mon Dec 11 21:43:27 2017

VariationsService now retries over HTTP if HTTPS connection fails.

If a seed fetch over HTTP fails, Variations Service will now retry the fetch over
HTTP, encrypting the If-none-match header, and not including the
restrict parameter.

Bug:  769154 
Change-Id: Ief7fd92a691110719cda5396b3bfd9c4cd402fde
Reviewed-on: https://chromium-review.googlesource.com/777723
Commit-Queue: Carlos IL <carlosil@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523218}
[modify] https://crrev.com/a03ca60d8d44b15a2857e8ab52307947646ee98a/chrome/browser/chromeos/policy/variations_service_policy_browsertest.cc
[modify] https://crrev.com/a03ca60d8d44b15a2857e8ab52307947646ee98a/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/a03ca60d8d44b15a2857e8ab52307947646ee98a/components/variations/service/BUILD.gn
[modify] https://crrev.com/a03ca60d8d44b15a2857e8ab52307947646ee98a/components/variations/service/DEPS
[modify] https://crrev.com/a03ca60d8d44b15a2857e8ab52307947646ee98a/components/variations/service/variations_service.cc
[modify] https://crrev.com/a03ca60d8d44b15a2857e8ab52307947646ee98a/components/variations/service/variations_service.h
[modify] https://crrev.com/a03ca60d8d44b15a2857e8ab52307947646ee98a/components/variations/service/variations_service_unittest.cc
[modify] https://crrev.com/a03ca60d8d44b15a2857e8ab52307947646ee98a/components/variations/variations_switches.cc
[modify] https://crrev.com/a03ca60d8d44b15a2857e8ab52307947646ee98a/components/variations/variations_switches.h
[modify] https://crrev.com/a03ca60d8d44b15a2857e8ab52307947646ee98a/components/variations/variations_url_constants.cc
[modify] https://crrev.com/a03ca60d8d44b15a2857e8ab52307947646ee98a/components/variations/variations_url_constants.h
[modify] https://crrev.com/a03ca60d8d44b15a2857e8ab52307947646ee98a/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)

Sign in to add a comment