New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 769143 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 769136
issue 769144



Sign in to add a comment

Make EncryptSerializedReport more general

Project Member Reported by carlosil@chromium.org, Sep 27 2017

Issue description

Currently, EncryptSerializedReport and the proto it uses (EncryptedCertLoggerRequest) are only being used for certificate reports, and are therefore included in components/certificate_reporting/error_reporter.cc. In order to use them for  crbug.com/769136  they will be made more general and moved into a new encrypted_reports component.
 
Blocking: 769144
Blocking: 769136
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e5dd7650c120d4bf77364b2fba03a52a2b1b48c

commit 3e5dd7650c120d4bf77364b2fba03a52a2b1b48c
Author: Carlos IL <carlosil@chromium.org>
Date: Fri Oct 06 22:35:10 2017

Moved EncryptSerializedReport to its own component.

Moved EncryptSerializedReport, DecryptErrorReport, and
GetHkdfSubkeySecret from certificate_reporting to a new
encrypted_messages component and renamed them EncryptSerializedMessage
and DecryptMessage. Changed hkdf_label from a constant to a parameter
and modified all the code that depended on those functions to use them
from their new locations. Moved existing decryption test from
error_reporter.cc to the new component and added a test to validate
decryption fails with an invalid private key.

Bug:  769143 
Change-Id: I86b9b362fde92d35bca27be43adf0bc72fbf73f0
Reviewed-on: https://chromium-review.googlesource.com/690849
Reviewed-by: Nathan Parker <nparker@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507200}
[modify] https://crrev.com/3e5dd7650c120d4bf77364b2fba03a52a2b1b48c/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/3e5dd7650c120d4bf77364b2fba03a52a2b1b48c/chrome/browser/safe_browsing/certificate_reporting_service_test_utils.cc
[modify] https://crrev.com/3e5dd7650c120d4bf77364b2fba03a52a2b1b48c/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/3e5dd7650c120d4bf77364b2fba03a52a2b1b48c/components/BUILD.gn
[modify] https://crrev.com/3e5dd7650c120d4bf77364b2fba03a52a2b1b48c/components/certificate_reporting/BUILD.gn
[modify] https://crrev.com/3e5dd7650c120d4bf77364b2fba03a52a2b1b48c/components/certificate_reporting/DEPS
[delete] https://crrev.com/da95168e109c81c024d6edb25062af0a6fe2e7cd/components/certificate_reporting/encrypted_cert_logger.proto
[modify] https://crrev.com/3e5dd7650c120d4bf77364b2fba03a52a2b1b48c/components/certificate_reporting/error_reporter.cc
[modify] https://crrev.com/3e5dd7650c120d4bf77364b2fba03a52a2b1b48c/components/certificate_reporting/error_reporter.h
[modify] https://crrev.com/3e5dd7650c120d4bf77364b2fba03a52a2b1b48c/components/certificate_reporting/error_reporter_unittest.cc
[add] https://crrev.com/3e5dd7650c120d4bf77364b2fba03a52a2b1b48c/components/encrypted_messages/BUILD.gn
[add] https://crrev.com/3e5dd7650c120d4bf77364b2fba03a52a2b1b48c/components/encrypted_messages/DEPS
[add] https://crrev.com/3e5dd7650c120d4bf77364b2fba03a52a2b1b48c/components/encrypted_messages/OWNERS
[add] https://crrev.com/3e5dd7650c120d4bf77364b2fba03a52a2b1b48c/components/encrypted_messages/encrypted_message.proto
[add] https://crrev.com/3e5dd7650c120d4bf77364b2fba03a52a2b1b48c/components/encrypted_messages/message_encrypter.cc
[add] https://crrev.com/3e5dd7650c120d4bf77364b2fba03a52a2b1b48c/components/encrypted_messages/message_encrypter.h
[add] https://crrev.com/3e5dd7650c120d4bf77364b2fba03a52a2b1b48c/components/encrypted_messages/message_encrypter_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment