New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 769142 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 769136
issue 769144



Sign in to add a comment

Allow NetMetricsLogUploader::UploadLog to upload to a different URL

Project Member Reported by carlosil@chromium.org, Sep 27 2017

Issue description

Currently UploadLog will always upload to the URL set when the NetMetricsLogUploader was constructed. In order to implement  crbug.com/769136  the upload logic will be moved to a new UploadLogToURL function that will take the upload URL as a parameter. UploadLog will be modified so that when called it calls this new function with the default URL.
 
Blocking: 769144
Blocking: 769136
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c607767a4017bf819d0195a568d05f1dc1a40bc1

commit c607767a4017bf819d0195a568d05f1dc1a40bc1
Author: Carlos IL <carlosil@chromium.org>
Date: Mon Oct 02 21:33:18 2017

Added UploadLogToURL function to NetMetricsLogUploader.

Added an UploadLogToURL function to NetMetricsLogUploader, this
contains all the logic that was in the existing UploadLog function,
with the exception that it takes a URL as a parameter and uploads the
log to that URL instead of the one passed in the constructor. The
UploadLog function was modified so it now calls UploadLogToURL with the
URL set to server_url (So UploadLog keeps the same functionality it had
before this change).

R=estark@chromium.org

Bug:  769142 
Change-Id: I0d1b40d76c1d2fcb8528f301fe488d5d10e268b7
Reviewed-on: https://chromium-review.googlesource.com/692510
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505791}
[modify] https://crrev.com/c607767a4017bf819d0195a568d05f1dc1a40bc1/components/metrics/net/net_metrics_log_uploader.cc
[modify] https://crrev.com/c607767a4017bf819d0195a568d05f1dc1a40bc1/components/metrics/net/net_metrics_log_uploader.h

Status: Fixed (was: Started)

Sign in to add a comment