New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 769138 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Missing notification when an app automatically goes full screen in Public Session

Project Member Reported by jingwee@chromium.org, Sep 27 2017

Issue description

Chrome Version: M62.0.3202.31 minnie dev
OS: 9901.29.0

What steps will reproduce the problem?
(1) In CPanel, add the Enterprise DeviceAttributes Test Extension app to Force-installed Apps and Extensions:
https://chrome.google.com/webstore/detail/platformkeys-test-extensi/hoppbgdeajkagempifacalpdapphfoai
(2) On device, launch Public Session.
(3) Wait for Enterprise DeviceAttributes Test Extension app to be installed and double click to launch it.

What is the expected result?
According to  the design, a UI notification should appear when an app requests to go full-screen. This cannot be hidden. E.g. “The app is requesting to go full-screen.  Use the top bar to quit full-screen mode”.

What happens instead?
No notification is seen when the app went full-screen upon launch.
 
Screenshot from 2017-09-26 17:57:23.png
15.3 KB View Download
Components: UI>Shell>PublicAccounts
Owner: isandrk@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0643ee1bacea9a40d8b6554e3a39dad6a7e8919

commit c0643ee1bacea9a40d8b6554e3a39dad6a7e8919
Author: Ivan Sandrk <isandrk@google.com>
Date: Thu Sep 28 12:20:11 2017

[BUGFIX] Show a toast when an app automatically goes fullscreen in public session

Currently, a toast shows only when using the html5 fullscreen API when an app
goes fullscreen in ChromeOS public session. It should also be shown when an app
uses the extension windowing API to go fullscreen. Fix by including
FULLSCREEN_TYPE_WINDOW_API in the types that trigger the toast and update tests.

Bug: chromium:769138
Test: See bug
Change-Id: If1dacf1edbe577ed50fd2ab2c994cd094b71f2df
Reviewed-on: https://chromium-review.googlesource.com/686894
Commit-Queue: Ivan Šandrk <isandrk@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504974}
[modify] https://crrev.com/c0643ee1bacea9a40d8b6554e3a39dad6a7e8919/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc
[modify] https://crrev.com/c0643ee1bacea9a40d8b6554e3a39dad6a7e8919/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.h
[modify] https://crrev.com/c0643ee1bacea9a40d8b6554e3a39dad6a7e8919/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash_interactive_uitest.cc

Status: Fixed (was: Assigned)
Thanks for reporting this Jing, should be fixed now!
Cc: jingwee@chromium.org ibezmenov@chromium.org
Labels: M-62
isandrk@

When tested in M62.0.3202.43 9901.35.0 dev celes, I did not see any notification when launching the Enterprise DeviceAttributes Test Extension app as it automatically went full screen in public session.  I tried both manual and auto launch the app in public session with the same result.

I wonder if this notification comes in a popup balloon or something.  Thanks!
Status: Verified (was: Fixed)
As verified in M63.0.3230.0 10001.0.0 dev daisy, a pop-up notification is seen upon launching app in full screen mode.
Labels: Merge-Request-62
Status: Assigned (was: Verified)
Project Member

Comment 8 by sheriffbot@chromium.org, Oct 9 2017

Labels: -Merge-Request-62 Merge-Review-62 Hotlist-Merge-Review
This bug requires manual review: We are only 7 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-62 Merge-Approved-62
Approved for 62. 
I'd merge this, but this fix CL is dependant on another CL that is not in M62.
Project Member

Comment 11 by sheriffbot@chromium.org, Oct 16 2017

Cc: bhthompson@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: sduraisamy@chromium.org
@Raj, Would #c10 block the launch of the Full Screen mode in Public Sessions feature for M62. 

Project Member

Comment 13 by sheriffbot@chromium.org, Oct 20 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 14 by sheriffbot@chromium.org, Dec 11 2017

Labels: -Merge-Approved-62
This issue hasn't been updated in the last 6 weeks, so removing its merge approval label. Please re-request a merge if needed.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: -jingwee@chromium.org

Sign in to add a comment