New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 769127 link

Starred by 1 user
Status: Fixed
Owner:
█ shuqianz@chromium.org
Last visit > 30 days ago
Closed: Oct 2017
Cc:
█ jrbarnette@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

improve the deploy_server.py help and logging messages

Project Member Reported by akes...@chromium.org, Sep 27 2017 
~/chromiumos/src/third_party/autotest/files/site_utils$ ./deploy_server.py -h
usage: deploy_server.py [-h] [-v] [--continue] --afe AFE
                        [--update_push_servers] [--force_update] [--dryrun]
                        [--logfile LOGFILE]
                        ...
[snip]
  --afe AFE             What is the main server for this installation?
                        (cautotest).


What is meant by "main server"? I believe this should be the identify of the master (which is now under cname cautotest-prod for us, not cautotest). 

If "cautotest" is right, then the documentation could be clearer. "main server" -> "user-facing web frontend'.

Comment 1 by shuqianz@chromium.org, Sep 27 2017 

It doesn't matter which server to use. The AFE server is used to get all the servers from server_db to update. I tries on both cautotest and cautotest-prod, the server_db can be accessible from both servers.

Comment 2 by shuqianz@chromium.org, Sep 27 2017 

For now, it uses cautotest.

Comment 3 by akes...@chromium.org, Sep 27 2017

Status: Assigned (was: Untriaged)
Gotcha. Can you make the help text more clear?

Comment 4 by shuqianz@chromium.org, Sep 27 2017 

sure

Comment 5 by shuqianz@chromium.org, Sep 27 2017

Summary: improve the deploy_server.py help and logging messages (was: deploy_server.py is ambiguous about whether --afe should point at cautotest or cautotest-prod)

Comment 6 by shuqianz@chromium.org, Sep 27 2017 

Issue 769114 has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/6cf933b68a524bed75a3d887870e332de642fcdc

commit 6cf933b68a524bed75a3d887870e332de642fcdc
Author: Shuqian Zhao <shuqianz@chromium.org>
Date: Thu Oct 12 01:32:46 2017

autotest: improve logging and help messages in deploy_server.py

BUG= chromium:769127 
TEST=unittest

Change-Id: Ib71479f7f0fa51f7e205794c971baddf539dd5a4
Reviewed-on: https://chromium-review.googlesource.com/688022
Commit-Ready: Shuqian Zhao <shuqianz@chromium.org>
Tested-by: Shuqian Zhao <shuqianz@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/6cf933b68a524bed75a3d887870e332de642fcdc/site_utils/deploy_server.py

Comment 8 by shuqianz@chromium.org, Oct 12 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment