libbase-core-<version>.so and related libs are built without NDEBUG |
||
Issue descriptionI believe libbase-core-<version>.so and related libs are built without NDEBUG even though libchrome-<version>.ebuild calls cros-debug-add-NDEBUG in its src_configure(). As an experiment, I tried to add -DNDEBUG to platform2/login_manager/login_manager.gyp, but emerge-$BOARD login_manager failed with ../../../../../../../usr/include/base-395517/base/logging.h:258: error: undefined reference to 'logging::BaseInitLoggingImpl_built_with_NDEBUG(logging::LoggingSettings const&)' because libbase-core doesn't have the symbol: (cr) ((0c42206...)) yusukes@yusukes2 ~/trunk/src/scripts $ x86_64-cros-linux-gnu-nm -CD /build/eve/usr/lib64/libbase-core-395517.so | grep DEBUG 00000000000a3130 T logging::BaseInitLoggingImpl_built_without_NDEBUG(logging::LoggingSettings const&) Is this WAI? (Related issue: b/66960200 crbug.com/769100)
,
Sep 27 2017
Thanks for the comment. I read src/third_party/chromiumos-overlay/eclass/cros-debug.eclass and confirmed it's implemented that way.
> i'm guessing your packages are out of sync wrt that flag
Does './build_packages --board=${BOARD} --withdev' turn on cros-debug?
My device set up with 'cros flash ssh://ipaddr xbuddy://remote/eve/R63-9973.0.0/test' has logging::BaseInitLoggingImpl_built_with_NDEBUG, but another device with self-built image (--withdev) has logging::BaseInitLoggingImpl_built_without_NDEBUG.
Either way, closing. Sorry for the noise.
,
Sep 27 2017
--withdev just adds dev packages. --withdebug is what enables USE=cros-debug (which is also the default for local builds). you'd have to specify --nowithdebug manually to get USE=-cros-debug behavior. or if you installed a release image (like that eve xbuddy URL), you'd get --nowithdebug by default. test images are orthogonal to cros-debug settings. unfortunately.
,
Sep 28 2017
thanks! |
||
►
Sign in to add a comment |
||
Comment 1 by vapier@chromium.org
, Sep 27 2017