New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 769107 link

Starred by 2 users
Status: Fixed
Owner:
benchan@chromium.org
Closed: Oct 2017
Cc:
█ yunlian@chromium.org
derat@chromium.org
adlr@chromium.org
snanda@chromium.org
vapier@chromium.org
manojgupta@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Enable C++14 by default for compiling Chromium OS services written in C++ (e.g. platform2, shill, etc)

Project Member Reported by benchan@chromium.org, Sep 27 2017 
Chromium and AOSP now use C++14 (-std=gnu++14) by default for compiling C++ code. Many Chromium OS services/apps written in C++ (e.g. platform2, shill, etc) uses libchrome, which will need to be upgraded to match chromium/base. Before the next libchrome uprev, we should get ready for building those Chromium OS services/apps in C++14 mode.

We can start by enabling -std=gnu++14 in platform2, and then migrate other non-platform2 C++ projects on a case-by-case basis.

Comment 1 by benchan@chromium.org, Sep 27 2017

Cc: yunlian@chromium.org llozano@chromium.org
Status: Started (was: Assigned)
+llozano, +yunlian for feedback

platform2 seems to compile properly under -std=gnu++14, so I'd start with platform2/common-mk unless there is objection.

Comment 2 by vapier@chromium.org, Sep 27 2017

Cc: -llozano@chromium.org manojgupta@chromium.org
i vaguely recall Manoj running into an issue at some point because we weren't using C++14 yet, but i don't remember if it was platform2 code

Comment 4 by benchan@chromium.org, Sep 27 2017 

Ok, once I land CL:669672, we should be able to revert/update the workaround done to authpolicy.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/a4492e97c4e757802af1bbbd3819aa7c4e5048d1

commit a4492e97c4e757802af1bbbd3819aa7c4e5048d1
Author: Ben Chan <benchan@chromium.org>
Date: Thu Sep 28 04:13:00 2017

common-mk: default to -std=gnu++14 for C++ compilation

BUG= chromium:769107 
TEST=Remote trybot runs on paladin, release and chromiumos-sdk builders.

Change-Id: I04b7e57f446166ff58a461e04b7c0f3afe93a109
Reviewed-on: https://chromium-review.googlesource.com/669672
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/a4492e97c4e757802af1bbbd3819aa7c4e5048d1/common-mk/common.mk
[modify] https://crrev.com/a4492e97c4e757802af1bbbd3819aa7c4e5048d1/common-mk/common.gypi
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/15232cf1ef95e0c3037b98f90dbf49dc1d744505

commit 15232cf1ef95e0c3037b98f90dbf49dc1d744505
Author: Ben Chan <benchan@chromium.org>
Date: Thu Sep 28 09:04:02 2017

cros-disks: migrate from base::MakeUnique to std::make_unique

base::MakeUnique is being deprecated as we can now use std::make_unique
when compiling code in the C++14 mode.

BUG= chromium:769107 
CQ-DEPEND=CL:669672
TEST=Run unit tests.

Change-Id: If372bf9e1d370b07b6e2ee6c9d0746eeb2640849
Reviewed-on: https://chromium-review.googlesource.com/685603
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/15232cf1ef95e0c3037b98f90dbf49dc1d744505/cros-disks/device_ejector.cc
[modify] https://crrev.com/15232cf1ef95e0c3037b98f90dbf49dc1d744505/cros-disks/disk_manager.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/0737959b0ef05f15f1a554da93b7d2d5dcfe95d5

commit 0737959b0ef05f15f1a554da93b7d2d5dcfe95d5
Author: Ben Chan <benchan@chromium.org>
Date: Thu Sep 28 09:04:02 2017

mist: migrate from base::MakeUnique to std::make_unique

base::MakeUnique is being deprecated as we can now use std::make_unique
when compiling code in the C++14 mode.

BUG= chromium:769107 
CQ-DEPEND=CL:669672
TEST=Run unit tests.

Change-Id: I3ac353aacc35091cc6826f29a4e57f6c7016aaa1
Reviewed-on: https://chromium-review.googlesource.com/685604
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/0737959b0ef05f15f1a554da93b7d2d5dcfe95d5/mist/usb_manager.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/17f19af3a180fd8d251d5cd080b0f8ec1d6bee59

commit 17f19af3a180fd8d251d5cd080b0f8ec1d6bee59
Author: Ben Chan <benchan@chromium.org>
Date: Thu Sep 28 09:04:02 2017

wimax: migrate from base::MakeUnique to std::make_unique

base::MakeUnique is being deprecated as we can now use std::make_unique
when compiling code in the C++14 mode.

BUG= chromium:769107 
CQ-DEPEND=CL:669672
TEST=Run unit tests.

Change-Id: Ic49412d3c115b1ffb8345978869de5f03767a062
Reviewed-on: https://chromium-review.googlesource.com/685605
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/17f19af3a180fd8d251d5cd080b0f8ec1d6bee59/wimax_manager/gdm_driver.cc
[modify] https://crrev.com/17f19af3a180fd8d251d5cd080b0f8ec1d6bee59/wimax_manager/manager.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/649e41b3b51bca53deea670b8d3909e7bb04871f

commit 649e41b3b51bca53deea670b8d3909e7bb04871f
Author: Ben Chan <benchan@chromium.org>
Date: Thu Sep 28 09:04:02 2017

permission_broker: migrate from base::MakeUnique to std::make_unique

base::MakeUnique is being deprecated as we can now use std::make_unique
when compiling code in the C++14 mode.

BUG= chromium:769107 
CQ-DEPEND=CL:669672
TEST=Run unit tests.

Change-Id: I4777e57e83661960eaeaa1d612536a745ac90906
Reviewed-on: https://chromium-review.googlesource.com/685606
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/649e41b3b51bca53deea670b8d3909e7bb04871f/permission_broker/permission_broker.cc
[modify] https://crrev.com/649e41b3b51bca53deea670b8d3909e7bb04871f/permission_broker/deny_claimed_usb_device_rule.cc
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/connectivity/shill/+/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f

commit bea98208448dc5e91c2a9a9ba48efbc28d01bf6f
Author: Ben Chan <benchan@chromium.org>
Date: Thu Sep 28 10:59:26 2017

shill: migrate from base::MakeUnique to std::make_unique

base::MakeUnique is being deprecated as we can now use std::make_unique
when compiling code in the C++14 mode.

BUG= chromium:769107 
CQ-DEPEND=CL:669672
TEST=Run unit tests.

Change-Id: Ib1b7f1ed170f16e69767f4fd5416f71b90fcfb0e
Reviewed-on: https://chromium-review.googlesource.com/686063
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/manager_unittest.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/wifi/wifi_unittest.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/net/netlink_attribute.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/json_store.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/crypto_provider.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/cellular/modem_manager.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/routing_table_unittest.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/net/generic_netlink_message.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/cellular/modem_info.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/cellular/cellular_capability_universal_unittest.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/icmp_session_factory.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/cellular/out_of_credits_detector.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/cellular/modem_manager_1.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/wimax/wimax_service_unittest.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/process_manager.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/test-rpc-proxy/proxy_main.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/service_unittest.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/cellular/modem_manager_unittest.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/cellular/cellular_unittest.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/cellular/cellular_bearer_unittest.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/connection_health_checker_unittest.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/cellular/mobile_operator_info_unittest.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/external_task.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/net/attribute_list.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/dbus/chromeos_dbus_control.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/cellular/modem_1_unittest.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/mock_control.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/cellular/modem_info_unittest.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/hook_table_unittest.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/net/netlink_message.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/connection_diagnostics_unittest.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/nice_mock_control.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/dbus/dbus_service_watcher_factory.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/dns_client_factory.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/dbus/chromeos_manager_dbus_adaptor_unittest.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/ppp_daemon.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/key_file_store.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/cellular/cellular_capability_universal.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/wimax/wimax_unittest.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/metrics.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/test-rpc-proxy/proxy_dbus_client.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/default_profile_unittest.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/device_unittest.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/test-rpc-proxy/proxy_rpc_in_data_types.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/dhcp/dhcp_properties.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/net/nl80211_message.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/process_manager_unittest.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/vpn/l2tp_ipsec_driver.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/cellular/mobile_operator_info_impl.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/profile_unittest.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/wimax/wimax_provider_unittest.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/wifi/wifi.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/setup_wifi/main.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/vpn/vpn_provider_unittest.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/vpn/openvpn_driver_unittest.cc
[modify] https://crrev.com/bea98208448dc5e91c2a9a9ba48efbc28d01bf6f/dns_client.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/8e9f6d016a823d35330dc3cb41c54645557f90aa

commit 8e9f6d016a823d35330dc3cb41c54645557f90aa
Author: Ben Chan <benchan@chromium.org>
Date: Thu Sep 28 18:18:55 2017

debugd: migrate from base::MakeUnique to std::make_unique

base::MakeUnique is being deprecated as we can now use std::make_unique
when compiling code in the C++14 mode.

BUG= chromium:769107 
CQ-DEPEND=CL:669672
TEST=Run unit tests.

Change-Id: I6c6b69ec57c45369eb7500ab2785330045154842
Reviewed-on: https://chromium-review.googlesource.com/685607
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/8e9f6d016a823d35330dc3cb41c54645557f90aa/debugd/src/debugd_dbus_adaptor.cc
[modify] https://crrev.com/8e9f6d016a823d35330dc3cb41c54645557f90aa/debugd/src/helpers/netif.cc
[modify] https://crrev.com/8e9f6d016a823d35330dc3cb41c54645557f90aa/debugd/src/helpers/system_service_proxy.cc
[modify] https://crrev.com/8e9f6d016a823d35330dc3cb41c54645557f90aa/debugd/src/helpers/wimax_status.cc
[modify] https://crrev.com/8e9f6d016a823d35330dc3cb41c54645557f90aa/debugd/src/log_tool.cc
[modify] https://crrev.com/8e9f6d016a823d35330dc3cb41c54645557f90aa/debugd/src/debug_mode_tool.cc
[modify] https://crrev.com/8e9f6d016a823d35330dc3cb41c54645557f90aa/debugd/src/helpers/network_status.cc
[modify] https://crrev.com/8e9f6d016a823d35330dc3cb41c54645557f90aa/debugd/src/subprocess_tool.cc
[modify] https://crrev.com/8e9f6d016a823d35330dc3cb41c54645557f90aa/debugd/src/helpers/modem_status.cc
Project Member

Comment 12 by bugdroid1@chromium.org, Sep 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/2e0474c740d3a2b855b4671016bb4ed6f422acc7

commit 2e0474c740d3a2b855b4671016bb4ed6f422acc7
Author: Ben Chan <benchan@chromium.org>
Date: Thu Sep 28 18:18:55 2017

power: migrate from base::MakeUnique to std::make_unique

base::MakeUnique is being deprecated as we can now use std::make_unique
when compiling code in the C++14 mode.

BUG= chromium:769107 
CQ-DEPEND=CL:669672
TEST=Run unit tests.

Change-Id: Ica51735abea8eb6aadc353253759b242f4ac0d6e
Reviewed-on: https://chromium-review.googlesource.com/689695
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/2e0474c740d3a2b855b4671016bb4ed6f422acc7/power_manager/powerd/system/dark_resume.cc
[modify] https://crrev.com/2e0474c740d3a2b855b4671016bb4ed6f422acc7/power_manager/tools/backlight_tool.cc
[modify] https://crrev.com/2e0474c740d3a2b855b4671016bb4ed6f422acc7/power_manager/powerd/system/peripheral_battery_watcher.cc
[modify] https://crrev.com/2e0474c740d3a2b855b4671016bb4ed6f422acc7/power_manager/powerd/system/pluggable_internal_backlight.cc
Project Member

Comment 13 by bugdroid1@chromium.org, Sep 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/522a9108ec8feb0e6ad3a1bb473b9280ed130b43

commit 522a9108ec8feb0e6ad3a1bb473b9280ed130b43
Author: Ben Chan <benchan@chromium.org>
Date: Thu Sep 28 18:18:54 2017

container_utils: migrate from base::MakeUnique to std::make_unique

base::MakeUnique is being deprecated as we can now use std::make_unique
when compiling code in the C++14 mode.

BUG= chromium:769107 
CQ-DEPEND=CL:669672
TEST=Run unit tests.

Change-Id: I2d42a4bf166eb3c0d932ee30c4cc53bf2ab82e97
Reviewed-on: https://chromium-review.googlesource.com/690594
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/522a9108ec8feb0e6ad3a1bb473b9280ed130b43/container_utils/device_jail_utility.cc
Project Member

Comment 14 by bugdroid1@chromium.org, Sep 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ed23f71c21cbe9bb01ee1418592b89ebbd55c208

commit ed23f71c21cbe9bb01ee1418592b89ebbd55c208
Author: Ben Chan <benchan@chromium.org>
Date: Fri Sep 29 03:51:04 2017

login: migrate from base::MakeUnique to std::make_unique

base::MakeUnique is being deprecated as we can now use std::make_unique
when compiling code in the C++14 mode.

BUG= chromium:769107 
CQ-DEPEND=CL:669672
TEST=Run unit tests.

Change-Id: Ie46f10213e44fe24d34c494b145aed3fe8b6c549
Reviewed-on: https://chromium-review.googlesource.com/690614
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/ed23f71c21cbe9bb01ee1418592b89ebbd55c208/login_manager/nss_util.cc
[modify] https://crrev.com/ed23f71c21cbe9bb01ee1418592b89ebbd55c208/login_manager/session_manager_main.cc
[modify] https://crrev.com/ed23f71c21cbe9bb01ee1418592b89ebbd55c208/login_manager/device_local_account_policy_service.cc
[modify] https://crrev.com/ed23f71c21cbe9bb01ee1418592b89ebbd55c208/login_manager/session_manager_service.cc
[modify] https://crrev.com/ed23f71c21cbe9bb01ee1418592b89ebbd55c208/login_manager/login_metrics.cc
[modify] https://crrev.com/ed23f71c21cbe9bb01ee1418592b89ebbd55c208/login_manager/session_manager_impl.cc
[modify] https://crrev.com/ed23f71c21cbe9bb01ee1418592b89ebbd55c208/login_manager/device_policy_service.cc
[modify] https://crrev.com/ed23f71c21cbe9bb01ee1418592b89ebbd55c208/login_manager/session_manager_impl_unittest.cc
[modify] https://crrev.com/ed23f71c21cbe9bb01ee1418592b89ebbd55c208/login_manager/policy_service_unittest.cc
[modify] https://crrev.com/ed23f71c21cbe9bb01ee1418592b89ebbd55c208/login_manager/android_oci_wrapper_unittest.cc
[modify] https://crrev.com/ed23f71c21cbe9bb01ee1418592b89ebbd55c208/login_manager/device_policy_service_unittest.cc
[modify] https://crrev.com/ed23f71c21cbe9bb01ee1418592b89ebbd55c208/login_manager/user_policy_service_factory.cc
[modify] https://crrev.com/ed23f71c21cbe9bb01ee1418592b89ebbd55c208/login_manager/session_manager_process_unittest.cc
[modify] https://crrev.com/ed23f71c21cbe9bb01ee1418592b89ebbd55c208/login_manager/cumulative_use_time_metric_unittest.cc
Project Member

Comment 15 by bugdroid1@chromium.org, Sep 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/dd84f5f47e18853b53228037da5d6587a668ebd4

commit dd84f5f47e18853b53228037da5d6587a668ebd4
Author: Ben Chan <benchan@chromium.org>
Date: Fri Sep 29 03:51:02 2017

run_oci: migrate from base::MakeUnique to std::make_unique

base::MakeUnique is being deprecated as we can now use std::make_unique
when compiling code in the C++14 mode.

BUG= chromium:769107 
CQ-DEPEND=CL:669672
TEST=Run unit tests.

Change-Id: I2ca7e647693bc2b60d6f18f30eca06dc1e50eedb
Reviewed-on: https://chromium-review.googlesource.com/690634
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/dd84f5f47e18853b53228037da5d6587a668ebd4/run_oci/run_oci.cc
Project Member

Comment 16 by bugdroid1@chromium.org, Sep 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/47aefa3af382a12c13f5b9392105522ba8f61c4c

commit 47aefa3af382a12c13f5b9392105522ba8f61c4c
Author: Ben Chan <benchan@chromium.org>
Date: Fri Sep 29 06:26:27 2017

authpolicy: migrate from base::MakeUnique to std::make_unique

base::MakeUnique is being deprecated as we can now use std::make_unique
when compiling code in the C++14 mode.

BUG= chromium:769107 
CQ-DEPEND=CL:669672
TEST=Run unit tests.

Change-Id: I63edc4f984c3ab4cad8c63b479f59e039138ba7f
Reviewed-on: https://chromium-review.googlesource.com/689696
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>

[modify] https://crrev.com/47aefa3af382a12c13f5b9392105522ba8f61c4c/authpolicy/policy/device_policy_encoder.cc
[modify] https://crrev.com/47aefa3af382a12c13f5b9392105522ba8f61c4c/authpolicy/policy/extension_policy_encoder.cc
[modify] https://crrev.com/47aefa3af382a12c13f5b9392105522ba8f61c4c/authpolicy/authpolicy_unittest.cc
[modify] https://crrev.com/47aefa3af382a12c13f5b9392105522ba8f61c4c/authpolicy/jail_helper.cc
[modify] https://crrev.com/47aefa3af382a12c13f5b9392105522ba8f61c4c/authpolicy/samba_interface.cc
[modify] https://crrev.com/47aefa3af382a12c13f5b9392105522ba8f61c4c/authpolicy/policy/policy_encoder_test_base.h
[modify] https://crrev.com/47aefa3af382a12c13f5b9392105522ba8f61c4c/authpolicy/authpolicy.cc
Project Member

Comment 17 by bugdroid1@chromium.org, Sep 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/c8e66ac49fe5135fc8827c6a3122c7332e58f130

commit c8e66ac49fe5135fc8827c6a3122c7332e58f130
Author: Ben Chan <benchan@chromium.org>
Date: Fri Sep 29 06:26:25 2017

cryptohome: migrate from base::MakeUnique to std::make_unique

base::MakeUnique is being deprecated as we can now use std::make_unique
when compiling code in the C++14 mode.

BUG= chromium:769107 
CQ-DEPEND=CL:669672
TEST=Run unit tests.

Change-Id: I7e4d640c5f980ced51cdc24e111d90b526679f03
Reviewed-on: https://chromium-review.googlesource.com/689697
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

[modify] https://crrev.com/c8e66ac49fe5135fc8827c6a3122c7332e58f130/cryptohome/tpm2_impl.cc
[modify] https://crrev.com/c8e66ac49fe5135fc8827c6a3122c7332e58f130/cryptohome/install_attributes.cc
[modify] https://crrev.com/c8e66ac49fe5135fc8827c6a3122c7332e58f130/cryptohome/mount.cc
[modify] https://crrev.com/c8e66ac49fe5135fc8827c6a3122c7332e58f130/cryptohome/dircrypto_data_migrator/migration_helper.cc
[modify] https://crrev.com/c8e66ac49fe5135fc8827c6a3122c7332e58f130/cryptohome/service.cc
Project Member

Comment 18 by bugdroid1@chromium.org, Sep 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/831f8563822949e40e9020a3b0353b0d8359a831

commit 831f8563822949e40e9020a3b0353b0d8359a831
Author: Ben Chan <benchan@chromium.org>
Date: Fri Sep 29 06:26:37 2017

chaps: migrate from base::MakeUnique to std::make_unique

base::MakeUnique is being deprecated as we can now use std::make_unique
when compiling code in the C++14 mode.

BUG= chromium:769107 
CQ-DEPEND=CL:669672
TEST=Run unit tests.

Change-Id: Idd3cf8cb36a0325ec918a0aaabd14065be4ba068
Reviewed-on: https://chromium-review.googlesource.com/689698
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/831f8563822949e40e9020a3b0353b0d8359a831/chaps/chaps_proxy.cc
Project Member

Comment 19 by bugdroid1@chromium.org, Sep 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/33cdc26fc00f78250eb4b15a8a0bda6e9a9bc3de

commit 33cdc26fc00f78250eb4b15a8a0bda6e9a9bc3de
Author: Ben Chan <benchan@chromium.org>
Date: Fri Sep 29 06:26:30 2017

thd: migrate from base::MakeUnique to std::make_unique

base::MakeUnique is being deprecated as we can now use std::make_unique
when compiling code in the C++14 mode.

BUG= chromium:769107 
CQ-DEPEND=CL:669672
TEST=Run unit tests.

Change-Id: I4c46718cc8b2df2c06964a5a26da8636d79fca61
Reviewed-on: https://chromium-review.googlesource.com/689699
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/33cdc26fc00f78250eb4b15a8a0bda6e9a9bc3de/thd/source/file_source_unittest.cc
Project Member

Comment 20 by bugdroid1@chromium.org, Sep 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/cd0ccf5f30c0b2fc67c55087ddffc3d3b7a8e212

commit cd0ccf5f30c0b2fc67c55087ddffc3d3b7a8e212
Author: Ben Chan <benchan@chromium.org>
Date: Fri Sep 29 06:26:26 2017

biod: migrate from base::MakeUnique to std::make_unique

base::MakeUnique is being deprecated as we can now use std::make_unique
when compiling code in the C++14 mode.

BUG= chromium:769107 
CQ-DEPEND=CL:669672
TEST=Run unit tests.

Change-Id: I9b46d956c0dd5e2114e3fb98ceac94c5e5583a7a
Reviewed-on: https://chromium-review.googlesource.com/690635
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/cd0ccf5f30c0b2fc67c55087ddffc3d3b7a8e212/biod/biometrics_daemon.cc
[modify] https://crrev.com/cd0ccf5f30c0b2fc67c55087ddffc3d3b7a8e212/biod/tools/biod_client_tool.cc
[modify] https://crrev.com/cd0ccf5f30c0b2fc67c55087ddffc3d3b7a8e212/biod/biod_storage.cc
[modify] https://crrev.com/cd0ccf5f30c0b2fc67c55087ddffc3d3b7a8e212/biod/biod_storage_unittest.cc
Project Member

Comment 21 by bugdroid1@chromium.org, Sep 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/mtpd/+/88b7538e2193088561a09c70a52dc7da146430da

commit 88b7538e2193088561a09c70a52dc7da146430da
Author: Ben Chan <benchan@chromium.org>
Date: Sat Sep 30 03:16:29 2017

mtpd: migrate from base::MakeUnique to std::make_unique

base::MakeUnique is being deprecated as we can now use std::make_unique
when compiling code in the C++14 mode.

BUG= chromium:769107 
CQ-DEPEND=CL:669672
TEST=Run unit tests.

Change-Id: I75c087898c0ae937de9c8af0bdee86362cdc8728
Reviewed-on: https://chromium-review.googlesource.com/691238
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/88b7538e2193088561a09c70a52dc7da146430da/device_manager.cc
Project Member

Comment 22 by bugdroid1@chromium.org, Sep 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/imageloader/+/59ee7c51a9f6ca6b9d12f7dd763dc824d88c8c82

commit 59ee7c51a9f6ca6b9d12f7dd763dc824d88c8c82
Author: Ben Chan <benchan@chromium.org>
Date: Sat Sep 30 03:16:23 2017

imageloader: migrate from base::MakeUnique to std::make_unique

base::MakeUnique is being deprecated as we can now use std::make_unique
when compiling code in the C++14 mode.

BUG= chromium:769107 
CQ-DEPEND=CL:669672
TEST=Run unit tests.

Change-Id: Ibab5555a8bc500fa1af89ea2062a44b5f7e28f73
Reviewed-on: https://chromium-review.googlesource.com/691288
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>

[modify] https://crrev.com/59ee7c51a9f6ca6b9d12f7dd763dc824d88c8c82/imageloader_main.cc
[modify] https://crrev.com/59ee7c51a9f6ca6b9d12f7dd763dc824d88c8c82/imageloader_unittest.cc
[modify] https://crrev.com/59ee7c51a9f6ca6b9d12f7dd763dc824d88c8c82/component_unittest.cc
Project Member

Comment 24 by bugdroid1@chromium.org, Sep 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/d496e61770bc242a2d6b363bcf08cf575f0660dc

commit d496e61770bc242a2d6b363bcf08cf575f0660dc
Author: Ben Chan <benchan@chromium.org>
Date: Sat Sep 30 03:16:19 2017

midis: migrate from base::MakeUnique to std::make_unique

base::MakeUnique is being deprecated as we can now use std::make_unique
when compiling code in the C++14 mode.

BUG= chromium:769107 
CQ-DEPEND=CL:669672
TEST=Run unit tests.

Change-Id: Ib2d2400854739cadd5af537a758ac044ca74e373
Reviewed-on: https://chromium-review.googlesource.com/691127
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/d496e61770bc242a2d6b363bcf08cf575f0660dc/midis/subdevice_client_fd_holder.cc
[modify] https://crrev.com/d496e61770bc242a2d6b363bcf08cf575f0660dc/midis/tests/client_test.cc
[modify] https://crrev.com/d496e61770bc242a2d6b363bcf08cf575f0660dc/midis/tests/device_test.cc
[modify] https://crrev.com/d496e61770bc242a2d6b363bcf08cf575f0660dc/midis/daemon.cc
[modify] https://crrev.com/d496e61770bc242a2d6b363bcf08cf575f0660dc/midis/device_tracker.cc
[modify] https://crrev.com/d496e61770bc242a2d6b363bcf08cf575f0660dc/midis/tests/client_tracker_test.cc
[modify] https://crrev.com/d496e61770bc242a2d6b363bcf08cf575f0660dc/midis/tests/device_tracker_test.cc
[modify] https://crrev.com/d496e61770bc242a2d6b363bcf08cf575f0660dc/midis/client_tracker.cc
[modify] https://crrev.com/d496e61770bc242a2d6b363bcf08cf575f0660dc/midis/seq_handler.cc
[modify] https://crrev.com/d496e61770bc242a2d6b363bcf08cf575f0660dc/midis/file_handler.cc
[modify] https://crrev.com/d496e61770bc242a2d6b363bcf08cf575f0660dc/midis/tests/udev_handler_test.cc
Project Member

Comment 25 by bugdroid1@chromium.org, Sep 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/17e78ead749558ee444658dbf376309a7990a980

commit 17e78ead749558ee444658dbf376309a7990a980
Author: Ben Chan <benchan@chromium.org>
Date: Sat Sep 30 03:16:24 2017

hammerd: migrate from base::MakeUnique to std::make_unique

base::MakeUnique is being deprecated as we can now use std::make_unique
when compiling code in the C++14 mode.

BUG= chromium:769107 
CQ-DEPEND=CL:669672
TEST=Run unit tests.

Change-Id: I2c36844dc3895bc349199d9670545fec08a8c6ae
Reviewed-on: https://chromium-review.googlesource.com/691260
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/17e78ead749558ee444658dbf376309a7990a980/hammerd/update_fw.cc
[modify] https://crrev.com/17e78ead749558ee444658dbf376309a7990a980/hammerd/hammer_updater_unittest.cc
[modify] https://crrev.com/17e78ead749558ee444658dbf376309a7990a980/hammerd/hammerd_api.cc
[modify] https://crrev.com/17e78ead749558ee444658dbf376309a7990a980/hammerd/hammer_updater.cc
[modify] https://crrev.com/17e78ead749558ee444658dbf376309a7990a980/hammerd/update_fw_unittest.cc
Project Member

Comment 26 by bugdroid1@chromium.org, Sep 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/921e9752620798f71e068dbebb59e6f085c430ef

commit 921e9752620798f71e068dbebb59e6f085c430ef
Author: Ben Chan <benchan@chromium.org>
Date: Sat Sep 30 03:16:27 2017

u2fd: migrate from base::MakeUnique to std::make_unique

base::MakeUnique is being deprecated as we can now use std::make_unique
when compiling code in the C++14 mode.

BUG= chromium:769107 
CQ-DEPEND=CL:669672
TEST=Run unit tests.

Change-Id: Idf3805b5939e2a1a9fb27c78c5f972c45dea01f0
Reviewed-on: https://chromium-review.googlesource.com/691261
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/921e9752620798f71e068dbebb59e6f085c430ef/u2fd/u2fhid.cc
[modify] https://crrev.com/921e9752620798f71e068dbebb59e6f085c430ef/u2fd/main.cc
Project Member

Comment 27 by bugdroid1@chromium.org, Sep 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/8ff37cc05a199a7c8c0613567fba909c0baeda9c

commit 8ff37cc05a199a7c8c0613567fba909c0baeda9c
Author: Ben Chan <benchan@chromium.org>
Date: Sat Sep 30 03:16:21 2017

secure_erase_file: migrate from base::MakeUnique to std::make_unique

base::MakeUnique is being deprecated as we can now use std::make_unique
when compiling code in the C++14 mode.

BUG= chromium:769107 
CQ-DEPEND=CL:669672
TEST=Run unit tests.

Change-Id: Ia713948e6491afbfcecc5deaa5d058a9ea98cd93
Reviewed-on: https://chromium-review.googlesource.com/691287
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/8ff37cc05a199a7c8c0613567fba909c0baeda9c/secure_erase_file/secure_erase_file.cc
Project Member

Comment 28 by bugdroid1@chromium.org, Sep 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/24d0fdf5542238e4e0ef6dd6d05b3341cdac68b0

commit 24d0fdf5542238e4e0ef6dd6d05b3341cdac68b0
Author: Ben Chan <benchan@chromium.org>
Date: Sat Sep 30 03:16:22 2017

feedback: migrate from base::MakeUnique to std::make_unique

base::MakeUnique is being deprecated as we can now use std::make_unique
when compiling code in the C++14 mode.

BUG= chromium:769107 
CQ-DEPEND=CL:669672
TEST=Run unit tests.

Change-Id: I8fb869e3e98b5fd8cbedde60b9648a98e41e48fe
Reviewed-on: https://chromium-review.googlesource.com/691311
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/24d0fdf5542238e4e0ef6dd6d05b3341cdac68b0/feedback/feedback_client.cc
Project Member

Comment 29 by bugdroid1@chromium.org, Sep 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/df88cfaef0131f582703016ea62d322bbf66b224

commit df88cfaef0131f582703016ea62d322bbf66b224
Author: Ben Chan <benchan@chromium.org>
Date: Sat Sep 30 03:16:22 2017

debugd: migrate from base::MakeUnique to std::make_unique

base::MakeUnique is being deprecated as we can now use std::make_unique
when compiling code in the C++14 mode.

CL:685607 missed updating shill_scripts_tool.cc during rebase.

BUG= chromium:769107 
CQ-DEPEND=CL:669672
TEST=Run unit tests.

Change-Id: I026a8dd3cb265ce522bafcbe21cb7df54642da97
Reviewed-on: https://chromium-review.googlesource.com/691312
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/df88cfaef0131f582703016ea62d322bbf66b224/debugd/src/shill_scripts_tool.cc
Project Member

Comment 30 by bugdroid1@chromium.org, Sep 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/2351331becdaefc8bfc007de5dbf8b512dfa9f25

commit 2351331becdaefc8bfc007de5dbf8b512dfa9f25
Author: Ben Chan <benchan@chromium.org>
Date: Sat Sep 30 03:16:23 2017

virtual_file_provider: migrate from base::MakeUnique to std::make_unique

base::MakeUnique is being deprecated as we can now use std::make_unique
when compiling code in the C++14 mode.

BUG= chromium:769107 
CQ-DEPEND=CL:669672
TEST=Run unit tests.

Change-Id: I47062b2d3f8c2b01ab043babc3b7103e0d9d1ddf
Reviewed-on: https://chromium-review.googlesource.com/691360
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/2351331becdaefc8bfc007de5dbf8b512dfa9f25/virtual_file_provider/virtual_file_provider.cc
Project Member

Comment 31 by bugdroid1@chromium.org, Sep 30 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/thermald/+/f53a8a549bb3a432ca3acb9512a23128a0325355

commit f53a8a549bb3a432ca3acb9512a23128a0325355
Author: Ben Chan <benchan@chromium.org>
Date: Sat Sep 30 10:04:43 2017
Project Member

Comment 32 by bugdroid1@chromium.org, Oct 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/c4929c68ce7f412f5d6c68afebe0e1f4c98f9013

commit c4929c68ce7f412f5d6c68afebe0e1f4c98f9013
Author: Ben Chan <benchan@chromium.org>
Date: Mon Oct 02 10:03:46 2017

libcontainer: migrate from base::MakeUnique to std::make_unique

base::MakeUnique is being deprecated as we can now use std::make_unique
when compiling code in the C++14 mode.

BUG= chromium:769107 
CQ-DEPEND=CL:669672
TEST=Run unit tests.

Change-Id: Id567982674091fb924cdb2d9408f08c0d23e3c9a
Reviewed-on: https://chromium-review.googlesource.com/693744
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/c4929c68ce7f412f5d6c68afebe0e1f4c98f9013/libcontainer/libcontainer_unittest.cc
Project Member

Comment 33 by bugdroid1@chromium.org, Oct 2 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/platform/arc-oemcrypto/+/6f0c5a0b87fcf80a7be7c9ef80731852fa62dc82

commit 6f0c5a0b87fcf80a7be7c9ef80731852fa62dc82
Author: Ben Chan <benchan@chromium.org>
Date: Mon Oct 02 18:23:19 2017
Project Member

Comment 34 by bugdroid1@chromium.org, Oct 5 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/ap/+/529638e2914efadd5fa56647bb76a0def2438fbe

commit 529638e2914efadd5fa56647bb76a0def2438fbe
Author: Ben Chan <benchan@chromium.org>
Date: Thu Oct 05 04:44:32 2017
Project Member

Comment 35 by bugdroid1@chromium.org, Oct 5 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/ap-daemons/+/43d9e0c8cc3b2c5f3cf7ebbc144f9a8ac2d44a5b

commit 43d9e0c8cc3b2c5f3cf7ebbc144f9a8ac2d44a5b
Author: Ben Chan <benchan@chromium.org>
Date: Thu Oct 05 10:04:16 2017
Project Member

Comment 36 by bugdroid1@chromium.org, Oct 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/2a3a8e3effed7ced08dcec509e9bc05d10f33e32

commit 2a3a8e3effed7ced08dcec509e9bc05d10f33e32
Author: Ben Chan <benchan@chromium.org>
Date: Fri Oct 06 04:24:46 2017

midis: remove remaining uses of base::MakeUnique and inclusions of base/memory/ptr_util.h

BUG= chromium:769107 
CQ-DEPEND=CL:669672
TEST=Run unit tests.

Change-Id: I217706c9e5d9e3edffd4f8120b61a0d841237817
Reviewed-on: https://chromium-review.googlesource.com/702917
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Prashant Malani <pmalani@google.com>

[modify] https://crrev.com/2a3a8e3effed7ced08dcec509e9bc05d10f33e32/midis/client.cc
[modify] https://crrev.com/2a3a8e3effed7ced08dcec509e9bc05d10f33e32/midis/seq_handler.cc
[modify] https://crrev.com/2a3a8e3effed7ced08dcec509e9bc05d10f33e32/midis/device.cc
[modify] https://crrev.com/2a3a8e3effed7ced08dcec509e9bc05d10f33e32/midis/tests/seq_handler_test.cc
Project Member

Comment 37 by bugdroid1@chromium.org, Oct 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/external/libbrillo/+/de7f50dfda51d534cb8bd23e73c2354925b2099a

commit de7f50dfda51d534cb8bd23e73c2354925b2099a
Author: Ben Chan <benchan@chromium.org>
Date: Fri Oct 06 10:57:47 2017

libbrillo: migrate from base::MakeUnique to std::make_unique

base::MakeUnique is being deprecated as we can now use std::make_unique
when compiling code in the C++14 mode.

BUG= chromium:769107 
TEST=Run unit tests.

Change-Id: Ia3eb683524064888a1c4a29d3ba3e5124c3c9331
Reviewed-on: https://chromium-review.googlesource.com/703881
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/de7f50dfda51d534cb8bd23e73c2354925b2099a/policy/device_policy_impl.cc
[modify] https://crrev.com/de7f50dfda51d534cb8bd23e73c2354925b2099a/policy/libpolicy.cc
[modify] https://crrev.com/de7f50dfda51d534cb8bd23e73c2354925b2099a/policy/tests/libpolicy_unittest.cc
[modify] https://crrev.com/de7f50dfda51d534cb8bd23e73c2354925b2099a/brillo/http/http_proxy_unittest.cc
[modify] https://crrev.com/de7f50dfda51d534cb8bd23e73c2354925b2099a/brillo/process.cc
Project Member

Comment 38 by bugdroid1@chromium.org, Oct 6 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/platform/easy-unlock-crypto/+/b12cb1a023b3b62aa6e4df0efe66615d662b3050

commit b12cb1a023b3b62aa6e4df0efe66615d662b3050
Author: Ben Chan <benchan@chromium.org>
Date: Fri Oct 06 10:57:47 2017

Comment 39 by benchan@chromium.org, Oct 7 2017

Status: Fixed (was: Started)
Project Member

Comment 40 by bugdroid1@chromium.org, Oct 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/docs/+/2a6fee7a3d6066af1a1e0420a7c5f066f1cfbca7

commit 2a6fee7a3d6066af1a1e0420a7c5f066f1cfbca7
Author: Ben Chan <benchan@chromium.org>
Date: Tue Oct 10 03:07:57 2017

docs: use std::make_unique instead of base::MakeUnique in example

base::MakeUnique is being deprecated as we can now use std::make_unique
when compiling code in the C++14 mode.

BUG= chromium:769107 
TEST=None

Change-Id: I07607d8242e37f64d86a7ee1a8478db819a3e0e0
Reviewed-on: https://chromium-review.googlesource.com/707894
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/2a6fee7a3d6066af1a1e0420a7c5f066f1cfbca7/unit_tests.md
Project Member

Comment 41 by bugdroid1@chromium.org, Oct 15 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/platform/actions/+/e5c0dc04fd6e28592c49bcfbff5125e367b9425e

commit e5c0dc04fd6e28592c49bcfbff5125e367b9425e
Author: Ben Chan <benchan@chromium.org>
Date: Sat Oct 14 02:43:07 2017
Project Member

Comment 42 by bugdroid1@chromium.org, Oct 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/update_engine/+/ab5a0af8e6ebac0211da5b08010e4855ce463108

commit ab5a0af8e6ebac0211da5b08010e4855ce463108
Author: Ben Chan <benchan@chromium.org>
Date: Fri Oct 13 21:44:50 2017

update_engine: migrate from base::MakeUnique to std::make_unique

base::MakeUnique is being deprecated as we can now use std::make_unique
when compiling code in the C++14 mode.

BUG= chromium:769107 
CQ-DEPEND=CL:669672
TEST=Run unit tests.

Change-Id: I82f76647239b1eb3b98b19f6479788ffd86ce756
Reviewed-on: https://chromium-review.googlesource.com/716826
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Sen Jiang <senj@chromium.org>

[modify] https://crrev.com/ab5a0af8e6ebac0211da5b08010e4855ce463108/network_selector_android.cc
[modify] https://crrev.com/ab5a0af8e6ebac0211da5b08010e4855ce463108/payload_generator/zip_unittest.cc
[modify] https://crrev.com/ab5a0af8e6ebac0211da5b08010e4855ce463108/network_selector_stub.cc
[modify] https://crrev.com/ab5a0af8e6ebac0211da5b08010e4855ce463108/real_system_state.cc
[modify] https://crrev.com/ab5a0af8e6ebac0211da5b08010e4855ce463108/update_manager/evaluation_context.cc
[modify] https://crrev.com/ab5a0af8e6ebac0211da5b08010e4855ce463108/payload_consumer/extent_writer_unittest.cc
[modify] https://crrev.com/ab5a0af8e6ebac0211da5b08010e4855ce463108/omaha_request_action_unittest.cc
[modify] https://crrev.com/ab5a0af8e6ebac0211da5b08010e4855ce463108/hardware_android.cc
[modify] https://crrev.com/ab5a0af8e6ebac0211da5b08010e4855ce463108/payload_consumer/bzip_extent_writer_unittest.cc
[modify] https://crrev.com/ab5a0af8e6ebac0211da5b08010e4855ce463108/update_manager/state_factory.cc
[modify] https://crrev.com/ab5a0af8e6ebac0211da5b08010e4855ce463108/payload_consumer/delta_performer.cc
[modify] https://crrev.com/ab5a0af8e6ebac0211da5b08010e4855ce463108/update_attempter.cc
Project Member

Comment 43 by bugdroid1@chromium.org, Oct 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/f8cffd95ee39146657caaa6b33eaa4219f90993d

commit f8cffd95ee39146657caaa6b33eaa4219f90993d
Author: Ben Chan <benchan@chromium.org>
Date: Sat Oct 14 10:18:33 2017

login: migrate from base::MakeUnique to std::make_unique

base::MakeUnique is being deprecated as we can now use std::make_unique
when compiling code in the C++14 mode.

BUG= chromium:769107 
CQ-DEPEND=CL:669672
TEST=Run unit tests.

Change-Id: I8e96f84974c8a77eee3dff930b38520d5535acfb
Reviewed-on: https://chromium-review.googlesource.com/719432
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/f8cffd95ee39146657caaa6b33eaa4219f90993d/login_manager/session_manager_impl_unittest.cc
Project Member

Comment 44 by bugdroid1@chromium.org, Oct 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/tpm/+/82e91c996576d2db69155b909bc367c43e11f2e5

commit 82e91c996576d2db69155b909bc367c43e11f2e5
Author: Ben Chan <benchan@chromium.org>
Date: Tue Oct 24 05:39:10 2017

Migrate from base::MakeUnique to std::make_unique.

base::MakeUnique is being deprecated as we can now use std::make_unique
when compiling code in the C++14 mode.

BUG= chromium:769107 
TEST=Run unit tests.

Change-Id: If089511f90627af68fdb895be7ef079d059dbca3
Reviewed-on: https://chromium-review.googlesource.com/734423
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

[modify] https://crrev.com/82e91c996576d2db69155b909bc367c43e11f2e5/trunks/trunks_factory_impl.cc
[modify] https://crrev.com/82e91c996576d2db69155b909bc367c43e11f2e5/tpm_manager/server/tpm_manager_service.cc
[modify] https://crrev.com/82e91c996576d2db69155b909bc367c43e11f2e5/tpm_manager/client/main.cc
[modify] https://crrev.com/82e91c996576d2db69155b909bc367c43e11f2e5/trunks/trunks_factory_for_test.cc
[modify] https://crrev.com/82e91c996576d2db69155b909bc367c43e11f2e5/attestation/common/tpm_utility_v2.cc
Project Member

Comment 45 by bugdroid1@chromium.org, Dec 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/bb28552c6c4f4caac8c4eba8ce2b36eda3e85b86

commit bb28552c6c4f4caac8c4eba8ce2b36eda3e85b86
Author: Ben Chan <benchan@chromium.org>
Date: Wed Dec 20 08:34:04 2017

smbprovider: migrate from base::MakeUnique to std::make_unique

base::MakeUnique is being deprecated as we can now use std::make_unique
when compiling code in the C++14 mode.

BUG= chromium:769107 
TEST=Run unit tests.

Change-Id: Ic538dbd165d217a18e55d581e2c1f837175bd99f
Reviewed-on: https://chromium-review.googlesource.com/833404
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/bb28552c6c4f4caac8c4eba8ce2b36eda3e85b86/smbprovider/smbprovider_main.cc
[modify] https://crrev.com/bb28552c6c4f4caac8c4eba8ce2b36eda3e85b86/smbprovider/smbprovider_test.cc
Project Member

Comment 46 by bugdroid1@chromium.org, Jan 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/1ca78ecc9ba0b7145c9b9723b27b38bb9bb14787

commit 1ca78ecc9ba0b7145c9b9723b27b38bb9bb14787
Author: Ben Chan <benchan@chromium.org>
Date: Wed Jan 03 22:23:27 2018

chromeos-dbus-bindings: migrate from base::MakeUnique to std::make_unique

base::MakeUnique is being deprecated as we can now use std::make_unique
when compiling code in the C++14 mode.

BUG= chromium:769107 
TEST=None

Change-Id: I6099fffa80aee9a2ef5c0cde53a2fa50f21cece5
Reviewed-on: https://chromium-review.googlesource.com/847897
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/1ca78ecc9ba0b7145c9b9723b27b38bb9bb14787/chromeos-dbus-bindings/README.md

Comment 47 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 48 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
►

Sign in to add a comment