Remove -DNDEBUG from platform2/chaps/Makefile |
||
Issue descriptionOS Version: M63 tot I'm not really sure if this is intentional, but libchrome-9999.ebuild seems to compile libbase-core-$VERSION.so and related libraries without -DNDEBUG: (cr) ((0c42206...)) yusukes@yusukes2 ~/trunk/src/scripts $ x86_64-cros-linux-gnu-nm -CD /build/eve/usr/lib64/libbase-core-395517.so | grep DEBUG 00000000000a3130 T logging::BaseInitLoggingImpl_built_without_NDEBUG(logging::LoggingSettings const&) However, platform2/chaps/Makefile (which I believe depends on libbase) uses -DNDEBUG. This discrepancy may cause some unexpected behavior. I'm filing this just in case because platform/cheets-scripts/arc-setup/Makefile used to use the same flag and we (ARC++ team) experienced crashes. b/66960200#comment2 has more tails on this.
,
Oct 12
,
Nov 5
I think I just hit an issue related to this bug. I compiled my ChromeOS image with USE="-cros-debug" and then went on afterwards to cros_workon_make power_manager without the USE flag. I hit the following error: [4/6] LINK powerd FAILED: powerd x86_64-cros-linux-gnu-clang++ -Wl,-O2 -Wl,--as-needed -Wl,-z,relro -Wl,-z,noexecstack -Wl,-z,now -Wl,--as-needed --sysroot=/build/nautilus -pie -pthread -o powerd -Wl,--start-group obj/power_manager/powerd/powerd.main.o libpowerd.a libpolicy.a libsystem.a libutil.a -Wl,--end-group -lbrillo-395517 -lbase-395517 -lcros_config -ludev -lsystem_api-power_manager-protos -lsystem_api-cryptohome-protos -lsystem_api-authpolicy-protos -lsystem_api-biod-protos -lsystem_api-protos -lsystem_api-login_manager-protos -lsystem_api-chaps-protos -lsystem_api-smbprovider-protos -lsystem_api-vm_concierge-protos -lsystem_api-vm_applications-protos -lsystem_api-vm_cicerone-protos -lsystem_api-seneschal-protos -lsystem_api-oobe_config-protos -lsystem_api-update_engine-protos -lsystem_api-dlcservice-protos -lprotobuf-lite -lpthread -lmetrics-395517 -lm -lrt ../../../../../../../../usr/include/base-395517/base/logging.h:258: error: undefined reference to 'logging::BaseInitLoggingImpl_built_without_NDEBUG(logging::LoggingSettings const&)' clang-8: error: linker command failed with exit code 1 (use -v to see invocation) which went away as soon as I exported the "correct" USE flags |
||
►
Sign in to add a comment |
||
Comment 1 by yusukes@chromium.org
, Sep 27 2017