New issue
Advanced search Search tips

Issue 769098 link

Starred by 0 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

mash: Remove ash access from chrome/browser/ui/views/apps/

Project Member Reported by e...@chromium.org, Sep 27 2017

Issue description

Lots of direct linking.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60e8284052f38f6fb5aa8bf8ba32fb7752cc66e4

commit 60e8284052f38f6fb5aa8bf8ba32fb7752cc66e4
Author: Elliot Glaysher <erg@chromium.org>
Date: Mon Oct 02 17:58:26 2017

Make app windows use window properties instead of ash::WindowState.

The NativeAppWindowStateDelegate implements WindowStateObserver, but
we're trying to break all hard dependencies on ash from chrome for
mash.

Bug: 769098
Change-Id: I0e15df0c22c9c719164b10569ab113cd37e5dfaa
Reviewed-on: https://chromium-review.googlesource.com/685803
Commit-Queue: Elliot Glaysher <erg@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505671}
[modify] https://crrev.com/60e8284052f38f6fb5aa8bf8ba32fb7752cc66e4/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0fe3ce7674e1700f15c4532dd06d9d411f20ae9

commit c0fe3ce7674e1700f15c4532dd06d9d411f20ae9
Author: Elliot Glaysher <erg@chromium.org>
Date: Mon Oct 02 22:52:25 2017

Move ChromeNativeAppWindowViewsAuraAsh to the TabletModeClient interface

Bug: 769098,  756046 
Change-Id: I134d37276c02e38f38e9d3677683912dbceb7b39
Reviewed-on: https://chromium-review.googlesource.com/688475
Commit-Queue: Elliot Glaysher <erg@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505831}
[modify] https://crrev.com/c0fe3ce7674e1700f15c4532dd06d9d411f20ae9/ash/wm/tablet_mode/tablet_mode_controller.cc
[modify] https://crrev.com/c0fe3ce7674e1700f15c4532dd06d9d411f20ae9/ash/wm/tablet_mode/tablet_mode_controller.h
[modify] https://crrev.com/c0fe3ce7674e1700f15c4532dd06d9d411f20ae9/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/c0fe3ce7674e1700f15c4532dd06d9d411f20ae9/chrome/browser/ui/ash/fake_tablet_mode_controller.cc
[add] https://crrev.com/c0fe3ce7674e1700f15c4532dd06d9d411f20ae9/chrome/browser/ui/ash/fake_tablet_mode_controller.h
[modify] https://crrev.com/c0fe3ce7674e1700f15c4532dd06d9d411f20ae9/chrome/browser/ui/ash/tablet_mode_client_unittest.cc
[modify] https://crrev.com/c0fe3ce7674e1700f15c4532dd06d9d411f20ae9/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc
[modify] https://crrev.com/c0fe3ce7674e1700f15c4532dd06d9d411f20ae9/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.h
[modify] https://crrev.com/c0fe3ce7674e1700f15c4532dd06d9d411f20ae9/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash_browsertest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a3ae925e1b5de3dacf36c7060ccf9babe387e7f

commit 3a3ae925e1b5de3dacf36c7060ccf9babe387e7f
Author: Elliot Glaysher <erg@chromium.org>
Date: Fri Oct 27 18:48:12 2017

Remove more direct usage of //ash/wm/window_state.h from //chrome/.

Bug: 769098
Change-Id: I57bf17f61a949a917b901dd1a5b29b5065049582
Reviewed-on: https://chromium-review.googlesource.com/740362
Commit-Queue: Elliot Glaysher <erg@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512255}
[modify] https://crrev.com/3a3ae925e1b5de3dacf36c7060ccf9babe387e7f/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc
[modify] https://crrev.com/3a3ae925e1b5de3dacf36c7060ccf9babe387e7f/chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc

Components: -Internals>MUS Internals>Services>WindowService

Comment 6 by e...@chromium.org, Mar 6 2018

Owner: ----
Status: Available (was: Assigned)
Mass unassigning bugs

Sign in to add a comment