works in chroot.

I'm seeing the same error.

I develop outside the chroot, and would prefer to invoke repo upload outside the chroot. This has been working until recently.

What's the reason this cannot be fixed?

The first error looks like you have a bad version of pylint installed locally.  That's why you need to run in the chroot.  Otherwise, you are on your own for fixing your working environment.

The second error is a dupe of https://bugs.chromium.org/p/chromium/issues/detail?id=767678, make sure you have a full and up to date repo checkout.

I'm seeing the first error, and I have some new lucifer error (but I've never expected test_lucifer to work -- I have a knee-jerk '--no-verify' at this point). Pylint is whatever Rodete is shipping:

$ pylint --version
pylint.py 1.4.1, 
astroid 1.3.4, common 0.63.2
Python 2.7.13 (default, Nov 24 2017, 17:33:09) 
[GCC 6.3.0 20170516]


autotest is the only project that persistently barfs on running its presubmits outside the chroot. Would still be nice to get this fixed...

The presubmits should work outside the chroot, the chroot is just a way to ensure your environment isn't the thing breaking them.  It sounds like something about your environment is breaking them; what, I do not know.  If you can provide an example that I can reproduce, then I can look into it.

Can you post the new lucifer error?  There are only two issues left that I am aware of, you need to run build_externals.py (which cannot be shared inside vs outside the chroot) and you need to install virtualenv.

Hmm, I don't know what changed, but pylint is no longer failing. Could build_externals.py be related there too? I think I'm even checking out the exact same CLs that wouldn't run earlier...

For test_lucifer (ignore the pylint errors; they're preexisting "legit" errors):

Errors in PROJECT *chromiumos/third_party/autotest*!                                                     
    COMMIT db02f7bc:
        Description:
            >power_SuspendStress: use 'interface' library
            >
            >We don't need to reimplement the 'is_up' check.
            >
            >BUG=chromium:814442
            >TEST=power_SuspendStress with cable removed and 'check_connection'
            >     forced on
            >
            >Change-Id: I7b8c6f59529ecc6a718b86a1127a2c85e44e9a00
            >Signed-off-by: Brian Norris <briannorris@chromium.org>
            >
            >
        Errors:
            * Hook script "./utils/run_pylint.py" failed with code 1:
              ************* Module power_SuspendStress
              C: 59, 4: Missing method docstring (missing-docstring)
              C: 89, 4: Missing method docstring (missing-docstring)
              
              ------------------------------------------------------------------
              Your code has been rated at 9.73/10 (previous run: 9.73/10, +0.00)
              
              ERROR:root:16
              
            * Hook script "./bin/test_lucifer" failed with code 2:
              ============================= test session starts ==============================
              platform linux2 -- Python 2.7.13, pytest-3.1.3, py-1.4.34, pluggy-0.4.0
              rootdir: /usr/local/google/home/briannorris/chromiumos/src/third_party/autotest/files/venv, inifile: pytest.ini
              plugins: catchlog-1.2.2, cov-2.5.1
              collected 24 items / 2 errors
              
              
              ---------- coverage: platform linux2, python 2.7.13-final-0 ----------
              Name                               Stmts   Miss Branch BrPart  Cover   Missing
              ------------------------------------------------------------------------------
              lucifer/autotest.py                   73     42      6      0    39%   49-50, 57-66, 72-108, 117-120, 135-139, 142, 149-154, 164, 174, 184-186, 196-198
              lucifer/autotest_unittest.py          32     17      0      0    47%   23-26, 37-39, 47-51, 56-58, 66-70, 78-82
              lucifer/cmd/job_aborter.py            76     49     18      0    29%   56-70, 74-82, 98-107, 115-117, 125-127, 134, 143-145, 153-154, 167-168, 181-185, 189, 193, 197
              lucifer/cmd/job_reporter.py           60     36      2      0    39%   51-67, 75-80, 89-93, 98-103, 119-128, 133-136, 140, 144
              lucifer/cmd/test/abort_socket.py      15      5      0      0    67%   28-32
              lucifer/eventlib.py                   37     19      2      0    46%   75-81, 92-97, 106-112
              lucifer/eventlib_unittest.py          42     24      0      0    43%   17-33, 38-47, 52-57, 62-67, 72-74, 83, 86, 93, 96
              lucifer/handlers.py                  126     99     34      0    17%   41-45, 48-55, 59, 63, 66-77, 80-81, 85-95, 98-107, 110-116, 124-131, 140-143, 149-159, 163-176, 180, 188-200, 205-210
              lucifer/handoffs.py                   44     29      8      0    29%   32-38, 49-59, 63-68, 73-82, 90-94
              lucifer/jobx.py                       31     22      8      0    23%   26, 34-35, 46-49, 59-63, 76-80, 91-92, 100-103
              lucifer/leasing.py                    69     43      6      0    35%   43-48, 57-59, 74, 79, 91-100, 108-117, 128-135, 139-142, 147, 152, 160-168
              lucifer/leasing_unittest.py          116     82     10      0    27%   35-38, 44-47, 53-57, 63-68, 73-76, 81-84, 89-96, 101-107, 113-120, 126-134, 140-141, 157-173, 186-197, 202, 207, 216-219
              lucifer/loglib.py                     13      4      0      0    69%   22, 33-34, 43
              lucifer/loglib_unittest.py            19     19      0      0     0%   5-35
              ------------------------------------------------------------------------------
              TOTAL                                787    490     94      0    34%
              
              6 files skipped due to complete coverage.
              
              ==================================== ERRORS ====================================
              _________________ ERROR collecting lucifer/loglib_unittest.py __________________
              ../../../../../../.cache/cros_venv/venv-2.7.13-5e245727ed23dd962b0bb6d1c7a40f7d/local/lib/python2.7/site-packages/py/_path/local.py:680: in pyimport
                  raise self.ImportMismatchError(modname, modfile, self)
              E   ImportMismatchError: ('lucifer.loglib_unittest', '/mnt/host/source/src/third_party/autotest/files/venv/lucifer/loglib_unittest.py', local('/usr/local/google/home/briannorris/chromiumos/src/third_party/autotest/files/venv/lucifer/loglib_unittest.py'))
              _________________ ERROR collecting lucifer/loglib_unittest.py __________________
              import file mismatch:
              imported module 'lucifer.loglib_unittest' has this __file__ attribute:
                /mnt/host/source/src/third_party/autotest/files/venv/lucifer/loglib_unittest.py
              which is not the same as the test file we want to collect:
                /usr/local/google/home/briannorris/chromiumos/src/third_party/autotest/files/venv/lucifer/loglib_unittest.py
              HINT: remove __pycache__ / .pyc files and/or use a unique basename for your test file modules
              !!!!!!!!!!!!!!!!!!! Interrupted: 2 errors during collection !!!!!!!!!!!!!!!!!!!!
              =========================== 2 error in 0.40 seconds ============================
              

Preupload failed due to errors in project(s). HINTS:
- To disable some source style checks, and for other hints, see <checkout_dir>/src/repohooks/README
- To upload only current project, run 'repo upload .'




Oh...but educated guesses (and the error about .pyc files) led me to try removing/re-checking out the 'venv' directory...and now it works.

I guess that means presubmits (at least, outside the chroot) are incompatible with running 'test_that --autotest_dir=$HOME/trunk/src/third_party/autotest/files/ ...'? Because that tends to leave .pyc files strewn about.

assigning to ayatane@ to comment

re #7

In general, Python's pyc do not work across inside/outside chroot, since the absolute path changes.  I have considered always removing pyc before running unittests, but that introduces a performance penalty (having to recompile the pyc files every time).

https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/887358