New issue
Advanced search Search tips

Issue 769024 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Task

Blocking:
issue 611935



Sign in to add a comment

[mojo-blobs] Make sure WebBlobInfo always has a BlobDataHandle associated with it

Project Member Reported by mek@chromium.org, Sep 26 2017

Issue description

This will require auditing all places a WebBlobInfo is created and making sure a mojo pipe or BlobDataHandle is passed in.
 

Comment 1 by laforge@google.com, Nov 7 2017

Components: Internals>Network>Service

Comment 2 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.

Comment 3 by laforge@google.com, Nov 8 2017

Components: Internals>Services>Storage
Setting Internals>Services>Storage to all children of issue 611935
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4e2d638a9059794d68df60f6f7559f1ad141ccf

commit f4e2d638a9059794d68df60f6f7559f1ad141ccf
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Fri Jan 26 19:44:30 2018

Take advantage of mojo blobs for lifetime management in clipboard code.

Bug:  604800 , 769024, 740744
Change-Id: I2267b1015e3c9ad0d3dfe019572ff328557e0112
Reviewed-on: https://chromium-review.googlesource.com/882483
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532042}
[modify] https://crrev.com/f4e2d638a9059794d68df60f6f7559f1ad141ccf/content/browser/blob_storage/chrome_blob_storage_context.cc
[modify] https://crrev.com/f4e2d638a9059794d68df60f6f7559f1ad141ccf/content/browser/renderer_host/clipboard_host_impl.cc
[modify] https://crrev.com/f4e2d638a9059794d68df60f6f7559f1ad141ccf/content/public/browser/blob_handle.h
[modify] https://crrev.com/f4e2d638a9059794d68df60f6f7559f1ad141ccf/third_party/WebKit/Source/core/clipboard/DataObjectItem.cpp
[modify] https://crrev.com/f4e2d638a9059794d68df60f6f7559f1ad141ccf/third_party/WebKit/Source/platform/exported/WebClipboardImpl.cpp
[modify] https://crrev.com/f4e2d638a9059794d68df60f6f7559f1ad141ccf/third_party/WebKit/common/blob/blob.mojom
[modify] https://crrev.com/f4e2d638a9059794d68df60f6f7559f1ad141ccf/third_party/WebKit/common/clipboard/clipboard.mojom
[modify] https://crrev.com/f4e2d638a9059794d68df60f6f7559f1ad141ccf/third_party/WebKit/common/message_port/message_port.mojom

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5adc578c3fc05b33d92f1a4cc523e330384f297c

commit 5adc578c3fc05b33d92f1a4cc523e330384f297c
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Sat Jan 27 03:43:20 2018

Cleanup deprecated and unused WebBlobInfo constructors.

Also remove last usage of these deprecated constructors (mostly in tests,
where just passing a dangling mojo message pipe works fine).

Bug: 769024
Change-Id: I38b390e64552abc971035eec97d090a85ec701f9
Reviewed-on: https://chromium-review.googlesource.com/883570
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Chris Mumford <cmumford@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532147}
[modify] https://crrev.com/5adc578c3fc05b33d92f1a4cc523e330384f297c/content/renderer/indexed_db/webidbcursor_impl_unittest.cc
[modify] https://crrev.com/5adc578c3fc05b33d92f1a4cc523e330384f297c/third_party/WebKit/Source/bindings/core/v8/serialization/SerializedScriptValueFuzzer.cpp
[modify] https://crrev.com/5adc578c3fc05b33d92f1a4cc523e330384f297c/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp
[modify] https://crrev.com/5adc578c3fc05b33d92f1a4cc523e330384f297c/third_party/WebKit/Source/modules/indexeddb/IDBValueWrapping.cpp
[modify] https://crrev.com/5adc578c3fc05b33d92f1a4cc523e330384f297c/third_party/WebKit/Source/platform/exported/WebBlobInfo.cpp
[modify] https://crrev.com/5adc578c3fc05b33d92f1a4cc523e330384f297c/third_party/WebKit/public/platform/WebBlobInfo.h

Comment 6 by dxie@chromium.org, May 17 2018

Labels: -Pri-3 Proj-Servicification-Canary OS-All Pri-1

Comment 7 by dxie@chromium.org, May 18 2018

Labels: -OS-All OS-Windows OS-Linux OS-Mac OS-Chrome OS-Android

Comment 8 by dxie@google.com, May 23 2018

Owner: ----

Comment 9 by mek@chromium.org, Jun 27 2018

Components: -Internals>Services>Network
Labels: -Pri-1 -Proj-Servicification-Canary Pri-2
This isn't anything that should be blocking anything. Things work okay today, any more work here is just for code clarity/to avoid any potential edge case race conditions that have existed for decades anyway.
Components: -Internals>Services>Storage Internals>Storage
The Storage team monitors Internals>Storage. The Internals>Services>Storage label will be deprecated & removed.

Sign in to add a comment