[mojo-blobs] Make sure WebBlobInfo always has a BlobDataHandle associated with it |
||||||||
Issue descriptionThis will require auditing all places a WebBlobInfo is created and making sure a mojo pipe or BlobDataHandle is passed in.
,
Nov 7 2017
Apologies, applied the wrong component in bulk.
,
Nov 8 2017
Setting Internals>Services>Storage to all children of issue 611935
,
Jan 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4e2d638a9059794d68df60f6f7559f1ad141ccf commit f4e2d638a9059794d68df60f6f7559f1ad141ccf Author: Marijn Kruisselbrink <mek@chromium.org> Date: Fri Jan 26 19:44:30 2018 Take advantage of mojo blobs for lifetime management in clipboard code. Bug: 604800 , 769024, 740744 Change-Id: I2267b1015e3c9ad0d3dfe019572ff328557e0112 Reviewed-on: https://chromium-review.googlesource.com/882483 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#532042} [modify] https://crrev.com/f4e2d638a9059794d68df60f6f7559f1ad141ccf/content/browser/blob_storage/chrome_blob_storage_context.cc [modify] https://crrev.com/f4e2d638a9059794d68df60f6f7559f1ad141ccf/content/browser/renderer_host/clipboard_host_impl.cc [modify] https://crrev.com/f4e2d638a9059794d68df60f6f7559f1ad141ccf/content/public/browser/blob_handle.h [modify] https://crrev.com/f4e2d638a9059794d68df60f6f7559f1ad141ccf/third_party/WebKit/Source/core/clipboard/DataObjectItem.cpp [modify] https://crrev.com/f4e2d638a9059794d68df60f6f7559f1ad141ccf/third_party/WebKit/Source/platform/exported/WebClipboardImpl.cpp [modify] https://crrev.com/f4e2d638a9059794d68df60f6f7559f1ad141ccf/third_party/WebKit/common/blob/blob.mojom [modify] https://crrev.com/f4e2d638a9059794d68df60f6f7559f1ad141ccf/third_party/WebKit/common/clipboard/clipboard.mojom [modify] https://crrev.com/f4e2d638a9059794d68df60f6f7559f1ad141ccf/third_party/WebKit/common/message_port/message_port.mojom
,
Jan 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5adc578c3fc05b33d92f1a4cc523e330384f297c commit 5adc578c3fc05b33d92f1a4cc523e330384f297c Author: Marijn Kruisselbrink <mek@chromium.org> Date: Sat Jan 27 03:43:20 2018 Cleanup deprecated and unused WebBlobInfo constructors. Also remove last usage of these deprecated constructors (mostly in tests, where just passing a dangling mojo message pipe works fine). Bug: 769024 Change-Id: I38b390e64552abc971035eec97d090a85ec701f9 Reviewed-on: https://chromium-review.googlesource.com/883570 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Chris Mumford <cmumford@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#532147} [modify] https://crrev.com/5adc578c3fc05b33d92f1a4cc523e330384f297c/content/renderer/indexed_db/webidbcursor_impl_unittest.cc [modify] https://crrev.com/5adc578c3fc05b33d92f1a4cc523e330384f297c/third_party/WebKit/Source/bindings/core/v8/serialization/SerializedScriptValueFuzzer.cpp [modify] https://crrev.com/5adc578c3fc05b33d92f1a4cc523e330384f297c/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp [modify] https://crrev.com/5adc578c3fc05b33d92f1a4cc523e330384f297c/third_party/WebKit/Source/modules/indexeddb/IDBValueWrapping.cpp [modify] https://crrev.com/5adc578c3fc05b33d92f1a4cc523e330384f297c/third_party/WebKit/Source/platform/exported/WebBlobInfo.cpp [modify] https://crrev.com/5adc578c3fc05b33d92f1a4cc523e330384f297c/third_party/WebKit/public/platform/WebBlobInfo.h
,
May 17 2018
,
May 18 2018
,
May 23 2018
,
Jun 27 2018
This isn't anything that should be blocking anything. Things work okay today, any more work here is just for code clarity/to avoid any potential edge case race conditions that have existed for decades anyway.
,
Jan 7
The Storage team monitors Internals>Storage. The Internals>Services>Storage label will be deprecated & removed. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by laforge@google.com
, Nov 7 2017