Issue metadata
Sign in to add a comment
|
Tapping on “Show full history” does nothing. |
||||||||||||||||||||||
Issue descriptionApp Version: 62.0.3202.35Beta iOS Version: 10.3.3, 11.0 Device: iPhone Precondition: Have few websites that are closed in recent tabs under Recently closed section. Steps to reproduce: 1. Launch chrome and go to recent tabs 2. Tap on “Show full history” under Recently closed. Observed results: Nothing happens. Expected results: “Show full history” should be shown and when tapped on, user should be taken to the history screen. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Not tested Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): No-M61 Bug reproducible on the current beta channel build (App Version, iOS Version): Yes on M62 Type-bug-regression? Yes Video: https://drive.google.com/a/google.com/file/d/0B6GVWQnhaMClNm1NWXJ3OWZWY2c/view?usp=sharing
,
Sep 28 2017
Assigned to sdefresne@, as I am OOO and this is quite urgent. It seems the showFullHistory of recent_tabs_table_view_controller.mm doesn't work on both iPhone and iPad.
,
Sep 28 2017
Probably related to my refactoring. Taking this.
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/475a3ee1523ac83f68f4ac828f9f44c673a97dc3 commit 475a3ee1523ac83f68f4ac828f9f44c673a97dc3 Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Sep 28 12:00:07 2017 Fix "Open History" from Recent Tabs The completion block to open the history wasn't used in the completion block of the dismiss animation of the Recent Tabs. This CL fixes it. Bug: 769022 Change-Id: I0a5c73d02903dc68aba47115dea6880c5027ae86 Reviewed-on: https://chromium-review.googlesource.com/689834 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#504972} [modify] https://crrev.com/475a3ee1523ac83f68f4ac828f9f44c673a97dc3/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_handset_coordinator.mm [modify] https://crrev.com/475a3ee1523ac83f68f4ac828f9f44c673a97dc3/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_handset_view_controller.h [modify] https://crrev.com/475a3ee1523ac83f68f4ac828f9f44c673a97dc3/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_handset_view_controller.mm [modify] https://crrev.com/475a3ee1523ac83f68f4ac828f9f44c673a97dc3/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_view_controller.mm [modify] https://crrev.com/475a3ee1523ac83f68f4ac828f9f44c673a97dc3/ios/clean/chrome/browser/ui/recent_tabs/recent_tabs_coordinator.mm
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73a78de7587cecbed03c6b2fa884cad03553f014 commit 73a78de7587cecbed03c6b2fa884cad03553f014 Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Sep 28 12:32:19 2017 Add EG test for opening History from Recent Tabs Add test to prevent regression. Bug: 769022 Change-Id: I3cdb9bb1d6ec4d4daa2842fbf50a828c1aafd815 Reviewed-on: https://chromium-review.googlesource.com/689518 Reviewed-by: Jean-François Geyelin <jif@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#504976} [modify] https://crrev.com/73a78de7587cecbed03c6b2fa884cad03553f014/ios/chrome/browser/ui/ntp/recent_tabs/BUILD.gn [modify] https://crrev.com/73a78de7587cecbed03c6b2fa884cad03553f014/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_egtest.mm [modify] https://crrev.com/73a78de7587cecbed03c6b2fa884cad03553f014/ios/chrome/browser/ui/ntp/recent_tabs/views/show_full_history_view.mm
,
Sep 28 2017
Merge request for https://chromium-review.googlesource.com/689834. https://chromium-review.googlesource.com/689518 is adding test, no need to merge.
,
Sep 28 2017
,
Sep 28 2017
This bug requires manual review: Less than 15 days to go before AppStore submit on M62 Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 29 2017
Verified on 63.0.3227.0 Canary on iOS 11.0 iPhone 7+, iPhone 6+ iOS 10.3.3, iPad Pro 12'5 iOS 11.0, iPad Pro 12'5 iOS 10.3.3 "Show full history" screen shows up when tapped on it in Recent tabs, when Signed into chrome also when not signed into chrome.
,
Sep 29 2017
Thanks for writing that EG test!
,
Sep 29 2017
,
Oct 3 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 6 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 13 2017
This M62 RBS was never merged. cmasso @PTAL
,
Oct 13 2017
Tested on 62.0.3202.56 beta in iPhone 7+ iOS 10.3.3.Its still reproducible. As per #14 , this needs to be merged.
,
Oct 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e36cc1ec04b76895a1c9dc2b1454d1ced100620d commit e36cc1ec04b76895a1c9dc2b1454d1ced100620d Author: Gauthier Ambard <gambard@chromium.org> Date: Mon Oct 16 16:26:20 2017 Fix "Open History" from Recent Tabs The completion block to open the history wasn't used in the completion block of the dismiss animation of the Recent Tabs. This CL fixes it. Bug: 769022 Change-Id: I0a5c73d02903dc68aba47115dea6880c5027ae86 Reviewed-on: https://chromium-review.googlesource.com/689834 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#504972} Reviewed-on: https://chromium-review.googlesource.com/721542 Reviewed-by: Jean-François Geyelin <jif@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#691} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/e36cc1ec04b76895a1c9dc2b1454d1ced100620d/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_handset_coordinator.mm [modify] https://crrev.com/e36cc1ec04b76895a1c9dc2b1454d1ced100620d/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_handset_view_controller.h [modify] https://crrev.com/e36cc1ec04b76895a1c9dc2b1454d1ced100620d/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_handset_view_controller.mm [modify] https://crrev.com/e36cc1ec04b76895a1c9dc2b1454d1ced100620d/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_view_controller.mm
,
Oct 16 2017
Verified on 62.0.3202.60 beta on iOS 11.0 iPhone 7+, iOS 10.3.3 iPhone 6+ , iPad Pro 12'5 iOS 11.0, iPad Pro 12'5 iOS 10.3.3 "Show full history" screen shows up when tapped on it in Recent tabs, when Signed into chrome also when not signed into chrome. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sczs@chromium.org
, Sep 27 2017Labels: ReleaseBlock-Stable M-62
Owner: martiw@chromium.org
Status: Assigned (was: Untriaged)