New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 769007 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocking:
issue 667534
issue 767895
issue 768430



Sign in to add a comment

Collect and surface tsmon metrics about found culprits.

Project Member Reported by robert...@chromium.org, Sep 26 2017

Issue description

This metric should count how many culprits are found and also tag the datapoints with the following information:
 - the type of the analysis associated (compile/test/flake)
 - whether a revert was created for the culprit
 - whether a revert was auto-committed for the culprit
 
Status: Started (was: Assigned)
Blocking: 768430
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/7148c056fc1d31bf1e31868d628314e4d8f04e92

commit 7148c056fc1d31bf1e31868d628314e4d8f04e92
Author: Roberto Carrillo <robertocn@google.com>
Date: Tue Oct 03 01:18:36 2017

[Findit] Collect metrics on culprits found and actions taken.

This metric of most importance as we launch the auto-commit feature.

At the moment, only the waterfall cases are covered, but flake will be
covered by an upcoming CL

R=chanli,stgao,lijeffrey,wylieb
BUG= 769007 

Change-Id: I64723d508936a88b70fcbe68d75817810024736a
Reviewed-on: https://chromium-review.googlesource.com/685981
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/7148c056fc1d31bf1e31868d628314e4d8f04e92/appengine/findit/services/revert.py
[modify] https://crrev.com/7148c056fc1d31bf1e31868d628314e4d8f04e92/appengine/findit/services/test/revert_test.py
[modify] https://crrev.com/7148c056fc1d31bf1e31868d628314e4d8f04e92/appengine/findit/waterfall/revert_and_notify_culprit_pipeline.py
[modify] https://crrev.com/7148c056fc1d31bf1e31868d628314e4d8f04e92/appengine/findit/waterfall/monitoring.py

Status: Fixed (was: Started)

Sign in to add a comment