New issue
Advanced search Search tips

Issue 769005 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-XR

Blocked on:
issue 767589
issue 767603



Sign in to add a comment

VR: Remove workarounds for Samsung S8/S8+ density change issues.

Project Member Reported by mthiesse@chromium.org, Sep 26 2017

Issue description

Once b/66493165 and b/66434166 are fixed, we can remove the hacky workarounds for  issue 767603  and  issue 767589 
 
Blockedon: 767589 767603
Labels: -M-54 M-64
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/010dce344ac088903a108aeec3ad27b2587fdca3

commit 010dce344ac088903a108aeec3ad27b2587fdca3
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Fri Nov 17 17:52:54 2017

Remove workaround for GVR UI not updating when S8 resolution changes.

The GVR bugs have been fixed, we can remove our workaround.

Workaround was added in
https://chromium-review.googlesource.com/c/chromium/src/+/682107

Bug:  769005 
Change-Id: I2ff8edc388de04fa2c4f662406ab7687c13eb88e
Reviewed-on: https://chromium-review.googlesource.com/775864
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517461}
[modify] https://crrev.com/010dce344ac088903a108aeec3ad27b2587fdca3/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java
[modify] https://crrev.com/010dce344ac088903a108aeec3ad27b2587fdca3/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/010dce344ac088903a108aeec3ad27b2587fdca3/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

Status: Fixed (was: ExternalDependency)
Components: Internals>XR

Sign in to add a comment