New issue
Advanced search Search tips

Issue 768986 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Add UMA metrics for PDF file features

Project Member Reported by hnakashima@chromium.org, Sep 26 2017

Issue description

Gather statistics for what percentage of PDF documents viewed have the following characteristics:

- Linearized
- AcroForm
- XFA Form
- Bookmarks
- Tagged
- Attachments
- Annotations
 
Status: Started (was: Available)
Also get metrics for other basic document information, like # of pages.
For XFA, it is going to be a bit of work to get information we want, since how you identify XFA in a PDF is kinda poorly specified.  Specifically it is supposed to be some combination of PDF version and Adobe Extension number and possibly NeedsRendering being set, but I am not sure how strictly that is followed in the wild. Additionally information like is this a static or dynamic form, requires inspection of the XML. Most likely the XFA UMA metrics will need to be broken off into their own bug that I work on.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 16 2017

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/077f6439954cdbb5061a78b59be95ebf2277ac26

commit 077f6439954cdbb5061a78b59be95ebf2277ac26
Author: Henrique Nakashima <hnakashima@chromium.org>
Date: Mon Oct 16 17:46:49 2017

Add FPDFCatalog_IsTagged to public API.

The new fpdf_catalog.h will contains functions to access entries in
the catalog (root) dict in a PDF.

Bug:  chromium:768986 
Change-Id: I6e1d4a479d6f8742981e89f07bab98ee96dc3763
Reviewed-on: https://pdfium-review.googlesource.com/15970
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>

[modify] https://crrev.com/077f6439954cdbb5061a78b59be95ebf2277ac26/BUILD.gn
[add] https://crrev.com/077f6439954cdbb5061a78b59be95ebf2277ac26/fpdfsdk/fpdfcatalog_unittest.cpp
[modify] https://crrev.com/077f6439954cdbb5061a78b59be95ebf2277ac26/fpdfsdk/fpdfview_c_api_test.c
[add] https://crrev.com/077f6439954cdbb5061a78b59be95ebf2277ac26/fpdfsdk/fpdfcatalog.cpp
[add] https://crrev.com/077f6439954cdbb5061a78b59be95ebf2277ac26/public/fpdf_catalog.h

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f14fd489cfd7390760a0fa84d896d427d5b95617

commit f14fd489cfd7390760a0fa84d896d427d5b95617
Author: Henrique Nakashima <hnakashima@chromium.org>
Date: Mon Oct 16 18:29:01 2017

Pass DocumentFeatures to OutOfProcessInstance to log PDF features.

DocumentFeatures is a struct that contains PDF document features we
are interested in counting.

I'll be adding fields to this struct in the next CLs.

Bug:  chromium:768986 
Change-Id: I5821debbdfeb0df58e0b121d45baabe01da474bd
Reviewed-on: https://chromium-review.googlesource.com/713741
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509113}
[modify] https://crrev.com/f14fd489cfd7390760a0fa84d896d427d5b95617/pdf/out_of_process_instance.cc
[modify] https://crrev.com/f14fd489cfd7390760a0fa84d896d427d5b95617/pdf/out_of_process_instance.h
[modify] https://crrev.com/f14fd489cfd7390760a0fa84d896d427d5b95617/pdf/pdf_engine.h
[modify] https://crrev.com/f14fd489cfd7390760a0fa84d896d427d5b95617/pdf/pdfium/pdfium_engine.cc
[modify] https://crrev.com/f14fd489cfd7390760a0fa84d896d427d5b95617/pdf/preview_mode_client.cc
[modify] https://crrev.com/f14fd489cfd7390760a0fa84d896d427d5b95617/pdf/preview_mode_client.h

Cc: rharrison@chromium.org
 Issue 775519  has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe4d6ac310a044bb1eb4184fdca2a9201eb8d376

commit fe4d6ac310a044bb1eb4184fdca2a9201eb8d376
Author: Henrique Nakashima <hnakashima@chromium.org>
Date: Wed Oct 18 20:43:13 2017

Measure % of PDFs with attachments and % of PDFs that are linearized.

Bug:  chromium:768986 
Change-Id: I255fb808efd17a48d9e3760f2d3ed3317196a2bc
Reviewed-on: https://chromium-review.googlesource.com/716306
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509861}
[modify] https://crrev.com/fe4d6ac310a044bb1eb4184fdca2a9201eb8d376/pdf/out_of_process_instance.cc
[modify] https://crrev.com/fe4d6ac310a044bb1eb4184fdca2a9201eb8d376/pdf/pdf_engine.h
[modify] https://crrev.com/fe4d6ac310a044bb1eb4184fdca2a9201eb8d376/pdf/pdfium/pdfium_engine.cc
[modify] https://crrev.com/fe4d6ac310a044bb1eb4184fdca2a9201eb8d376/tools/metrics/histograms/histograms.xml

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ff80aa9782207becb77e1034a6f1ee119919bbd

commit 4ff80aa9782207becb77e1034a6f1ee119919bbd
Author: Henrique Nakashima <hnakashima@chromium.org>
Date: Wed Oct 18 23:32:47 2017

Add PDF.PageCount to histograms.xml.

This metric is already logged but was never added to histograms.xml.

Bug:  chromium:768986 
Change-Id: I77322aa2e4a71469c45a32bb1cc88aac9f42c7db
Reviewed-on: https://chromium-review.googlesource.com/714125
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509924}
[modify] https://crrev.com/4ff80aa9782207becb77e1034a6f1ee119919bbd/tools/metrics/histograms/histograms.xml

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 21 2017

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/0e568818249ff83d239b98cbb32dec94358da0c7

commit 0e568818249ff83d239b98cbb32dec94358da0c7
Author: Ryan Harrison <rharrison@chromium.org>
Date: Sat Oct 21 06:17:49 2017

Add in count value for form types

BUG= chromium:775519 , chromium:768986 

Adding metric form types

Change-Id: Ic99a5ac988998986f06cb79d08458afeda49a5d1
Reviewed-on: https://pdfium-review.googlesource.com/16392
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>

[modify] https://crrev.com/0e568818249ff83d239b98cbb32dec94358da0c7/xfa/fxfa/fxfa.h
[modify] https://crrev.com/0e568818249ff83d239b98cbb32dec94358da0c7/public/fpdf_formfill.h

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f356d15100553db7552f7e7906a88d13030d2976

commit f356d15100553db7552f7e7906a88d13030d2976
Author: pdfium-deps-roller@chromium.org <pdfium-deps-roller@chromium.org>
Date: Sat Oct 21 09:38:43 2017

Roll src/third_party/pdfium/ d78ef3b7c..0e5688182 (1 commit)

https://pdfium.googlesource.com/pdfium.git/+log/d78ef3b7c943..0e568818249f

$ git log d78ef3b7c..0e5688182 --date=short --no-merges --format='%ad %ae %s'
2017-10-21 rharrison Add in count value for form types

Created with:
  roll-dep src/third_party/pdfium
BUG= 775519 , 768986 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I446b059876fac382f6dc439fdfa35312456abf41
Reviewed-on: https://chromium-review.googlesource.com/732149
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510676}
[modify] https://crrev.com/f356d15100553db7552f7e7906a88d13030d2976/DEPS

Project Member

Comment 12 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c9aa01842b041e38243a51e09d446274c7b5297

commit 6c9aa01842b041e38243a51e09d446274c7b5297
Author: Henrique Nakashima <hnakashima@chromium.org>
Date: Wed Nov 22 22:18:10 2017

Count annotation subtypes that appear in PDF documents.

Bug:  chromium:768986 
Change-Id: I25fcf447501224d02be40565c8ec770a06edd2e6
Reviewed-on: https://chromium-review.googlesource.com/740141
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518771}
[modify] https://crrev.com/6c9aa01842b041e38243a51e09d446274c7b5297/pdf/BUILD.gn
[modify] https://crrev.com/6c9aa01842b041e38243a51e09d446274c7b5297/pdf/out_of_process_instance.cc
[modify] https://crrev.com/6c9aa01842b041e38243a51e09d446274c7b5297/pdf/out_of_process_instance.h
[add] https://crrev.com/6c9aa01842b041e38243a51e09d446274c7b5297/pdf/pdf_engine.cc
[modify] https://crrev.com/6c9aa01842b041e38243a51e09d446274c7b5297/pdf/pdf_engine.h
[modify] https://crrev.com/6c9aa01842b041e38243a51e09d446274c7b5297/pdf/pdfium/pdfium_engine.cc
[modify] https://crrev.com/6c9aa01842b041e38243a51e09d446274c7b5297/pdf/pdfium/pdfium_page.cc
[modify] https://crrev.com/6c9aa01842b041e38243a51e09d446274c7b5297/pdf/pdfium/pdfium_page.h
[modify] https://crrev.com/6c9aa01842b041e38243a51e09d446274c7b5297/pdf/preview_mode_client.cc
[modify] https://crrev.com/6c9aa01842b041e38243a51e09d446274c7b5297/pdf/preview_mode_client.h
[modify] https://crrev.com/6c9aa01842b041e38243a51e09d446274c7b5297/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/6c9aa01842b041e38243a51e09d446274c7b5297/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)
Project Member

Comment 14 by bugdroid1@chromium.org, Nov 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/112d7b025fc05fe5a7f6e00c2f0a6717dbe91976

commit 112d7b025fc05fe5a7f6e00c2f0a6717dbe91976
Author: Sigurður Ásgeirsson <siggi@chromium.org>
Date: Thu Nov 23 14:23:54 2017

Revert "Count annotation subtypes that appear in PDF documents."

This reverts commit 6c9aa01842b041e38243a51e09d446274c7b5297.

Reason for revert: breaks chromium.lkgr Win_SyzyASAN_LKG build

Bug:  788176 

Original change's description:
> Count annotation subtypes that appear in PDF documents.
> 
> Bug:  chromium:768986 
> Change-Id: I25fcf447501224d02be40565c8ec770a06edd2e6
> Reviewed-on: https://chromium-review.googlesource.com/740141
> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
> Reviewed-by: dsinclair <dsinclair@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#518771}

TBR=dsinclair@chromium.org,isherman@chromium.org,hnakashima@chromium.org

Change-Id: I05c59dcd9488428bf8182216bb81aac8c667ea4e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromium:768986 
Reviewed-on: https://chromium-review.googlesource.com/788030
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518929}
[modify] https://crrev.com/112d7b025fc05fe5a7f6e00c2f0a6717dbe91976/pdf/BUILD.gn
[modify] https://crrev.com/112d7b025fc05fe5a7f6e00c2f0a6717dbe91976/pdf/out_of_process_instance.cc
[modify] https://crrev.com/112d7b025fc05fe5a7f6e00c2f0a6717dbe91976/pdf/out_of_process_instance.h
[delete] https://crrev.com/57b2dc23b962feeadd2dcf60a399c9f38d2087e3/pdf/pdf_engine.cc
[modify] https://crrev.com/112d7b025fc05fe5a7f6e00c2f0a6717dbe91976/pdf/pdf_engine.h
[modify] https://crrev.com/112d7b025fc05fe5a7f6e00c2f0a6717dbe91976/pdf/pdfium/pdfium_engine.cc
[modify] https://crrev.com/112d7b025fc05fe5a7f6e00c2f0a6717dbe91976/pdf/pdfium/pdfium_page.cc
[modify] https://crrev.com/112d7b025fc05fe5a7f6e00c2f0a6717dbe91976/pdf/pdfium/pdfium_page.h
[modify] https://crrev.com/112d7b025fc05fe5a7f6e00c2f0a6717dbe91976/pdf/preview_mode_client.cc
[modify] https://crrev.com/112d7b025fc05fe5a7f6e00c2f0a6717dbe91976/pdf/preview_mode_client.h
[modify] https://crrev.com/112d7b025fc05fe5a7f6e00c2f0a6717dbe91976/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/112d7b025fc05fe5a7f6e00c2f0a6717dbe91976/tools/metrics/histograms/histograms.xml

Project Member

Comment 15 by bugdroid1@chromium.org, Nov 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd7edf2acda4e3a7bc921de6aca3fcbb3599349b

commit fd7edf2acda4e3a7bc921de6aca3fcbb3599349b
Author: Henrique Nakashima <hnakashima@chromium.org>
Date: Wed Nov 29 22:03:49 2017

Reland "Count annotation subtypes that appear in PDF documents."

Original: https://chromium-review.googlesource.com/c/chromium/src/+/740141
Revert: https://chromium-review.googlesource.com/c/chromium/src/+/788030

This reverts commit 112d7b025fc05fe5a7f6e00c2f0a6717dbe91976.

Bug:  768986 , 788176 
TBR: isherman@chromium.org
Change-Id: Ie5c8889f73443b9eefccd803f15cd0c0b1cd1ce9
Reviewed-on: https://chromium-review.googlesource.com/788330
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520262}
[modify] https://crrev.com/fd7edf2acda4e3a7bc921de6aca3fcbb3599349b/pdf/BUILD.gn
[modify] https://crrev.com/fd7edf2acda4e3a7bc921de6aca3fcbb3599349b/pdf/out_of_process_instance.cc
[modify] https://crrev.com/fd7edf2acda4e3a7bc921de6aca3fcbb3599349b/pdf/out_of_process_instance.h
[add] https://crrev.com/fd7edf2acda4e3a7bc921de6aca3fcbb3599349b/pdf/pdf_engine.cc
[modify] https://crrev.com/fd7edf2acda4e3a7bc921de6aca3fcbb3599349b/pdf/pdf_engine.h
[modify] https://crrev.com/fd7edf2acda4e3a7bc921de6aca3fcbb3599349b/pdf/pdfium/pdfium_engine.cc
[modify] https://crrev.com/fd7edf2acda4e3a7bc921de6aca3fcbb3599349b/pdf/pdfium/pdfium_page.cc
[modify] https://crrev.com/fd7edf2acda4e3a7bc921de6aca3fcbb3599349b/pdf/pdfium/pdfium_page.h
[modify] https://crrev.com/fd7edf2acda4e3a7bc921de6aca3fcbb3599349b/pdf/preview_mode_client.cc
[modify] https://crrev.com/fd7edf2acda4e3a7bc921de6aca3fcbb3599349b/pdf/preview_mode_client.h
[modify] https://crrev.com/fd7edf2acda4e3a7bc921de6aca3fcbb3599349b/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/fd7edf2acda4e3a7bc921de6aca3fcbb3599349b/tools/metrics/histograms/histograms.xml

Sign in to add a comment