The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/595d6403b2f48c8b2e61500108f8c5a92cd860cc

commit 595d6403b2f48c8b2e61500108f8c5a92cd860cc
Author: Simon Que <sque@chromium.org>
Date: Thu Sep 28 00:52:29 2017

feedbackPrivate: Add rate limiter for log source accesses

This factors out the rate limiting of access to log sources into a
separate module.

In the future, we can update the rate limiting policy by updating only
the rate limiter.

BUG= 768967 

Change-Id: Ic897112ad2adc58adac9e57ed95b424c532ae42e
Reviewed-on: https://chromium-review.googlesource.com/685916
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Simon Que <sque@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504838}
[modify] https://crrev.com/595d6403b2f48c8b2e61500108f8c5a92cd860cc/extensions/browser/BUILD.gn
[modify] https://crrev.com/595d6403b2f48c8b2e61500108f8c5a92cd860cc/extensions/browser/api/feedback_private/BUILD.gn
[add] https://crrev.com/595d6403b2f48c8b2e61500108f8c5a92cd860cc/extensions/browser/api/feedback_private/access_rate_limiter.cc
[add] https://crrev.com/595d6403b2f48c8b2e61500108f8c5a92cd860cc/extensions/browser/api/feedback_private/access_rate_limiter.h
[add] https://crrev.com/595d6403b2f48c8b2e61500108f8c5a92cd860cc/extensions/browser/api/feedback_private/access_rate_limiter_chromeos_unittest.cc
[modify] https://crrev.com/595d6403b2f48c8b2e61500108f8c5a92cd860cc/extensions/browser/api/feedback_private/log_source_access_manager.cc
[modify] https://crrev.com/595d6403b2f48c8b2e61500108f8c5a92cd860cc/extensions/browser/api/feedback_private/log_source_access_manager.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57f07dea9f99e4edbbbd66a8b69ab0d6fa3a61b9

commit 57f07dea9f99e4edbbbd66a8b69ab0d6fa3a61b9
Author: Simon Que <sque@chromium.org>
Date: Fri Oct 13 12:28:24 2017

feedbackPrivate: Allow multiple handles to a log source from an extension

Remove the rule that there can be only one source reader handle opened from a particular extension.

There will still be rate limiting mechanisms in place:
- 1 second between reads from one reader handle
- max of 10 open readers per source, regardless of extension.

BUG= 768967 

Change-Id: I00cb6af27e8a9bdb4da68e015e65fd7ca3c5422b
Reviewed-on: https://chromium-review.googlesource.com/685577
Commit-Queue: Simon Que <sque@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508677}
[modify] https://crrev.com/57f07dea9f99e4edbbbd66a8b69ab0d6fa3a61b9/extensions/browser/api/feedback_private/feedback_private_api_chromeos_unittest.cc
[modify] https://crrev.com/57f07dea9f99e4edbbbd66a8b69ab0d6fa3a61b9/extensions/browser/api/feedback_private/log_source_access_manager.cc
[modify] https://crrev.com/57f07dea9f99e4edbbbd66a8b69ab0d6fa3a61b9/extensions/browser/api/feedback_private/log_source_access_manager.h
[modify] https://crrev.com/57f07dea9f99e4edbbbd66a8b69ab0d6fa3a61b9/extensions/browser/api/feedback_private/log_source_access_manager_chromeos_unittest.cc
[modify] https://crrev.com/57f07dea9f99e4edbbbd66a8b69ab0d6fa3a61b9/extensions/browser/api/feedback_private/log_source_resource.cc
[modify] https://crrev.com/57f07dea9f99e4edbbbd66a8b69ab0d6fa3a61b9/extensions/browser/api/feedback_private/log_source_resource.h

This bug requires manual review: We are only 3 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

This seems like a lot of stuff for late stable, and this is marked as a feature, what is the rationale for needing this in 62?

This is needed for meeting room configuration detection in Chromebox for Meetings.

Simon, 62 won't be taking merges that aren't critical to Chrome OS users to have. This change does not meet the bar. I would suggest merge requesting 63 instead, which just branched.

Lets just keep this in 63.

Does this need any merges for 63?

Yes

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/219834fc45bd068de92657374840f2c5fdc0b09b

commit 219834fc45bd068de92657374840f2c5fdc0b09b
Author: Simon Que <sque@chromium.org>
Date: Wed Oct 25 15:44:27 2017

feedbackPrivate: Allow multiple handles to a log source from an extension

Remove the rule that there can be only one source reader handle opened from a particular extension.

There will still be rate limiting mechanisms in place:
- 1 second between reads from one reader handle
- max of 10 open readers per source, regardless of extension.

BUG= 768967 

Change-Id: I00cb6af27e8a9bdb4da68e015e65fd7ca3c5422b
Reviewed-on: https://chromium-review.googlesource.com/685577
Commit-Queue: Simon Que <sque@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#508677}(cherry picked from commit 57f07dea9f99e4edbbbd66a8b69ab0d6fa3a61b9)
Reviewed-on: https://chromium-review.googlesource.com/738389
Reviewed-by: Simon Que <sque@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#217}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/219834fc45bd068de92657374840f2c5fdc0b09b/extensions/browser/api/feedback_private/feedback_private_api_chromeos_unittest.cc
[modify] https://crrev.com/219834fc45bd068de92657374840f2c5fdc0b09b/extensions/browser/api/feedback_private/log_source_access_manager.cc
[modify] https://crrev.com/219834fc45bd068de92657374840f2c5fdc0b09b/extensions/browser/api/feedback_private/log_source_access_manager.h
[modify] https://crrev.com/219834fc45bd068de92657374840f2c5fdc0b09b/extensions/browser/api/feedback_private/log_source_access_manager_chromeos_unittest.cc
[modify] https://crrev.com/219834fc45bd068de92657374840f2c5fdc0b09b/extensions/browser/api/feedback_private/log_source_resource.cc
[modify] https://crrev.com/219834fc45bd068de92657374840f2c5fdc0b09b/extensions/browser/api/feedback_private/log_source_resource.h