Autofill: Local credit card saving dialog has a G logo |
|||||||||
Issue descriptionThe dialog to save a credit card locally has a G icon due to a bug. To trigger this, you also need the chrome://flags/#enable-autofill-credit-card-upload-google-logo flag enabled. Expected: We shouldn't have this icon for the local save scenario.
,
Sep 26 2017
Trouble with file picker, here is the link: https://drive.google.com/a/google.com/file/d/0B2StZLxoPfNzUjRLWjlhMXNVYjQ/view?usp=sharing
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d632f9cca131c286682e70b544319b52318479c commit 5d632f9cca131c286682e70b544319b52318479c Author: Mathieu Perreault <mathp@chromium.org> Date: Thu Sep 28 00:37:09 2017 [Autofill] Credit card local save dialog shouldn't have window icon Previously, all card save dialogs under the new UI would have the logo. The logo should only apply to server card uploads, not local saves. Bug: 736944 , 768951 Change-Id: I7b5a8845f66e808cba13e2822c6dd8ed50995056 Reviewed-on: https://chromium-review.googlesource.com/685503 Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#504817} [modify] https://crrev.com/5d632f9cca131c286682e70b544319b52318479c/chrome/browser/ui/views/autofill/save_card_bubble_views.cc
,
Sep 28 2017
Verified the issue on windows 7 , ubuntu 14.04 and mac os 10.12.6 using chrome M63 #63.0.3226.0 and issue seems fixed. Google logo is not seen on locally saved credit card alert. Attached screenshot for reference. Adding TE-Verified labels. Thanks!
,
Sep 28 2017
Would like to merge to M62. It's a bad regression, and the fix is simple. Thanks
,
Sep 28 2017
,
Sep 29 2017
This bug requires manual review: M62 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 29 2017
Approving merge to M62. Branch:3202
,
Sep 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/43a90c557dda01865ef1108fe3d836d8f2fc0929 commit 43a90c557dda01865ef1108fe3d836d8f2fc0929 Author: Mathieu Perreault <mathp@chromium.org> Date: Fri Sep 29 20:37:01 2017 [Autofill] Credit card local save dialog shouldn't have window icon Previously, all card save dialogs under the new UI would have the logo. The logo should only apply to server card uploads, not local saves. TBR=mathp@chromium.org (cherry picked from commit 5d632f9cca131c286682e70b544319b52318479c) Bug: 736944 , 768951 Change-Id: I7b5a8845f66e808cba13e2822c6dd8ed50995056 Reviewed-on: https://chromium-review.googlesource.com/685503 Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#504817} Reviewed-on: https://chromium-review.googlesource.com/692700 Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#520} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/43a90c557dda01865ef1108fe3d836d8f2fc0929/chrome/browser/ui/views/autofill/save_card_bubble_views.cc
,
Oct 4 2017
Verified the issue on windows 7 , ubuntu 14.04 and mac os 10.12.6 using chrome M62 #62.0.3202.45 and issue seems fixed. Google logo is not seen on locally saved credit card alert. Adding TE-Verified labels. Thanks!
,
Oct 16 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by ma...@chromium.org
, Sep 26 2017