New issue
Advanced search Search tips

Issue 768941 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug


Participants' hotlists:
Payments-TechDebt


Sign in to add a comment

Improvements to item ownership in PaymentRequestItemList

Project Member Reported by tmartino@chromium.org, Sep 26 2017

Issue description

Currently, PaymentRequestItemList holds a vector of unique_ptrs to the items being listed. This is a problem, since we track the currently-selected item with a raw pointer which could be stale. This was the cause of http://www. crbug.com/749815 , a crasher.

We should change this to use shared_ptr for the vector and weak_ptr for selected_item.
 
Status: Started (was: Untriaged)
Going to knock this one out real quick

Sign in to add a comment