Related to the refactoring in issue 752193 . So that we can move the device/vr implementation out of the browser process and stick a mojo binding in between chrome/browser and device/vr we need to move the vr service binding and access restriction into chrome/browser. One-pager: https://docs.google.com/document/d/1QsNTCwKD1OOzOgYwWal5NrkO-Rw3uMlJfyjKIBoEPWI/edit
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4fc0d30f88bdaa6a77dd854bbb5b0b23b7a6386 commit f4fc0d30f88bdaa6a77dd854bbb5b0b23b7a6386 Author: Michael Thiessen <mthiesse@chromium.org> Date: Mon Oct 02 19:20:09 2017 Refactor vr service bindings to decouple the binding from device/vr Allows chrome/browser to control where the vr service is bound to, in preparation for moving VrServiceImpl into chrome/browser. Apparently this also removes the gvr static initializers... Bug: 768923 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I239cf6e167b62becf3c357cdffc8c8fd0a92e7e6 Reviewed-on: https://chromium-review.googlesource.com/685265 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#505711} [modify] https://crrev.com/f4fc0d30f88bdaa6a77dd854bbb5b0b23b7a6386/chrome/android/BUILD.gn [modify] https://crrev.com/f4fc0d30f88bdaa6a77dd854bbb5b0b23b7a6386/chrome/android/static_initializers.gni [modify] https://crrev.com/f4fc0d30f88bdaa6a77dd854bbb5b0b23b7a6386/chrome/browser/android/vr_shell/vr_shell_delegate.cc [modify] https://crrev.com/f4fc0d30f88bdaa6a77dd854bbb5b0b23b7a6386/content/browser/BUILD.gn [modify] https://crrev.com/f4fc0d30f88bdaa6a77dd854bbb5b0b23b7a6386/content/browser/frame_host/render_frame_host_impl.cc [modify] https://crrev.com/f4fc0d30f88bdaa6a77dd854bbb5b0b23b7a6386/content/public/android/BUILD.gn [modify] https://crrev.com/f4fc0d30f88bdaa6a77dd854bbb5b0b23b7a6386/content/public/browser/BUILD.gn [add] https://crrev.com/f4fc0d30f88bdaa6a77dd854bbb5b0b23b7a6386/content/public/browser/webvr_service_provider.cc [add] https://crrev.com/f4fc0d30f88bdaa6a77dd854bbb5b0b23b7a6386/content/public/browser/webvr_service_provider.h [modify] https://crrev.com/f4fc0d30f88bdaa6a77dd854bbb5b0b23b7a6386/content/shell/android/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec4faf1be9f86944cbebe7634181057420b37c67 commit ec4faf1be9f86944cbebe7634181057420b37c67 Author: Michael Thiessen <mthiesse@chromium.org> Date: Tue Oct 03 16:55:19 2017 Move VrServiceImpl and VrDeviceManager into chrome/browser/vr This CL moves VrServiceImpl and VrDeviceManager into chrome/browser/vr. No functionality changes yet. This is part of a larger refactoring of focus and device access management into chrome/browser/vr. Bug: 768923 Change-Id: I38085259ccdd2e7d32a022e5a1b35cfa9718dad2 Reviewed-on: https://chromium-review.googlesource.com/688040 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Christopher Grant <cjgrant@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#506071} [modify] https://crrev.com/ec4faf1be9f86944cbebe7634181057420b37c67/chrome/browser/android/vr_shell/vr_shell_delegate.cc [modify] https://crrev.com/ec4faf1be9f86944cbebe7634181057420b37c67/chrome/browser/vr/BUILD.gn [add] https://crrev.com/ec4faf1be9f86944cbebe7634181057420b37c67/chrome/browser/vr/service/DEPS [rename] https://crrev.com/ec4faf1be9f86944cbebe7634181057420b37c67/chrome/browser/vr/service/vr_device_manager.cc [rename] https://crrev.com/ec4faf1be9f86944cbebe7634181057420b37c67/chrome/browser/vr/service/vr_device_manager.h [rename] https://crrev.com/ec4faf1be9f86944cbebe7634181057420b37c67/chrome/browser/vr/service/vr_device_manager_unittest.cc [rename] https://crrev.com/ec4faf1be9f86944cbebe7634181057420b37c67/chrome/browser/vr/service/vr_service_impl.cc [add] https://crrev.com/ec4faf1be9f86944cbebe7634181057420b37c67/chrome/browser/vr/service/vr_service_impl.h [add] https://crrev.com/ec4faf1be9f86944cbebe7634181057420b37c67/chrome/browser/vr/test/DEPS [rename] https://crrev.com/ec4faf1be9f86944cbebe7634181057420b37c67/chrome/browser/vr/test/run_all_unittests.cc [modify] https://crrev.com/ec4faf1be9f86944cbebe7634181057420b37c67/device/BUILD.gn [modify] https://crrev.com/ec4faf1be9f86944cbebe7634181057420b37c67/device/vr/BUILD.gn [modify] https://crrev.com/ec4faf1be9f86944cbebe7634181057420b37c67/device/vr/android/gvr/gvr_delegate_provider.h [modify] https://crrev.com/ec4faf1be9f86944cbebe7634181057420b37c67/device/vr/android/gvr/gvr_device.cc [modify] https://crrev.com/ec4faf1be9f86944cbebe7634181057420b37c67/device/vr/android/gvr/gvr_device.h [modify] https://crrev.com/ec4faf1be9f86944cbebe7634181057420b37c67/device/vr/android/gvr/gvr_device_provider.h [modify] https://crrev.com/ec4faf1be9f86944cbebe7634181057420b37c67/device/vr/test/fake_vr_device.h [modify] https://crrev.com/ec4faf1be9f86944cbebe7634181057420b37c67/device/vr/test/fake_vr_device_provider.h [modify] https://crrev.com/ec4faf1be9f86944cbebe7634181057420b37c67/device/vr/test/fake_vr_service_client.h [modify] https://crrev.com/ec4faf1be9f86944cbebe7634181057420b37c67/device/vr/vr_device.h [modify] https://crrev.com/ec4faf1be9f86944cbebe7634181057420b37c67/device/vr/vr_display_impl.cc [modify] https://crrev.com/ec4faf1be9f86944cbebe7634181057420b37c67/device/vr/vr_display_impl.h [modify] https://crrev.com/ec4faf1be9f86944cbebe7634181057420b37c67/device/vr/vr_display_impl_unittest.cc [delete] https://crrev.com/141f543682c748e5d6e5153dc3040d0eb1e815e2/device/vr/vr_service_impl.h [delete] https://crrev.com/141f543682c748e5d6e5153dc3040d0eb1e815e2/device/vr/vr_service_impl_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee7f9f77ea47f58637665d1a842537b5c78f938d commit ee7f9f77ea47f58637665d1a842537b5c78f938d Author: Michael Thiessen <mthiesse@chromium.org> Date: Tue Oct 03 19:09:57 2017 Remove friend classes from VrDevice and clean up state in VrShellDelegate This cleans up the friend classes from VrDevice and does some related cleanup of state around requesting presentation. No functionality changes. Bug: 768923 Change-Id: Ia559f636b8d95be12c0cb5bdbbda1e53e81207f5 Reviewed-on: https://chromium-review.googlesource.com/691314 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#506133} [modify] https://crrev.com/ee7f9f77ea47f58637665d1a842537b5c78f938d/chrome/browser/android/vr_shell/vr_shell_delegate.cc [modify] https://crrev.com/ee7f9f77ea47f58637665d1a842537b5c78f938d/chrome/browser/android/vr_shell/vr_shell_delegate.h [modify] https://crrev.com/ee7f9f77ea47f58637665d1a842537b5c78f938d/device/vr/android/gvr/gvr_delegate_provider.h [modify] https://crrev.com/ee7f9f77ea47f58637665d1a842537b5c78f938d/device/vr/android/gvr/gvr_device.cc [modify] https://crrev.com/ee7f9f77ea47f58637665d1a842537b5c78f938d/device/vr/android/gvr/gvr_device.h [modify] https://crrev.com/ee7f9f77ea47f58637665d1a842537b5c78f938d/device/vr/openvr/openvr_device.cc [modify] https://crrev.com/ee7f9f77ea47f58637665d1a842537b5c78f938d/device/vr/openvr/openvr_device.h [modify] https://crrev.com/ee7f9f77ea47f58637665d1a842537b5c78f938d/device/vr/test/fake_vr_device.cc [modify] https://crrev.com/ee7f9f77ea47f58637665d1a842537b5c78f938d/device/vr/test/fake_vr_device.h [modify] https://crrev.com/ee7f9f77ea47f58637665d1a842537b5c78f938d/device/vr/vr_device.cc [modify] https://crrev.com/ee7f9f77ea47f58637665d1a842537b5c78f938d/device/vr/vr_device.h [modify] https://crrev.com/ee7f9f77ea47f58637665d1a842537b5c78f938d/device/vr/vr_display_impl.cc [modify] https://crrev.com/ee7f9f77ea47f58637665d1a842537b5c78f938d/device/vr/vr_display_impl.h [modify] https://crrev.com/ee7f9f77ea47f58637665d1a842537b5c78f938d/device/vr/vr_display_impl_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56a2356aa1eedfda927bdde505bd8dce1cb18650 commit 56a2356aa1eedfda927bdde505bd8dce1cb18650 Author: Michael Thiessen <mthiesse@chromium.org> Date: Wed Oct 04 20:41:36 2017 Route WebVR presentation requests through chrome/browser/vr This CL adds a VrDisplayHost with bindings to the renderer to route requests for presentation through the browser. (The next CL will move the focus-checking code from VrShellDelegate into the new VRDisplayHost) Bug: 768923 Change-Id: I88ae9797ebe8cbf182b117c2cd07cf91d8d09361 Reviewed-on: https://chromium-review.googlesource.com/692505 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#506505} [modify] https://crrev.com/56a2356aa1eedfda927bdde505bd8dce1cb18650/chrome/browser/android/vr_shell/vr_shell_delegate.cc [modify] https://crrev.com/56a2356aa1eedfda927bdde505bd8dce1cb18650/chrome/browser/android/vr_shell/vr_shell_delegate.h [modify] https://crrev.com/56a2356aa1eedfda927bdde505bd8dce1cb18650/chrome/browser/vr/BUILD.gn [add] https://crrev.com/56a2356aa1eedfda927bdde505bd8dce1cb18650/chrome/browser/vr/service/vr_display_host.cc [add] https://crrev.com/56a2356aa1eedfda927bdde505bd8dce1cb18650/chrome/browser/vr/service/vr_display_host.h [modify] https://crrev.com/56a2356aa1eedfda927bdde505bd8dce1cb18650/chrome/browser/vr/service/vr_service_impl.cc [modify] https://crrev.com/56a2356aa1eedfda927bdde505bd8dce1cb18650/chrome/browser/vr/service/vr_service_impl.h [modify] https://crrev.com/56a2356aa1eedfda927bdde505bd8dce1cb18650/device/vr/android/gvr/gvr_delegate_provider.h [modify] https://crrev.com/56a2356aa1eedfda927bdde505bd8dce1cb18650/device/vr/android/gvr/gvr_device.cc [modify] https://crrev.com/56a2356aa1eedfda927bdde505bd8dce1cb18650/device/vr/android/gvr/gvr_device.h [modify] https://crrev.com/56a2356aa1eedfda927bdde505bd8dce1cb18650/device/vr/openvr/openvr_device.cc [modify] https://crrev.com/56a2356aa1eedfda927bdde505bd8dce1cb18650/device/vr/openvr/openvr_device.h [modify] https://crrev.com/56a2356aa1eedfda927bdde505bd8dce1cb18650/device/vr/test/fake_vr_device.cc [modify] https://crrev.com/56a2356aa1eedfda927bdde505bd8dce1cb18650/device/vr/test/fake_vr_device.h [modify] https://crrev.com/56a2356aa1eedfda927bdde505bd8dce1cb18650/device/vr/test/fake_vr_service_client.cc [modify] https://crrev.com/56a2356aa1eedfda927bdde505bd8dce1cb18650/device/vr/test/fake_vr_service_client.h [modify] https://crrev.com/56a2356aa1eedfda927bdde505bd8dce1cb18650/device/vr/vr_device.h [modify] https://crrev.com/56a2356aa1eedfda927bdde505bd8dce1cb18650/device/vr/vr_display_impl.cc [modify] https://crrev.com/56a2356aa1eedfda927bdde505bd8dce1cb18650/device/vr/vr_display_impl.h [modify] https://crrev.com/56a2356aa1eedfda927bdde505bd8dce1cb18650/device/vr/vr_display_impl_unittest.cc [modify] https://crrev.com/56a2356aa1eedfda927bdde505bd8dce1cb18650/device/vr/vr_service.mojom [modify] https://crrev.com/56a2356aa1eedfda927bdde505bd8dce1cb18650/third_party/WebKit/LayoutTests/vr/resources/mock-vr-service.js [modify] https://crrev.com/56a2356aa1eedfda927bdde505bd8dce1cb18650/third_party/WebKit/Source/modules/vr/VRController.cpp [modify] https://crrev.com/56a2356aa1eedfda927bdde505bd8dce1cb18650/third_party/WebKit/Source/modules/vr/VRController.h [modify] https://crrev.com/56a2356aa1eedfda927bdde505bd8dce1cb18650/third_party/WebKit/Source/modules/vr/VRDisplay.cpp [modify] https://crrev.com/56a2356aa1eedfda927bdde505bd8dce1cb18650/third_party/WebKit/Source/modules/vr/VRDisplay.h [modify] https://crrev.com/56a2356aa1eedfda927bdde505bd8dce1cb18650/third_party/WebKit/Source/modules/vr/latest/VR.cpp [modify] https://crrev.com/56a2356aa1eedfda927bdde505bd8dce1cb18650/third_party/WebKit/Source/modules/vr/latest/VR.h [modify] https://crrev.com/56a2356aa1eedfda927bdde505bd8dce1cb18650/third_party/WebKit/Source/modules/vr/latest/VRDevice.cpp [modify] https://crrev.com/56a2356aa1eedfda927bdde505bd8dce1cb18650/third_party/WebKit/Source/modules/vr/latest/VRDevice.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de44e2eadbf08ab3dd285236cd88a8907b4b6869 commit de44e2eadbf08ab3dd285236cd88a8907b4b6869 Author: Michael Thiessen <mthiesse@chromium.org> Date: Tue Oct 10 16:02:09 2017 VR: Move focus/secure origin checks to chrome/browser/vr/service This CL makes focus and secure origin checks for VR presentation cross-platform by moving them out of the Android VrShellDelegate to the VrDisplayHost in chrome/browser/vr/service/. There are no functionality changes here. https://chromium-review.googlesource.com/c/chromium/src/+/698276 must land before this CL. Bug: 768923 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I1358b289b24e0b14649574e28c63d07baab1f456 Reviewed-on: https://chromium-review.googlesource.com/698374 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Yash Malik <ymalik@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#507680} [modify] https://crrev.com/de44e2eadbf08ab3dd285236cd88a8907b4b6869/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java [modify] https://crrev.com/de44e2eadbf08ab3dd285236cd88a8907b4b6869/chrome/browser/android/vr_shell/vr_shell.cc [modify] https://crrev.com/de44e2eadbf08ab3dd285236cd88a8907b4b6869/chrome/browser/android/vr_shell/vr_shell.h [modify] https://crrev.com/de44e2eadbf08ab3dd285236cd88a8907b4b6869/chrome/browser/android/vr_shell/vr_shell_delegate.cc [modify] https://crrev.com/de44e2eadbf08ab3dd285236cd88a8907b4b6869/chrome/browser/android/vr_shell/vr_shell_delegate.h [modify] https://crrev.com/de44e2eadbf08ab3dd285236cd88a8907b4b6869/chrome/browser/vr/BUILD.gn [modify] https://crrev.com/de44e2eadbf08ab3dd285236cd88a8907b4b6869/chrome/browser/vr/service/vr_device_manager_unittest.cc [modify] https://crrev.com/de44e2eadbf08ab3dd285236cd88a8907b4b6869/chrome/browser/vr/service/vr_display_host.cc [modify] https://crrev.com/de44e2eadbf08ab3dd285236cd88a8907b4b6869/chrome/browser/vr/service/vr_display_host.h [modify] https://crrev.com/de44e2eadbf08ab3dd285236cd88a8907b4b6869/chrome/browser/vr/service/vr_service_impl.cc [modify] https://crrev.com/de44e2eadbf08ab3dd285236cd88a8907b4b6869/chrome/browser/vr/service/vr_service_impl.h [modify] https://crrev.com/de44e2eadbf08ab3dd285236cd88a8907b4b6869/content/browser/frame_host/render_frame_host_impl.cc [modify] https://crrev.com/de44e2eadbf08ab3dd285236cd88a8907b4b6869/content/public/browser/webvr_service_provider.cc [modify] https://crrev.com/de44e2eadbf08ab3dd285236cd88a8907b4b6869/content/public/browser/webvr_service_provider.h [modify] https://crrev.com/de44e2eadbf08ab3dd285236cd88a8907b4b6869/device/vr/android/gvr/gvr_delegate_provider.h [modify] https://crrev.com/de44e2eadbf08ab3dd285236cd88a8907b4b6869/device/vr/android/gvr/gvr_device.cc [modify] https://crrev.com/de44e2eadbf08ab3dd285236cd88a8907b4b6869/device/vr/android/gvr/gvr_device.h [modify] https://crrev.com/de44e2eadbf08ab3dd285236cd88a8907b4b6869/device/vr/openvr/openvr_device.cc [modify] https://crrev.com/de44e2eadbf08ab3dd285236cd88a8907b4b6869/device/vr/openvr/openvr_device.h [modify] https://crrev.com/de44e2eadbf08ab3dd285236cd88a8907b4b6869/device/vr/test/fake_vr_device.cc [modify] https://crrev.com/de44e2eadbf08ab3dd285236cd88a8907b4b6869/device/vr/test/fake_vr_device.h [modify] https://crrev.com/de44e2eadbf08ab3dd285236cd88a8907b4b6869/device/vr/vr_device.cc [modify] https://crrev.com/de44e2eadbf08ab3dd285236cd88a8907b4b6869/device/vr/vr_device.h [modify] https://crrev.com/de44e2eadbf08ab3dd285236cd88a8907b4b6869/device/vr/vr_display_impl.cc [modify] https://crrev.com/de44e2eadbf08ab3dd285236cd88a8907b4b6869/device/vr/vr_display_impl.h [modify] https://crrev.com/de44e2eadbf08ab3dd285236cd88a8907b4b6869/device/vr/vr_display_impl_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b2c7c55ef4e6e77ae634dfd5e78a067547dfbcca commit b2c7c55ef4e6e77ae634dfd5e78a067547dfbcca Author: Sebastien Seguin-Gagnon <sebsg@chromium.org> Date: Tue Oct 10 16:57:39 2017 Revert "VR: Move focus/secure origin checks to chrome/browser/vr/service" This reverts commit de44e2eadbf08ab3dd285236cd88a8907b4b6869. Reason for revert: Possible culprit for tree closure on Android Arm64 Builder (dbg) Build #46484 https://build.chromium.org/p/chromium.linux/builders/Android%20Arm64%20Builder%20%28dbg%29/builds/46484 Original change's description: > VR: Move focus/secure origin checks to chrome/browser/vr/service > > This CL makes focus and secure origin checks for VR presentation > cross-platform by moving them out of the Android VrShellDelegate to > the VrDisplayHost in chrome/browser/vr/service/. > > There are no functionality changes here. > > https://chromium-review.googlesource.com/c/chromium/src/+/698276 > must land before this CL. > > > Bug: 768923 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation > Change-Id: I1358b289b24e0b14649574e28c63d07baab1f456 > Reviewed-on: https://chromium-review.googlesource.com/698374 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Yash Malik <ymalik@chromium.org> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#507680} TBR=avi@chromium.org,mthiesse@chromium.org,ymalik@chromium.org Change-Id: I220d02d5eb0f551104be46902f32866f2959d321 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 768923 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Reviewed-on: https://chromium-review.googlesource.com/709675 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#507694} [modify] https://crrev.com/b2c7c55ef4e6e77ae634dfd5e78a067547dfbcca/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java [modify] https://crrev.com/b2c7c55ef4e6e77ae634dfd5e78a067547dfbcca/chrome/browser/android/vr_shell/vr_shell.cc [modify] https://crrev.com/b2c7c55ef4e6e77ae634dfd5e78a067547dfbcca/chrome/browser/android/vr_shell/vr_shell.h [modify] https://crrev.com/b2c7c55ef4e6e77ae634dfd5e78a067547dfbcca/chrome/browser/android/vr_shell/vr_shell_delegate.cc [modify] https://crrev.com/b2c7c55ef4e6e77ae634dfd5e78a067547dfbcca/chrome/browser/android/vr_shell/vr_shell_delegate.h [modify] https://crrev.com/b2c7c55ef4e6e77ae634dfd5e78a067547dfbcca/chrome/browser/vr/BUILD.gn [modify] https://crrev.com/b2c7c55ef4e6e77ae634dfd5e78a067547dfbcca/chrome/browser/vr/service/vr_device_manager_unittest.cc [modify] https://crrev.com/b2c7c55ef4e6e77ae634dfd5e78a067547dfbcca/chrome/browser/vr/service/vr_display_host.cc [modify] https://crrev.com/b2c7c55ef4e6e77ae634dfd5e78a067547dfbcca/chrome/browser/vr/service/vr_display_host.h [modify] https://crrev.com/b2c7c55ef4e6e77ae634dfd5e78a067547dfbcca/chrome/browser/vr/service/vr_service_impl.cc [modify] https://crrev.com/b2c7c55ef4e6e77ae634dfd5e78a067547dfbcca/chrome/browser/vr/service/vr_service_impl.h [modify] https://crrev.com/b2c7c55ef4e6e77ae634dfd5e78a067547dfbcca/content/browser/frame_host/render_frame_host_impl.cc [modify] https://crrev.com/b2c7c55ef4e6e77ae634dfd5e78a067547dfbcca/content/public/browser/webvr_service_provider.cc [modify] https://crrev.com/b2c7c55ef4e6e77ae634dfd5e78a067547dfbcca/content/public/browser/webvr_service_provider.h [modify] https://crrev.com/b2c7c55ef4e6e77ae634dfd5e78a067547dfbcca/device/vr/android/gvr/gvr_delegate_provider.h [modify] https://crrev.com/b2c7c55ef4e6e77ae634dfd5e78a067547dfbcca/device/vr/android/gvr/gvr_device.cc [modify] https://crrev.com/b2c7c55ef4e6e77ae634dfd5e78a067547dfbcca/device/vr/android/gvr/gvr_device.h [modify] https://crrev.com/b2c7c55ef4e6e77ae634dfd5e78a067547dfbcca/device/vr/openvr/openvr_device.cc [modify] https://crrev.com/b2c7c55ef4e6e77ae634dfd5e78a067547dfbcca/device/vr/openvr/openvr_device.h [modify] https://crrev.com/b2c7c55ef4e6e77ae634dfd5e78a067547dfbcca/device/vr/test/fake_vr_device.cc [modify] https://crrev.com/b2c7c55ef4e6e77ae634dfd5e78a067547dfbcca/device/vr/test/fake_vr_device.h [modify] https://crrev.com/b2c7c55ef4e6e77ae634dfd5e78a067547dfbcca/device/vr/vr_device.cc [modify] https://crrev.com/b2c7c55ef4e6e77ae634dfd5e78a067547dfbcca/device/vr/vr_device.h [modify] https://crrev.com/b2c7c55ef4e6e77ae634dfd5e78a067547dfbcca/device/vr/vr_display_impl.cc [modify] https://crrev.com/b2c7c55ef4e6e77ae634dfd5e78a067547dfbcca/device/vr/vr_display_impl.h [modify] https://crrev.com/b2c7c55ef4e6e77ae634dfd5e78a067547dfbcca/device/vr/vr_display_impl_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f6e637b7411df4addc7477b22adbe62ba8c4dc3 commit 7f6e637b7411df4addc7477b22adbe62ba8c4dc3 Author: Michael Thiessen <mthiesse@chromium.org> Date: Wed Oct 11 18:05:00 2017 Reland "VR: Move focus/secure origin checks to chrome/browser/vr/service" Original change's description: > Revert "VR: Move focus/secure origin checks to chrome/browser/vr/service" > > This reverts commit de44e2eadbf08ab3dd285236cd88a8907b4b6869. > > Reason for revert: Possible culprit for tree closure on Android Arm64 Builder (dbg) Build #46484 > > https://build.chromium.org/p/chromium.linux/builders/Android%20Arm64%20Builder%20%28dbg%29/builds/46484 > > > > Original change's description: > > VR: Move focus/secure origin checks to chrome/browser/vr/service > > > > This CL makes focus and secure origin checks for VR presentation > > cross-platform by moving them out of the Android VrShellDelegate to > > the VrDisplayHost in chrome/browser/vr/service/. > > > > There are no functionality changes here. > > > > https://chromium-review.googlesource.com/c/chromium/src/+/698276 > > must land before this CL. > > > > > > Bug: 768923 > > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation > > Change-Id: I1358b289b24e0b14649574e28c63d07baab1f456 > > Reviewed-on: https://chromium-review.googlesource.com/698374 > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Reviewed-by: Yash Malik <ymalik@chromium.org> > > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#507680} > > TBR=avi@chromium.org,mthiesse@chromium.org,ymalik@chromium.org > > Change-Id: I220d02d5eb0f551104be46902f32866f2959d321 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 768923 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation > Reviewed-on: https://chromium-review.googlesource.com/709675 > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#507694} TBR=avi@chromium.org,mthiesse@chromium.org,ymalik@chromium.org,sebsg@chromium.org Bug: 768923 Change-Id: Id566997946afe4fc396cb02c46f3ac9473d67ed8 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Reviewed-on: https://chromium-review.googlesource.com/709956 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#508035} [modify] https://crrev.com/7f6e637b7411df4addc7477b22adbe62ba8c4dc3/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java [modify] https://crrev.com/7f6e637b7411df4addc7477b22adbe62ba8c4dc3/chrome/browser/android/vr_shell/vr_shell.cc [modify] https://crrev.com/7f6e637b7411df4addc7477b22adbe62ba8c4dc3/chrome/browser/android/vr_shell/vr_shell.h [modify] https://crrev.com/7f6e637b7411df4addc7477b22adbe62ba8c4dc3/chrome/browser/android/vr_shell/vr_shell_delegate.cc [modify] https://crrev.com/7f6e637b7411df4addc7477b22adbe62ba8c4dc3/chrome/browser/android/vr_shell/vr_shell_delegate.h [modify] https://crrev.com/7f6e637b7411df4addc7477b22adbe62ba8c4dc3/chrome/browser/vr/BUILD.gn [modify] https://crrev.com/7f6e637b7411df4addc7477b22adbe62ba8c4dc3/chrome/browser/vr/service/vr_device_manager_unittest.cc [modify] https://crrev.com/7f6e637b7411df4addc7477b22adbe62ba8c4dc3/chrome/browser/vr/service/vr_display_host.cc [modify] https://crrev.com/7f6e637b7411df4addc7477b22adbe62ba8c4dc3/chrome/browser/vr/service/vr_display_host.h [modify] https://crrev.com/7f6e637b7411df4addc7477b22adbe62ba8c4dc3/chrome/browser/vr/service/vr_service_impl.cc [modify] https://crrev.com/7f6e637b7411df4addc7477b22adbe62ba8c4dc3/chrome/browser/vr/service/vr_service_impl.h [modify] https://crrev.com/7f6e637b7411df4addc7477b22adbe62ba8c4dc3/content/browser/frame_host/render_frame_host_impl.cc [modify] https://crrev.com/7f6e637b7411df4addc7477b22adbe62ba8c4dc3/content/public/browser/webvr_service_provider.cc [modify] https://crrev.com/7f6e637b7411df4addc7477b22adbe62ba8c4dc3/content/public/browser/webvr_service_provider.h [modify] https://crrev.com/7f6e637b7411df4addc7477b22adbe62ba8c4dc3/device/vr/android/gvr/gvr_delegate_provider.h [modify] https://crrev.com/7f6e637b7411df4addc7477b22adbe62ba8c4dc3/device/vr/android/gvr/gvr_device.cc [modify] https://crrev.com/7f6e637b7411df4addc7477b22adbe62ba8c4dc3/device/vr/android/gvr/gvr_device.h [modify] https://crrev.com/7f6e637b7411df4addc7477b22adbe62ba8c4dc3/device/vr/openvr/openvr_device.cc [modify] https://crrev.com/7f6e637b7411df4addc7477b22adbe62ba8c4dc3/device/vr/openvr/openvr_device.h [modify] https://crrev.com/7f6e637b7411df4addc7477b22adbe62ba8c4dc3/device/vr/test/fake_vr_device.cc [modify] https://crrev.com/7f6e637b7411df4addc7477b22adbe62ba8c4dc3/device/vr/test/fake_vr_device.h [modify] https://crrev.com/7f6e637b7411df4addc7477b22adbe62ba8c4dc3/device/vr/vr_device.cc [modify] https://crrev.com/7f6e637b7411df4addc7477b22adbe62ba8c4dc3/device/vr/vr_device.h [modify] https://crrev.com/7f6e637b7411df4addc7477b22adbe62ba8c4dc3/device/vr/vr_display_impl.cc [modify] https://crrev.com/7f6e637b7411df4addc7477b22adbe62ba8c4dc3/device/vr/vr_display_impl.h [modify] https://crrev.com/7f6e637b7411df4addc7477b22adbe62ba8c4dc3/device/vr/vr_display_impl_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/21e5615b6812c131c2b6d1f7cca41bcd7018bfe4 commit 21e5615b6812c131c2b6d1f7cca41bcd7018bfe4 Author: Michael Thiessen <mthiesse@chromium.org> Date: Mon Oct 16 18:55:17 2017 VR: Refactor out VRDeviceBase with unit tests for basic device functionality. This CL makes the interface between device/ and browser/ clear by making VRDevice an interface that chrome/browser uses for its device/ interactions. VRDeviceBase implements this interface with functionality common to all VR Devices. This CL also adds tests for that common functionality. Bug: 768923 Change-Id: Ibde9d3532b8dd300a601e858e0e49178c0a4a4a4 Reviewed-on: https://chromium-review.googlesource.com/712702 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#509124} [modify] https://crrev.com/21e5615b6812c131c2b6d1f7cca41bcd7018bfe4/chrome/browser/android/vr_shell/vr_shell.cc [modify] https://crrev.com/21e5615b6812c131c2b6d1f7cca41bcd7018bfe4/chrome/browser/android/vr_shell/vr_shell_delegate.cc [modify] https://crrev.com/21e5615b6812c131c2b6d1f7cca41bcd7018bfe4/chrome/browser/vr/service/vr_device_manager.cc [modify] https://crrev.com/21e5615b6812c131c2b6d1f7cca41bcd7018bfe4/chrome/browser/vr/service/vr_device_manager_unittest.cc [modify] https://crrev.com/21e5615b6812c131c2b6d1f7cca41bcd7018bfe4/device/BUILD.gn [modify] https://crrev.com/21e5615b6812c131c2b6d1f7cca41bcd7018bfe4/device/vr/BUILD.gn [modify] https://crrev.com/21e5615b6812c131c2b6d1f7cca41bcd7018bfe4/device/vr/android/gvr/gvr_device.cc [modify] https://crrev.com/21e5615b6812c131c2b6d1f7cca41bcd7018bfe4/device/vr/android/gvr/gvr_device.h [modify] https://crrev.com/21e5615b6812c131c2b6d1f7cca41bcd7018bfe4/device/vr/openvr/openvr_device.cc [modify] https://crrev.com/21e5615b6812c131c2b6d1f7cca41bcd7018bfe4/device/vr/openvr/openvr_device.h [modify] https://crrev.com/21e5615b6812c131c2b6d1f7cca41bcd7018bfe4/device/vr/test/fake_vr_device.cc [modify] https://crrev.com/21e5615b6812c131c2b6d1f7cca41bcd7018bfe4/device/vr/test/fake_vr_device.h [add] https://crrev.com/21e5615b6812c131c2b6d1f7cca41bcd7018bfe4/device/vr/test/mock_vr_display_impl.cc [add] https://crrev.com/21e5615b6812c131c2b6d1f7cca41bcd7018bfe4/device/vr/test/mock_vr_display_impl.h [delete] https://crrev.com/bcde8e580019343b322b4265fc9664e5646fd2c0/device/vr/vr_device.cc [modify] https://crrev.com/21e5615b6812c131c2b6d1f7cca41bcd7018bfe4/device/vr/vr_device.h [add] https://crrev.com/21e5615b6812c131c2b6d1f7cca41bcd7018bfe4/device/vr/vr_device_base.cc [add] https://crrev.com/21e5615b6812c131c2b6d1f7cca41bcd7018bfe4/device/vr/vr_device_base.h [add] https://crrev.com/21e5615b6812c131c2b6d1f7cca41bcd7018bfe4/device/vr/vr_device_base_unittest.cc [modify] https://crrev.com/21e5615b6812c131c2b6d1f7cca41bcd7018bfe4/device/vr/vr_display_impl.cc [modify] https://crrev.com/21e5615b6812c131c2b6d1f7cca41bcd7018bfe4/device/vr/vr_display_impl.h [modify] https://crrev.com/21e5615b6812c131c2b6d1f7cca41bcd7018bfe4/device/vr/vr_display_impl_unittest.cc
Comment 1 by mthiesse@chromium.org
, Sep 27 2017