New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 768891 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 765834



Sign in to add a comment

[Predator] Handle dependency rolls with old_revision missing.

Project Member Reported by kateso...@chromium.org, Sep 26 2017

Issue description

[Predator] Handle dependency rolls with old_revision missing.

The dependency_rolls of some testcases may be like this:
{
    "dep_path": "src/third_party/libevdev/src", 
    "new_revision": "9f7a1961eb4726211e18abd147d5a11a4ea86744", 
    "repo_url": "https://chromium.googlesource.com/chromiumos/platform/libevdev"
  }, 
  {
    "dep_path": "src/third_party/nacl_sdk_binaries", 
    "new_revision": "759dfca03bdc774da7ecbf974f6e2b84f43699a5", 
    "repo_url": "https://chromium.googlesource.com/chromium/deps/nacl_sdk_binaries"
  }, 
  ...
}

In this case, we cannot find a culprit cl, but we should be able to find components.
 
Issue 768189 has been merged into this issue.
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/c9aed144aad05382aa200fcfdce8b802871ed2d8

commit c9aed144aad05382aa200fcfdce8b802871ed2d8
Author: Sharu Jiang <katesonia@google.com>
Date: Tue Sep 26 22:52:26 2017

[Predator] Handle dependency rolls with old_revision missing.

If we only miss one of the 'old_revision' and 'new_revision', we replace the missing one with None. For example if we miss 'old_revision', the regression range should be (None, 'new_revision')
If we miss both 'old_revision' and 'new_revision', the regression range should be None.

Bug:  768891 
Change-Id: I987f015962c5ada81b4032dee672144daeca03ad
Reviewed-on: https://chromium-review.googlesource.com/685263
Commit-Queue: Sharu Jiang <katesonia@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/c9aed144aad05382aa200fcfdce8b802871ed2d8/appengine/predator/analysis/test/clusterfuzz_data_test.py
[modify] https://crrev.com/c9aed144aad05382aa200fcfdce8b802871ed2d8/appengine/predator/analysis/clusterfuzz_data.py

Status: Fixed (was: Assigned)

Sign in to add a comment