Automatically add "ios-simulator-cronet" trybot for changes in Cronet iOS |
||
Issue descriptionWe should automatically add "ios-simulator-cronet" trybot if there are any changes in the "components/cronet" directory excluding "components/cronet/android". This request is motivated by unintentional iOS build breakages, e.g. see https://bugs.chromium.org/p/chromium/issues/detail?id=768431 For implementation details how it is implemented for "android_cronet_tester" see: 1) https://cs.chromium.org/chromium/src/components/cronet/PRESUBMIT.py?q=f:cronet+f:PRES+PostUploadHook&sq=package:chromium&l=88 2) https://codereview.chromium.org/2514653004 3) https://codereview.chromium.org/2683103002
,
Sep 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f15b89f6963a03c4b2531ab9c778f84c7ac829d commit 0f15b89f6963a03c4b2531ab9c778f84c7ac829d Author: kapishnikov <kapishnikov@chromium.org> Date: Fri Sep 29 13:55:29 2017 Automatically add ios-simulator-cronet trybot if a change can impact Cronet for iOS BUG= 768883 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Idc4989dacd7390d1c5b58d3877cbfbc3a9818802 Reviewed-on: https://chromium-review.googlesource.com/690347 Reviewed-by: Paul Jensen <pauljensen@chromium.org> Commit-Queue: Andrei Kapishnikov <kapishnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#505362} [modify] https://crrev.com/0f15b89f6963a03c4b2531ab9c778f84c7ac829d/components/cronet/PRESUBMIT.py
,
Sep 29 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by kapishnikov@chromium.org
, Sep 28 2017Status: Started (was: Available)