Switching drawing backend for Autofill and Password Manager popups to toolkit views |
|||||||
Issue descriptionFeature description: Bug for tracking progress for the new popup UI implementation. Eng owner: melandory@ Product owner: zkoch Design doc: https://docs.google.com/document/d/163ILTi-sY9EKTitvDJ0gE0a3FJ7ENERxSIfai_whG78/edit#
,
Oct 5 2017
,
Nov 7 2017
,
Nov 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d8f35f63195daaace94edf86df69d76b4584dfec commit d8f35f63195daaace94edf86df69d76b4584dfec Author: Tatiana Gornak <melandory@chromium.org> Date: Wed Nov 22 10:19:04 2017 Skeleton View for displaying text elements of the Password Manager and Autofill popups. This CL implements skeleton view for the autofill on-field popup. Every type of the autofill popup is displayed as a text row after this CL. The implementation is guarded with a feature. Screenshots of some popups are attached to the bug. This CL doesn't implement animation related to the popup, e.g. the row isn't hilighted when the mouse hovers over the row. The separator element isn't displayed. BUG= 768881 Change-Id: Ib235a1b811ce0026428fdc03d1eba7f7be27fd0a Reviewed-on: https://chromium-review.googlesource.com/685237 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#518594} [modify] https://crrev.com/d8f35f63195daaace94edf86df69d76b4584dfec/chrome/browser/ui/BUILD.gn [add] https://crrev.com/d8f35f63195daaace94edf86df69d76b4584dfec/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc [add] https://crrev.com/d8f35f63195daaace94edf86df69d76b4584dfec/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.h [add] https://crrev.com/d8f35f63195daaace94edf86df69d76b4584dfec/chrome/browser/ui/views/autofill/autofill_popup_view_native_views_unittest.cc [modify] https://crrev.com/d8f35f63195daaace94edf86df69d76b4584dfec/chrome/browser/ui/views/autofill/autofill_popup_view_views.cc [modify] https://crrev.com/d8f35f63195daaace94edf86df69d76b4584dfec/chrome/test/BUILD.gn [modify] https://crrev.com/d8f35f63195daaace94edf86df69d76b4584dfec/components/autofill/core/browser/autofill_experiments.cc [modify] https://crrev.com/d8f35f63195daaace94edf86df69d76b4584dfec/components/autofill/core/browser/autofill_experiments.h
,
Jan 24 2018
Picking this up on the Autofill side.
,
Jan 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee53f1e418a81a9094f3929f8370660e2ae8d9ff commit ee53f1e418a81a9094f3929f8370660e2ae8d9ff Author: Tommy Martino <tmartino@chromium.org> Date: Wed Jan 31 22:41:04 2018 [Autofill Views] Adding events and styling This CL fills in missing pieces of the Views implementation of the Autofill popup. Notably, this reintroduces styling, hover effects, and separators. It also gives the general bones of the code structure for creating child rows, which will in the future be used for testing variant designs (e.g., A/B testing new UX), and possibly also for allowing divergence between use cases (e.g., bespoke designs for autofill vs. passwords, different approaches for insecure context warnings, etc.). Bug: 768881 Change-Id: Ie6a733b392ae33ef557e20fcc43ddd05c9d06f6b Reviewed-on: https://chromium-review.googlesource.com/815256 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#533451} [modify] https://crrev.com/ee53f1e418a81a9094f3929f8370660e2ae8d9ff/chrome/browser/ui/autofill/autofill_popup_controller.h [modify] https://crrev.com/ee53f1e418a81a9094f3929f8370660e2ae8d9ff/chrome/browser/ui/autofill/autofill_popup_controller_impl.h [modify] https://crrev.com/ee53f1e418a81a9094f3929f8370660e2ae8d9ff/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa_unittest.mm [modify] https://crrev.com/ee53f1e418a81a9094f3929f8370660e2ae8d9ff/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc [modify] https://crrev.com/ee53f1e418a81a9094f3929f8370660e2ae8d9ff/chrome/browser/ui/views/autofill/autofill_popup_base_view.h [modify] https://crrev.com/ee53f1e418a81a9094f3929f8370660e2ae8d9ff/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc [modify] https://crrev.com/ee53f1e418a81a9094f3929f8370660e2ae8d9ff/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.h [modify] https://crrev.com/ee53f1e418a81a9094f3929f8370660e2ae8d9ff/chrome/browser/ui/views/autofill/autofill_popup_view_native_views_unittest.cc [modify] https://crrev.com/ee53f1e418a81a9094f3929f8370660e2ae8d9ff/chrome/browser/ui/views/autofill/autofill_popup_view_views_browsertest.cc
,
Feb 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f20074c86c1f1be6b953df07e9a4caddaf2333ec commit f20074c86c1f1be6b953df07e9a4caddaf2333ec Author: Tommy Martino <tmartino@chromium.org> Date: Wed Feb 07 16:42:37 2018 [Autofill Views] Fixing 2 hover event issues This patch addresses two issues relating to hover events: 1. Hovering over the padding on the top/bottom of the popup triggers strange behavior and fires selection events which we don't want. 2. Setting the Selected color for the labels is a no-op because our notion of selection is independent from the Labels'. This patch instead applies those colors at select-time. Bug: 768881 Change-Id: If9a0e9b78d7074aa918ac95a0462ab8ff3ec9c33 Reviewed-on: https://chromium-review.googlesource.com/898104 Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: anthonyvd <anthonyvd@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#535027} [modify] https://crrev.com/f20074c86c1f1be6b953df07e9a4caddaf2333ec/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc [modify] https://crrev.com/f20074c86c1f1be6b953df07e9a4caddaf2333ec/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.h [modify] https://crrev.com/f20074c86c1f1be6b953df07e9a4caddaf2333ec/chrome/browser/ui/views/autofill/autofill_popup_view_native_views_unittest.cc
,
Feb 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd414737834427f602118bd584691282d588b0d1 commit cd414737834427f602118bd584691282d588b0d1 Author: tmartino <tmartino@chromium.org> Date: Mon Feb 12 19:01:01 2018 [Autofill Views] Adding flag for feature Bug: 768881 Change-Id: If7e4d6bd7f9dd2039dc543ebfe82090e197fde68 Reviewed-on: https://chromium-review.googlesource.com/907418 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#536147} [modify] https://crrev.com/cd414737834427f602118bd584691282d588b0d1/chrome/browser/about_flags.cc [modify] https://crrev.com/cd414737834427f602118bd584691282d588b0d1/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/cd414737834427f602118bd584691282d588b0d1/chrome/browser/flag_descriptions.h [modify] https://crrev.com/cd414737834427f602118bd584691282d588b0d1/tools/metrics/histograms/enums.xml
,
Mar 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/45ef1825fdbf4204606d5652ca3424b0cfcda73c commit 45ef1825fdbf4204606d5652ca3424b0cfcda73c Author: Tommy Martino <tmartino@chromium.org> Date: Wed Mar 07 16:11:42 2018 [Autofill Views] Adding Icons Adding the capability to display icons (e.g., Visa logo) in Autofill dropdown reimplementation. Screenshots: https://docs.google.com/presentation/d/1869xYStqAIyVODBlUTi5Gf4ct6hevSdCGiJpFuOOVw8/edit?usp=sharing Bug: 768881 Change-Id: I659a2dcffe01f3390e187fd969f62570fe7cb850 Reviewed-on: https://chromium-review.googlesource.com/912401 Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: anthonyvd <anthonyvd@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#541449} [modify] https://crrev.com/45ef1825fdbf4204606d5652ca3424b0cfcda73c/chrome/browser/ui/autofill/autofill_popup_layout_model.cc [modify] https://crrev.com/45ef1825fdbf4204606d5652ca3424b0cfcda73c/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc [modify] https://crrev.com/45ef1825fdbf4204606d5652ca3424b0cfcda73c/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.h [modify] https://crrev.com/45ef1825fdbf4204606d5652ca3424b0cfcda73c/chrome/browser/ui/views/autofill/autofill_popup_view_views.cc
,
Apr 5 2018
,
Apr 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b25d9b9a4d03d21384efe42bc1be8023954fe286 commit b25d9b9a4d03d21384efe42bc1be8023954fe286 Author: Fabio Tirelo <ftirelo@chromium.org> Date: Wed Apr 11 13:47:32 2018 [af] Run AutofillPopupControllerBrowserTest with AutofillExpandedPopupViews enabled This parameterizes AutofillPopupControllerBrowserTest to run with the feature either enabled or disabled. The goal is to help us ensure it's to enable the feature for Canary/Dev. Other tests will be parameterized in follow up CLs. Bug: 768881 Change-Id: I4166d5dc8a1c326b78a88f6d92687505d070d8e4 Reviewed-on: https://chromium-review.googlesource.com/1004923 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Tommy Martino <tmartino@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#549874} [modify] https://crrev.com/b25d9b9a4d03d21384efe42bc1be8023954fe286/chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc
,
Apr 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34eeb9e1f4b7345ffac7788d9c22054190693c12 commit 34eeb9e1f4b7345ffac7788d9c22054190693c12 Author: Fabio Tirelo <ftirelo@chromium.org> Date: Thu Apr 12 23:51:11 2018 [af] Enable kAutofillExpandedPopupViews in password manager ui tests This parameterizes tests in password_manager_interactive_uitest.cc to run with feature kAutofillExpandedPopupViews either enabled or disabled. The goal is to ensure it's safe to enable the feature for Canary/Dev. Some of the tests don't actually run the code enabled by the feature, but parametrize only those tests would lead to a much more complicated structure. This would be specially annoying since the feature will eventually be deleted after it becomes the default and we can get rid of the deprecated code paths. There are tests in password_manager_browsertest.cc also affected by the feature, but they will be updated on a follow up CL. Bug: 768881 Change-Id: I0403765e8da19037cef5d8f5381300621882a323 Reviewed-on: https://chromium-review.googlesource.com/1007782 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#550418} [modify] https://crrev.com/34eeb9e1f4b7345ffac7788d9c22054190693c12/chrome/browser/password_manager/password_manager_interactive_uitest.cc
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c3991fe1a8c3a8d8805d645e29e7f8af58ac366a commit c3991fe1a8c3a8d8805d645e29e7f8af58ac366a Author: Fabio Tirelo <ftirelo@chromium.org> Date: Fri Apr 13 21:00:45 2018 [af] Run AutofillInteractiveTest with AutofillExpandedPopupViews enabled This parameterizes AutofillInteractiveTest and subclasses to run with the feature either enabled or disabled. The goal is to help us ensure it's to enable the feature for Canary/Dev. I'm investigating if there are other tests that should be affected by the feature, and will update them in follow up CLs. Bug: 768881 Change-Id: I13b0bf654374728749ce7c5b3829bc02ff386cd3 Reviewed-on: https://chromium-review.googlesource.com/1005888 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Roger McFarlane <rogerm@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#550759} [modify] https://crrev.com/c3991fe1a8c3a8d8805d645e29e7f8af58ac366a/chrome/browser/autofill/autofill_interactive_uitest.cc
,
Apr 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f84eb6c7cc07e27dda691e2e93d3f0417d9937c commit 4f84eb6c7cc07e27dda691e2e93d3f0417d9937c Author: Fabio Tirelo <ftirelo@chromium.org> Date: Sat Apr 14 00:32:32 2018 [af] Run autofill sanity tests with AutofillExpandedPopupViews enabled This parameterizes DevToolsSanityTest.TestDispatchKeyEventShowsAutoFill to run with the feature either enabled or disabled. The goal is to ensure it's safe to enable the feature for Canary/Dev. A new test fixture (AutofillDevToolsSanityTest) was created, so that only tests involving autofill are parametrized. Bug: 768881 Change-Id: I50775a13e7c497e6e888511395b485743883aa15 Reviewed-on: https://chromium-review.googlesource.com/1007009 Reviewed-by: Tommy Martino <tmartino@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#550832} [modify] https://crrev.com/4f84eb6c7cc07e27dda691e2e93d3f0417d9937c/chrome/browser/devtools/devtools_sanity_browsertest.cc
,
Apr 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f23f73bc7d1e81bdb97a9ec00c3cb3f074c4dab8 commit f23f73bc7d1e81bdb97a9ec00c3cb3f074c4dab8 Author: Fabio Tirelo <ftirelo@chromium.org> Date: Mon Apr 16 16:20:06 2018 Revert "[af] Run AutofillInteractiveTest with AutofillExpandedPopupViews enabled" This reverts commit c3991fe1a8c3a8d8805d645e29e7f8af58ac366a. Reason for revert: Several tests became flaky on ChromeOS - crbug.com/c/833176 - crbug.com/c/833237 - crbug.com/c/833219 - crbug.com/c/833127 - crbug.com/c/833030 This is not the first time a test becomes flaky on ChromeOS for the same reason: it hangs while waiting in SendKeyToPopupAndWait(). Giving such an issue has been there for a long time, I think it may be time to investigate what's going on and trying to come up with an explanation. Original change's description: > [af] Run AutofillInteractiveTest with AutofillExpandedPopupViews enabled > > This parameterizes AutofillInteractiveTest and subclasses to run with > the feature either enabled or disabled. The goal is to help us > ensure it's to enable the feature for Canary/Dev. > > I'm investigating if there are other tests that should be affected by > the feature, and will update them in follow up CLs. > > Bug: 768881 > Change-Id: I13b0bf654374728749ce7c5b3829bc02ff386cd3 > Reviewed-on: https://chromium-review.googlesource.com/1005888 > Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> > Reviewed-by: Roger McFarlane <rogerm@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550759} TBR=rogerm@chromium.org,estade@chromium.org,tmartino@chromium.org,ftirelo@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 768881 Change-Id: I157dcf789abfa57ad924a24967ab3ed83e48145c Reviewed-on: https://chromium-review.googlesource.com/1014141 Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#550992} [modify] https://crrev.com/f23f73bc7d1e81bdb97a9ec00c3cb3f074c4dab8/chrome/browser/autofill/autofill_interactive_uitest.cc
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34eeb9e1f4b7345ffac7788d9c22054190693c12 commit 34eeb9e1f4b7345ffac7788d9c22054190693c12 Author: Fabio Tirelo <ftirelo@chromium.org> Date: Thu Apr 12 23:51:11 2018 [af] Enable kAutofillExpandedPopupViews in password manager ui tests This parameterizes tests in password_manager_interactive_uitest.cc to run with feature kAutofillExpandedPopupViews either enabled or disabled. The goal is to ensure it's safe to enable the feature for Canary/Dev. Some of the tests don't actually run the code enabled by the feature, but parametrize only those tests would lead to a much more complicated structure. This would be specially annoying since the feature will eventually be deleted after it becomes the default and we can get rid of the deprecated code paths. There are tests in password_manager_browsertest.cc also affected by the feature, but they will be updated on a follow up CL. Bug: 768881 Change-Id: I0403765e8da19037cef5d8f5381300621882a323 Reviewed-on: https://chromium-review.googlesource.com/1007782 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#550418} [modify] https://crrev.com/34eeb9e1f4b7345ffac7788d9c22054190693c12/chrome/browser/password_manager/password_manager_interactive_uitest.cc
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c3991fe1a8c3a8d8805d645e29e7f8af58ac366a commit c3991fe1a8c3a8d8805d645e29e7f8af58ac366a Author: Fabio Tirelo <ftirelo@chromium.org> Date: Fri Apr 13 21:00:45 2018 [af] Run AutofillInteractiveTest with AutofillExpandedPopupViews enabled This parameterizes AutofillInteractiveTest and subclasses to run with the feature either enabled or disabled. The goal is to help us ensure it's to enable the feature for Canary/Dev. I'm investigating if there are other tests that should be affected by the feature, and will update them in follow up CLs. Bug: 768881 Change-Id: I13b0bf654374728749ce7c5b3829bc02ff386cd3 Reviewed-on: https://chromium-review.googlesource.com/1005888 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Roger McFarlane <rogerm@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#550759} [modify] https://crrev.com/c3991fe1a8c3a8d8805d645e29e7f8af58ac366a/chrome/browser/autofill/autofill_interactive_uitest.cc
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f84eb6c7cc07e27dda691e2e93d3f0417d9937c commit 4f84eb6c7cc07e27dda691e2e93d3f0417d9937c Author: Fabio Tirelo <ftirelo@chromium.org> Date: Sat Apr 14 00:32:32 2018 [af] Run autofill sanity tests with AutofillExpandedPopupViews enabled This parameterizes DevToolsSanityTest.TestDispatchKeyEventShowsAutoFill to run with the feature either enabled or disabled. The goal is to ensure it's safe to enable the feature for Canary/Dev. A new test fixture (AutofillDevToolsSanityTest) was created, so that only tests involving autofill are parametrized. Bug: 768881 Change-Id: I50775a13e7c497e6e888511395b485743883aa15 Reviewed-on: https://chromium-review.googlesource.com/1007009 Reviewed-by: Tommy Martino <tmartino@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#550832} [modify] https://crrev.com/4f84eb6c7cc07e27dda691e2e93d3f0417d9937c/chrome/browser/devtools/devtools_sanity_browsertest.cc
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f23f73bc7d1e81bdb97a9ec00c3cb3f074c4dab8 commit f23f73bc7d1e81bdb97a9ec00c3cb3f074c4dab8 Author: Fabio Tirelo <ftirelo@chromium.org> Date: Mon Apr 16 16:20:06 2018 Revert "[af] Run AutofillInteractiveTest with AutofillExpandedPopupViews enabled" This reverts commit c3991fe1a8c3a8d8805d645e29e7f8af58ac366a. Reason for revert: Several tests became flaky on ChromeOS - crbug.com/c/833176 - crbug.com/c/833237 - crbug.com/c/833219 - crbug.com/c/833127 - crbug.com/c/833030 This is not the first time a test becomes flaky on ChromeOS for the same reason: it hangs while waiting in SendKeyToPopupAndWait(). Giving such an issue has been there for a long time, I think it may be time to investigate what's going on and trying to come up with an explanation. Original change's description: > [af] Run AutofillInteractiveTest with AutofillExpandedPopupViews enabled > > This parameterizes AutofillInteractiveTest and subclasses to run with > the feature either enabled or disabled. The goal is to help us > ensure it's to enable the feature for Canary/Dev. > > I'm investigating if there are other tests that should be affected by > the feature, and will update them in follow up CLs. > > Bug: 768881 > Change-Id: I13b0bf654374728749ce7c5b3829bc02ff386cd3 > Reviewed-on: https://chromium-review.googlesource.com/1005888 > Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> > Reviewed-by: Roger McFarlane <rogerm@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550759} TBR=rogerm@chromium.org,estade@chromium.org,tmartino@chromium.org,ftirelo@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 768881 Change-Id: I157dcf789abfa57ad924a24967ab3ed83e48145c Reviewed-on: https://chromium-review.googlesource.com/1014141 Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#550992} [modify] https://crrev.com/f23f73bc7d1e81bdb97a9ec00c3cb3f074c4dab8/chrome/browser/autofill/autofill_interactive_uitest.cc
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/995368fa26813102ac68cc0c2f45c55cf3a8b509 commit 995368fa26813102ac68cc0c2f45c55cf3a8b509 Author: Fabio Tirelo <ftirelo@chromium.org> Date: Thu Apr 19 21:02:12 2018 [af] Reland "Run AutofillInteractiveTest with kAutofillExpandedPopupViews enabled" This parameterizes AutofillPopupControllerBrowserTest to run with the feature either enabled or disabled. The goal is to help us ensure it's to enable the feature for Canary/Dev. Other tests will be parameterized in follow up CLs. This CL was initially landed as crrev.com/c/1004923 and reverted by crrev.com/c/1014141 due to flaky tests on ChromeOS. After investigation we found that the flakiness is caused by a behavior in the underlying framework that should not happen during tests, even though the behavior in the product is correct ( crbug.com/834768 , crbug.com/834369 ). Chrome OS tests have been temporarily disabled by crrev.com/c/1019840 while a proper fix is implemented, so this CL should not introduce new flakiness on the waterfall. Bug: 768881 Change-Id: Id285013e504ebf66cc58cc27b01adc20906f3c7a Reviewed-on: https://chromium-review.googlesource.com/1019861 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#552152} [modify] https://crrev.com/995368fa26813102ac68cc0c2f45c55cf3a8b509/chrome/browser/autofill/autofill_interactive_uitest.cc
,
Apr 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/130805d201be7b494970de1677aebf37425d5c17 commit 130805d201be7b494970de1677aebf37425d5c17 Author: Fabio Tirelo <ftirelo@chromium.org> Date: Mon Apr 23 20:35:52 2018 [af] Add strings for UI revamp Bug: 768881 Change-Id: I0af141a018e7f90ef0945d1587d676a2a8175512 Reviewed-on: https://chromium-review.googlesource.com/1024270 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#552817} [modify] https://crrev.com/130805d201be7b494970de1677aebf37425d5c17/components/autofill_strings.grdp
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/57e2ceecf8d901a03d123412762172e7991ddbf9 commit 57e2ceecf8d901a03d123412762172e7991ddbf9 Author: Fabio Tirelo <ftirelo@chromium.org> Date: Wed Apr 25 17:10:22 2018 [af] Always use the same obfuscation for card numbers With this change we will stop using *1234 to obsfucate the card number when we show a suggestion, for example, on a name field. We can simply use ****1234 in all places instead. The change applies to both the new and the deprecated dropdown. Bug: 768881 Change-Id: Ic17c28f668dc0bed42f220d474a72924f02c7ad5 Reviewed-on: https://chromium-review.googlesource.com/1026213 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#553607} [modify] https://crrev.com/57e2ceecf8d901a03d123412762172e7991ddbf9/components/autofill/core/browser/autofill_manager_unittest.cc [modify] https://crrev.com/57e2ceecf8d901a03d123412762172e7991ddbf9/components/autofill/core/browser/credit_card.cc [modify] https://crrev.com/57e2ceecf8d901a03d123412762172e7991ddbf9/components/autofill/core/browser/credit_card.h [modify] https://crrev.com/57e2ceecf8d901a03d123412762172e7991ddbf9/components/autofill/core/browser/credit_card_unittest.cc [modify] https://crrev.com/57e2ceecf8d901a03d123412762172e7991ddbf9/components/autofill/core/browser/personal_data_manager.cc
,
Apr 25 2018
Screenshot for current appearance in CL: https://chromium-review.googlesource.com/c/chromium/src/+/1026204
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c46b791f0011585cc456b0f2ea7260bcf17b410b commit c46b791f0011585cc456b0f2ea7260bcf17b410b Author: Fabio Tirelo <ftirelo@chromium.org> Date: Thu Apr 26 16:08:19 2018 [af] Enable AutofillExpandedPopupViews for PWM browser tests This parameterizes tests in password_manager_browsertest.cc to run with feature kAutofillExpandedPopupViews either enabled or disabled. The goal is to ensure it's safe to enable the feature for Canary/Dev. Some of the tests don't actually run the code enabled by the feature, but parametrize only those tests would lead to a much more complicated structure. This would be specially annoying since the feature will eventually be deleted after it becomes the default and we can get rid of the deprecated code paths. Bug: 768881 Change-Id: I50c477b74431b7a79354a0a496143bd6e6d8d099 Reviewed-on: https://chromium-review.googlesource.com/1012474 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#554044} [modify] https://crrev.com/c46b791f0011585cc456b0f2ea7260bcf17b410b/chrome/browser/password_manager/password_manager_browsertest.cc
,
May 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f5d26f25e3bfb6a88ff9c44133f26fbd8c02bdbf commit f5d26f25e3bfb6a88ff9c44133f26fbd8c02bdbf Author: Tommy Martino <tmartino@chromium.org> Date: Tue May 08 19:16:12 2018 [Autofill Views] Implementing styles This change implements most of the font, color, and spacing changes requested in the mocks. Specifically: * Introduces a new subclass hierarchy, where AutofillPopupRowView is abstract and its children are divided based on whether they display an option (AutofillPopupItemView) or a separator (AutofillPopupSeparatorView). * Introduces style divergence between suggestion rows and footer rows through further subclassing. * Updates colors and most padding values to be in line with the new spec. Bug: 768881 Change-Id: I45825ffd7ad8d832cf08114116ef9b0efb834e12 Reviewed-on: https://chromium-review.googlesource.com/1026204 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#556914} [modify] https://crrev.com/f5d26f25e3bfb6a88ff9c44133f26fbd8c02bdbf/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc [modify] https://crrev.com/f5d26f25e3bfb6a88ff9c44133f26fbd8c02bdbf/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.h
,
May 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b590c5e4536e0a68db701b27e66385881c6487c commit 1b590c5e4536e0a68db701b27e66385881c6487c Author: Tommy Martino <tmartino@chromium.org> Date: Wed May 09 14:53:55 2018 [Autofill] New Assets for Generic Credit Cards This introduces a new, modern icon to be used for credit cards whose type is unknown. It replaces the existing icon, but is the same size and is semantically similar, so risk is low. Known instances of this icon include both the "old" (canvas) and "new" (native) Autofill dropdowns, and the PaymentRequest UI. Bug: 768881 Change-Id: Ic19ee458d989a26e0bb222187284dafe0c4ea497 Reviewed-on: https://chromium-review.googlesource.com/1026049 Reviewed-by: Cait Phillips <caitkp@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#557182} [modify] https://crrev.com/1b590c5e4536e0a68db701b27e66385881c6487c/components/resources/default_100_percent/autofill/cc-generic.png [modify] https://crrev.com/1b590c5e4536e0a68db701b27e66385881c6487c/components/resources/default_200_percent/autofill/cc-generic.png [modify] https://crrev.com/1b590c5e4536e0a68db701b27e66385881c6487c/components/resources/default_300_percent/autofill/cc-generic.png
,
May 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/10b35e76bd4400a6dde4d6a7f04eda354b695487 commit 10b35e76bd4400a6dde4d6a7f04eda354b695487 Author: Fabio Tirelo <ftirelo@chromium.org> Date: Fri May 11 13:52:55 2018 [af] Adjust dropdown alignment according to drawing direction This uses the actual size of the native views dropdown to decide if it will be drawn upwards or downwards, to the left or to the right. Screenshots can be found at: https://drive.google.com/open?id=1F43ccvwErhPS7hEmdKWl90i0yHmd3-7J Bug: 768881 Change-Id: Iedc166b7c7edbdfe324c7657f7f319dc4032487f Reviewed-on: https://chromium-review.googlesource.com/1036286 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#557864} [modify] https://crrev.com/10b35e76bd4400a6dde4d6a7f04eda354b695487/chrome/browser/ui/autofill/popup_view_common.cc [modify] https://crrev.com/10b35e76bd4400a6dde4d6a7f04eda354b695487/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
,
May 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/655e12b05215eebea07b2d47fb27a640e200d576 commit 655e12b05215eebea07b2d47fb27a640e200d576 Author: Tommy Martino <tmartino@chromium.org> Date: Fri May 11 14:13:41 2018 [Autofill Views] Update dropdown footer strings This conditionally replaces "Autofill settings" with "Manage cards" or "Manage addresses" when using the new Autofill UI. Bug: 768881 Change-Id: I9257385a0af87d8208e54db5f56daf78f54b770f Reviewed-on: https://chromium-review.googlesource.com/1054102 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#557866} [modify] https://crrev.com/655e12b05215eebea07b2d47fb27a640e200d576/components/autofill/core/browser/autofill_external_delegate.cc [modify] https://crrev.com/655e12b05215eebea07b2d47fb27a640e200d576/components/autofill/core/browser/autofill_external_delegate.h [modify] https://crrev.com/655e12b05215eebea07b2d47fb27a640e200d576/components/autofill/core/browser/autofill_popup_delegate.h [modify] https://crrev.com/655e12b05215eebea07b2d47fb27a640e200d576/components/password_manager/core/browser/password_autofill_manager.cc [modify] https://crrev.com/655e12b05215eebea07b2d47fb27a640e200d576/components/password_manager/core/browser/password_autofill_manager.h
,
May 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29d059216ab49f30195a832913e7b3730d4a8ad8 commit 29d059216ab49f30195a832913e7b3730d4a8ad8 Author: Fabio Tirelo <ftirelo@chromium.org> Date: Tue May 15 23:09:43 2018 [af] Extend popup width when it's narrower than the element Bug: 768881 Change-Id: Ie82d66ef053ea88461ae9d65eface09e513ba3c7 Reviewed-on: https://chromium-review.googlesource.com/1057432 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#558876} [modify] https://crrev.com/29d059216ab49f30195a832913e7b3730d4a8ad8/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7f10708cd92c5494915073074e2613e67ab1cf1 commit e7f10708cd92c5494915073074e2613e67ab1cf1 Author: Fabio Tirelo <ftirelo@chromium.org> Date: Wed May 16 21:18:11 2018 [af] Fix spacing for CC for RTL browser languages This makes spacing between expiration date and logo for credit card suggestions consistent across languages. The fix replaces a left padding to the image (which doesn't work for RTL) with a fixed spacer between the label and the image, which will be rendered according to expected. One alternative for this is to set either left or right padding according to the browser language's direction, but I'd rather only test for language direction when it's strictly necessary. See screenshots in this deck: https://drive.google.com/open?id=1rcdEKbMWxsABDRAWDjlIa5FgJrNsUro8EKECD99tSDg Bug: 768881 Change-Id: I362e75f78cabee357ca83c118cf58b788462e952 Reviewed-on: https://chromium-review.googlesource.com/1057420 Reviewed-by: Tommy Martino <tmartino@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#559291} [modify] https://crrev.com/e7f10708cd92c5494915073074e2613e67ab1cf1/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a2fd74a6138bf43e993be4078fdb619c1158959 commit 2a2fd74a6138bf43e993be4078fdb619c1158959 Author: Fabio Tirelo <ftirelo@chromium.org> Date: Wed May 23 18:13:38 2018 [af] Apply a bubble border to the Autofill dropdown Screenshots: https://docs.google.com/presentation/d/1fuoRsXUI_rHF-F3FNmM8y9xq9nYLDrcEGmEGQcU9l4w Bug: 768881 Change-Id: I7a1af74b83ba7afb1f7797d4e8125c876275e295 Reviewed-on: https://chromium-review.googlesource.com/1064530 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#561158} [modify] https://crrev.com/2a2fd74a6138bf43e993be4078fdb619c1158959/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc [modify] https://crrev.com/2a2fd74a6138bf43e993be4078fdb619c1158959/chrome/browser/ui/views/autofill/autofill_popup_base_view.h [modify] https://crrev.com/2a2fd74a6138bf43e993be4078fdb619c1158959/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc [modify] https://crrev.com/2a2fd74a6138bf43e993be4078fdb619c1158959/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.h
,
May 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d13cd396f6e6a8092fb5dc731bec0f27675aad74 commit d13cd396f6e6a8092fb5dc731bec0f27675aad74 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Wed May 30 08:58:37 2018 Move password generation UI prompt to the passwords/ folder. TBR=rouslan@chromium.org,groby@chromium.org Bug: 768881 Change-Id: I128074ab5dccb401744c2f3a8aaf4d059b0c4eac Reviewed-on: https://chromium-review.googlesource.com/1076295 Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#562768} [modify] https://crrev.com/d13cd396f6e6a8092fb5dc731bec0f27675aad74/chrome/browser/password_manager/chrome_password_manager_client.cc [modify] https://crrev.com/d13cd396f6e6a8092fb5dc731bec0f27675aad74/chrome/browser/password_manager/password_generation_interactive_uitest.cc [modify] https://crrev.com/d13cd396f6e6a8092fb5dc731bec0f27675aad74/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/d13cd396f6e6a8092fb5dc731bec0f27675aad74/chrome/browser/ui/android/autofill/password_generation_popup_view_android.cc [modify] https://crrev.com/d13cd396f6e6a8092fb5dc731bec0f27675aad74/chrome/browser/ui/android/autofill/password_generation_popup_view_android.h [modify] https://crrev.com/d13cd396f6e6a8092fb5dc731bec0f27675aad74/chrome/browser/ui/cocoa/autofill/password_generation_popup_view_bridge.h [modify] https://crrev.com/d13cd396f6e6a8092fb5dc731bec0f27675aad74/chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.h [rename] https://crrev.com/d13cd396f6e6a8092fb5dc731bec0f27675aad74/chrome/browser/ui/passwords/password_generation_popup_controller.cc [rename] https://crrev.com/d13cd396f6e6a8092fb5dc731bec0f27675aad74/chrome/browser/ui/passwords/password_generation_popup_controller.h [rename] https://crrev.com/d13cd396f6e6a8092fb5dc731bec0f27675aad74/chrome/browser/ui/passwords/password_generation_popup_controller_impl.cc [rename] https://crrev.com/d13cd396f6e6a8092fb5dc731bec0f27675aad74/chrome/browser/ui/passwords/password_generation_popup_controller_impl.h [rename] https://crrev.com/d13cd396f6e6a8092fb5dc731bec0f27675aad74/chrome/browser/ui/passwords/password_generation_popup_observer.h [rename] https://crrev.com/d13cd396f6e6a8092fb5dc731bec0f27675aad74/chrome/browser/ui/passwords/password_generation_popup_view.cc [rename] https://crrev.com/d13cd396f6e6a8092fb5dc731bec0f27675aad74/chrome/browser/ui/passwords/password_generation_popup_view.h [rename] https://crrev.com/d13cd396f6e6a8092fb5dc731bec0f27675aad74/chrome/browser/ui/passwords/password_generation_popup_view_browsertest.cc [rename] https://crrev.com/d13cd396f6e6a8092fb5dc731bec0f27675aad74/chrome/browser/ui/passwords/password_generation_popup_view_tester.h [delete] https://crrev.com/b44aac47a61a6932dddf85d353619b60bace05b1/chrome/browser/ui/views/autofill/password_generation_popup_view_tester_views.h [rename] https://crrev.com/d13cd396f6e6a8092fb5dc731bec0f27675aad74/chrome/browser/ui/views/passwords/password_generation_popup_view_tester_views.cc [add] https://crrev.com/d13cd396f6e6a8092fb5dc731bec0f27675aad74/chrome/browser/ui/views/passwords/password_generation_popup_view_tester_views.h [rename] https://crrev.com/d13cd396f6e6a8092fb5dc731bec0f27675aad74/chrome/browser/ui/views/passwords/password_generation_popup_view_views.cc [rename] https://crrev.com/d13cd396f6e6a8092fb5dc731bec0f27675aad74/chrome/browser/ui/views/passwords/password_generation_popup_view_views.h [modify] https://crrev.com/d13cd396f6e6a8092fb5dc731bec0f27675aad74/chrome/test/BUILD.gn
,
May 30 2018
Closing this to unblock the launch review bug. We should from now on file new bugs for issues identified in the implementation.
,
May 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3eb626c2b88715a473a8e04d552627e580c306ec commit 3eb626c2b88715a473a8e04d552627e580c306ec Author: Fabio Tirelo <ftirelo@chromium.org> Date: Wed May 30 18:30:47 2018 [af] Enable AutofillExpandedPopupViews on perf waterfall Bug: 768881 Change-Id: I6c1f4fae8428067d018cb548f792ad3a2f955bff Reviewed-on: https://chromium-review.googlesource.com/1079193 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#562923} [modify] https://crrev.com/3eb626c2b88715a473a8e04d552627e580c306ec/testing/variations/fieldtrial_testing_config.json
,
Jun 6 2018
Do you plan to revert testing with boolean?
,
Jun 6 2018
vasilii@: yes, once we turn the new dropdown the default behavior, which should happen when M68 goes to stable. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by melandory@chromium.org
, Sep 26 201712.5 KB
12.5 KB View Download