StackView controller animation does not interact properly with the SafeArea. |
|||
Issue descriptionAfter a rotation, the adjustedContentInset of the StackView's scrollview is temporarily incorrect on the iPhone X. This compromises the opening animation of the StackView. Adding _scrollView.contentInsetAdjustmentBehavior = UIScrollViewContentInsetAdjustmentNever; fixes the problem, but it's not clear if that's the proper fix.
,
Sep 28 2017
,
Oct 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/716c27c9f37ba80f0f29892ddcf39d04ffd61127 commit 716c27c9f37ba80f0f29892ddcf39d04ffd61127 Author: Jean-François Geyelin <jif@chromium.org> Date: Tue Oct 03 13:40:39 2017 Default the toolbar height to 44 and ignore the safe area in Stack View. Bug: 768868 , 767516 , 767566 Change-Id: I8c2de3f2788bb0af090293ac4ead13b23bb73c78 Reviewed-on: https://chromium-review.googlesource.com/684743 Commit-Queue: Jean-François Geyelin <jif@chromium.org> Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#504640}(cherry picked from commit be4f437a5eb20f3955c0b56a8a7a54aa3999c85b) Reviewed-on: https://chromium-review.googlesource.com/697725 Reviewed-by: Jean-François Geyelin <jif@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#558} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/716c27c9f37ba80f0f29892ddcf39d04ffd61127/ios/chrome/browser/ui/stack_view/stack_view_controller.mm [modify] https://crrev.com/716c27c9f37ba80f0f29892ddcf39d04ffd61127/ios/chrome/browser/ui/ui_util.mm |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Sep 27 2017