[WPT Import] Skip the import if there are only manifest changes |
||
Issue descriptionCurrently, a significant fraction of imports are practically empty with only WPT_BASE_MANIFEST.json updates. We can stop early in this case and start the next cycle. The main benefit is faster cycle and lower latency. Even if WPT_BASE_MANIFEST.json is the only change, we still need to trigger tryjobs and run CQs, which takes a lot of time and unnecessarily delays the discovery of new upstream changes.
,
Oct 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/32e642c4f4e2cac53d6d0f3281ffac5cc068ca55 commit 32e642c4f4e2cac53d6d0f3281ffac5cc068ca55 Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Date: Thu Oct 05 15:09:52 2017 WPT import: Skip the import if only WPT_BASE_MANIFEST.json has changed. Currently, a significant fraction of imports are practically empty with only WPT_BASE_MANIFEST.json updates. We can stop early in this case and start the next cycle. The main benefit is faster cycle and lower latency. Bug: 768853 Change-Id: If7335ae8a8f9caf56e5b5c3d755264c16992378e Reviewed-on: https://chromium-review.googlesource.com/700595 Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#506733} [modify] https://crrev.com/32e642c4f4e2cac53d6d0f3281ffac5cc068ca55/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py [modify] https://crrev.com/32e642c4f4e2cac53d6d0f3281ffac5cc068ca55/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
,
Oct 5 2017
Alright, I think this one's done. Thanks for filing the bug, this is something that had bothered me for a long time, but I'd always thought we _had_ to regenerate the manifest like we did :-) |
||
►
Sign in to add a comment |
||
Comment 1 by raphael....@intel.com
, Oct 4 2017Status: Started (was: Available)