New issue
Advanced search Search tips

Issue 768852 link

Starred by 0 users
Status: Fixed
Owner: ----
Closed: Apr 2018
Cc:
flackr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove mutable_properties from layers

Project Member Reported by petermayo@chromium.org, Sep 26 2017 
From code review 677650:
flackr: Do we need mutable properties at all after compositor worker goes away?
petermayo: property_trees_builder still references them.
flackr: But we don't ever set them - they were the way that we communicated which properties we had constructed compositor proxies of on the main thread, but since CompositorProxy has been removed they will always be MutableProperty::kNone so we can remove all of this code.



We could DCHECK(mutable_properties==MutableProperty::kNone) or remove the code and check that the tests pass.

Comment 1 by schenney@chromium.org, Sep 26 2017

Components: -Blink>Compositing Internals>Compositing
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa4d8ffcd95c657250b752fd6be4c547469be9d5

commit fa4d8ffcd95c657250b752fd6be4c547469be9d5
Author: Peter Mayo <petermayo@chromium.org>
Date: Thu Sep 28 03:38:34 2017

Remove mutable_properties from layers

These could/should have gone away with CompositorProxy, but now that
CompositorWorker is gone too, they really do stick out as zombie code.

Bug:  768852 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I3eb1b3fd0f8806ffd1bed4689d6547308ecc6438
Reviewed-on: https://chromium-review.googlesource.com/684697
Commit-Queue: Peter Mayo <petermayo@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504887}
[modify] https://crrev.com/fa4d8ffcd95c657250b752fd6be4c547469be9d5/cc/BUILD.gn
[modify] https://crrev.com/fa4d8ffcd95c657250b752fd6be4c547469be9d5/cc/blink/web_layer_impl.cc
[modify] https://crrev.com/fa4d8ffcd95c657250b752fd6be4c547469be9d5/cc/blink/web_layer_impl.h
[modify] https://crrev.com/fa4d8ffcd95c657250b752fd6be4c547469be9d5/cc/layers/layer.cc
[modify] https://crrev.com/fa4d8ffcd95c657250b752fd6be4c547469be9d5/cc/layers/layer.h
[modify] https://crrev.com/fa4d8ffcd95c657250b752fd6be4c547469be9d5/cc/layers/layer_impl.cc
[modify] https://crrev.com/fa4d8ffcd95c657250b752fd6be4c547469be9d5/cc/layers/layer_impl.h
[modify] https://crrev.com/fa4d8ffcd95c657250b752fd6be4c547469be9d5/cc/layers/layer_impl_unittest.cc
[modify] https://crrev.com/fa4d8ffcd95c657250b752fd6be4c547469be9d5/cc/layers/layer_unittest.cc
[modify] https://crrev.com/fa4d8ffcd95c657250b752fd6be4c547469be9d5/cc/trees/layer_tree_impl_unittest.cc
[delete] https://crrev.com/fe3154a08befe05ca82158bd14fafd0c6fd68779/cc/trees/mutable_properties.h
[modify] https://crrev.com/fa4d8ffcd95c657250b752fd6be4c547469be9d5/cc/trees/property_tree_builder.cc
[modify] https://crrev.com/fa4d8ffcd95c657250b752fd6be4c547469be9d5/third_party/WebKit/Source/platform/graphics/CompositorMutableProperties.h
[modify] https://crrev.com/fa4d8ffcd95c657250b752fd6be4c547469be9d5/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/fa4d8ffcd95c657250b752fd6be4c547469be9d5/third_party/WebKit/Source/platform/graphics/GraphicsLayer.h
[modify] https://crrev.com/fa4d8ffcd95c657250b752fd6be4c547469be9d5/third_party/WebKit/public/platform/WebLayer.h
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6f6effe1f647b70320210f0e8ac4a4adb0d0baf

commit d6f6effe1f647b70320210f0e8ac4a4adb0d0baf
Author: Peter Mayo <petermayo@chromium.org>
Date: Tue Oct 03 15:34:32 2017

Remove CompositorMutation

These could/should have gone away with CompositorProxy, but now that
cc/trees/mutable_properties is gone too, they really do stick out as
zombie code.

Bug:  768852 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ib33a0243acbbd504b7649d72ae89278459c45d26
Reviewed-on: https://chromium-review.googlesource.com/686038
Commit-Queue: Peter Mayo <petermayo@chromium.org>
Reviewed-by: Peter Mayo <petermayo@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506047}
[modify] https://crrev.com/d6f6effe1f647b70320210f0e8ac4a4adb0d0baf/cc/animation/animation_host.cc
[modify] https://crrev.com/d6f6effe1f647b70320210f0e8ac4a4adb0d0baf/cc/animation/animation_host.h
[modify] https://crrev.com/d6f6effe1f647b70320210f0e8ac4a4adb0d0baf/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/d6f6effe1f647b70320210f0e8ac4a4adb0d0baf/cc/trees/layer_tree_host_impl.h
[modify] https://crrev.com/d6f6effe1f647b70320210f0e8ac4a4adb0d0baf/cc/trees/layer_tree_mutator.h
[modify] https://crrev.com/d6f6effe1f647b70320210f0e8ac4a4adb0d0baf/cc/trees/mutator_host.h
[modify] https://crrev.com/d6f6effe1f647b70320210f0e8ac4a4adb0d0baf/cc/trees/proxy_common.h
[modify] https://crrev.com/d6f6effe1f647b70320210f0e8ac4a4adb0d0baf/cc/trees/proxy_impl.cc
[modify] https://crrev.com/d6f6effe1f647b70320210f0e8ac4a4adb0d0baf/cc/trees/proxy_main.cc
[modify] https://crrev.com/d6f6effe1f647b70320210f0e8ac4a4adb0d0baf/third_party/WebKit/Source/core/animation/BUILD.gn
[modify] https://crrev.com/d6f6effe1f647b70320210f0e8ac4a4adb0d0baf/third_party/WebKit/Source/core/animation/CompositorMutatorImpl.cpp
[modify] https://crrev.com/d6f6effe1f647b70320210f0e8ac4a4adb0d0baf/third_party/WebKit/Source/core/animation/CompositorMutatorImpl.h
[delete] https://crrev.com/dc8f9d8f6b796bbad05aa75e5e4b3d005deaccd4/third_party/WebKit/Source/core/animation/CustomCompositorAnimationManager.cpp
[delete] https://crrev.com/dc8f9d8f6b796bbad05aa75e5e4b3d005deaccd4/third_party/WebKit/Source/core/animation/CustomCompositorAnimationManager.h
[delete] https://crrev.com/dc8f9d8f6b796bbad05aa75e5e4b3d005deaccd4/third_party/WebKit/Source/core/animation/CustomCompositorAnimations.cpp
[delete] https://crrev.com/dc8f9d8f6b796bbad05aa75e5e4b3d005deaccd4/third_party/WebKit/Source/core/animation/CustomCompositorAnimations.h
[modify] https://crrev.com/d6f6effe1f647b70320210f0e8ac4a4adb0d0baf/third_party/WebKit/Source/core/animation/ElementAnimations.cpp
[modify] https://crrev.com/d6f6effe1f647b70320210f0e8ac4a4adb0d0baf/third_party/WebKit/Source/core/animation/ElementAnimations.h
[modify] https://crrev.com/d6f6effe1f647b70320210f0e8ac4a4adb0d0baf/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
[modify] https://crrev.com/d6f6effe1f647b70320210f0e8ac4a4adb0d0baf/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/d6f6effe1f647b70320210f0e8ac4a4adb0d0baf/third_party/WebKit/Source/core/dom/Element.h
[modify] https://crrev.com/d6f6effe1f647b70320210f0e8ac4a4adb0d0baf/third_party/WebKit/Source/core/frame/VisualViewport.cpp
[modify] https://crrev.com/d6f6effe1f647b70320210f0e8ac4a4adb0d0baf/third_party/WebKit/Source/core/paint/LinkHighlightImpl.cpp
[modify] https://crrev.com/d6f6effe1f647b70320210f0e8ac4a4adb0d0baf/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/d6f6effe1f647b70320210f0e8ac4a4adb0d0baf/third_party/WebKit/Source/core/paint/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/d6f6effe1f647b70320210f0e8ac4a4adb0d0baf/third_party/WebKit/Source/core/paint/compositing/PaintLayerCompositor.cpp
[modify] https://crrev.com/d6f6effe1f647b70320210f0e8ac4a4adb0d0baf/third_party/WebKit/Source/platform/BUILD.gn
[delete] https://crrev.com/dc8f9d8f6b796bbad05aa75e5e4b3d005deaccd4/third_party/WebKit/Source/platform/graphics/CompositorMutableProperties.h
[delete] https://crrev.com/dc8f9d8f6b796bbad05aa75e5e4b3d005deaccd4/third_party/WebKit/Source/platform/graphics/CompositorMutation.h
[delete] https://crrev.com/dc8f9d8f6b796bbad05aa75e5e4b3d005deaccd4/third_party/WebKit/Source/platform/graphics/CompositorMutationsTarget.h
[modify] https://crrev.com/d6f6effe1f647b70320210f0e8ac4a4adb0d0baf/third_party/WebKit/Source/platform/graphics/CompositorMutatorClient.cpp
[modify] https://crrev.com/d6f6effe1f647b70320210f0e8ac4a4adb0d0baf/third_party/WebKit/Source/platform/graphics/CompositorMutatorClient.h
[delete] https://crrev.com/dc8f9d8f6b796bbad05aa75e5e4b3d005deaccd4/third_party/WebKit/Source/platform/graphics/CompositorMutatorClientTest.cpp
[modify] https://crrev.com/d6f6effe1f647b70320210f0e8ac4a4adb0d0baf/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp

Comment 4 by petermayo@chromium.org, Apr 12 2018

Owner: ----
Status: Fixed (was: Started)
►

Sign in to add a comment