New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 768846 link

Starred by 1 user
Status: Fixed
Owner:
gambard@chromium.org
Closed: Sep 2017
Cc:
ios-bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Voice search not working when triggered with a context menu displayed

Project Member Reported by gambard@chromium.org, Sep 26 2017 
Chrome Version: M61
iPad only

What steps will reproduce the problem?
(1) Open NTP
(2) Long press on any item on the NTP and on the voice search icon
(3) Release the press on the item, showing the context menu
(4) Release the press on the voice search icon
(5) Tap on voice search icon

What is the expected result?
Voice search should be launching

What happens instead?
Voice search is not launching. Even on opening a new NTP, it is not possible to launch it.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d230681ae201ff9d479139c8fa5f98701e7dfc2

commit 6d230681ae201ff9d479139c8fa5f98701e7dfc2
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed Sep 27 07:28:06 2017

Close context menu when showing voice search

The context menu is a ViewController presented by BVC. When BVC tries to
present the voice search ViewController, it is silently failing as it is
already presenting something.
This CL closes the context menu before launching voice search.

Bug:  768846 
Change-Id: I653a0e03feb6bcdcd07d525b00dd4bd9c8629fe8
Reviewed-on: https://chromium-review.googlesource.com/684838
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504592}
[modify] https://crrev.com/6d230681ae201ff9d479139c8fa5f98701e7dfc2/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller.mm

Comment 2 by gambard@chromium.org, Sep 27 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment