New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 768817 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task

Blocked on:
issue 753599

Blocking:
issue 228081



Sign in to add a comment

☂ Tracking cleanup of NTP scroll view

Project Member Reported by gambard@chromium.org, Sep 26 2017

Issue description

With the new bookmark UI, the iPad NTP is no longer horizontally scrolling.
Once it has launched to 100%, the scroll view should be removed and some cleanup performed.
 
Blockedon: 228081
Labels: zine-triaged
Blockedon: -228081 753599
Blocking: 228081
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f15d4b93c6faffd3103af2fbb0dfec8475d6e0a5

commit f15d4b93c6faffd3103af2fbb0dfec8475d6e0a5
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed Jan 17 16:42:39 2018

Additional cleanup of the NTP

This CL cleans up the NTP after removing the bookmarks non-modal view.

Bug:  768817 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I8bf2ecbda72417a99bed57767887cb860d9140e2
Reviewed-on: https://chromium-review.googlesource.com/866853
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529767}
[modify] https://crrev.com/f15d4b93c6faffd3103af2fbb0dfec8475d6e0a5/ios/chrome/browser/prefs/browser_prefs.mm
[modify] https://crrev.com/f15d4b93c6faffd3103af2fbb0dfec8475d6e0a5/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/f15d4b93c6faffd3103af2fbb0dfec8475d6e0a5/ios/chrome/browser/ui/ntp/BUILD.gn
[delete] https://crrev.com/3fef72b46e75b05bc017a70962da0c829e2372d1/ios/chrome/browser/ui/ntp/centering_scrollview.h
[delete] https://crrev.com/3fef72b46e75b05bc017a70962da0c829e2372d1/ios/chrome/browser/ui/ntp/centering_scrollview.mm
[delete] https://crrev.com/3fef72b46e75b05bc017a70962da0c829e2372d1/ios/chrome/browser/ui/ntp/centering_scrollview_unittest.mm
[modify] https://crrev.com/f15d4b93c6faffd3103af2fbb0dfec8475d6e0a5/ios/chrome/browser/ui/ntp/new_tab_page_bar.h
[modify] https://crrev.com/f15d4b93c6faffd3103af2fbb0dfec8475d6e0a5/ios/chrome/browser/ui/ntp/new_tab_page_bar.mm
[modify] https://crrev.com/f15d4b93c6faffd3103af2fbb0dfec8475d6e0a5/ios/chrome/browser/ui/ntp/new_tab_page_controller.h
[modify] https://crrev.com/f15d4b93c6faffd3103af2fbb0dfec8475d6e0a5/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm
[modify] https://crrev.com/f15d4b93c6faffd3103af2fbb0dfec8475d6e0a5/ios/chrome/browser/ui/ntp/new_tab_page_controller_unittest.mm
[modify] https://crrev.com/f15d4b93c6faffd3103af2fbb0dfec8475d6e0a5/ios/chrome/browser/ui/ntp/new_tab_page_egtest.mm
[modify] https://crrev.com/f15d4b93c6faffd3103af2fbb0dfec8475d6e0a5/ios/chrome/browser/ui/ntp/new_tab_page_view.h
[modify] https://crrev.com/f15d4b93c6faffd3103af2fbb0dfec8475d6e0a5/ios/chrome/browser/ui/ntp/new_tab_page_view.mm
[modify] https://crrev.com/f15d4b93c6faffd3103af2fbb0dfec8475d6e0a5/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_coordinator_unittest.mm
[modify] https://crrev.com/f15d4b93c6faffd3103af2fbb0dfec8475d6e0a5/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm

Cc: justincohen@chromium.org
Status: Fixed (was: Assigned)
In my opinion, the NTP is now cleaned up, relatively to the bookmarks presentation.

Sign in to add a comment