New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 768810 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Check boxes are not displayed on tapping select

Project Member Reported by pmadalla@chromium.org, Sep 26 2017

Issue description

App Version: 63.0.3224.0 canary
iOS Version:9.3.5, 10.3.2,11.0
Device : iPhone,iPad

Precondition :
1.Go to chrome://flags --> Bookmark New Generation iOS : Enabled.
2. Have few bookmarks saved

Steps to reproduce:
1. Launch chrome 
2. Tap on Bookmarks icon 
3. Hold on any bookmark and swipe to left.
4. Tap on Select at the bottom.

Observed results:
At step 3 : Delete button is shown
At step 4 : Check boxes are not displayed

Expected results:
Checkboxes should be displayed.

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: NA
Bug reproducible on Safari/Firefox: NA
Bug reproducible on current stable build (App Version, iOS Version): No in m61, New change 
Bug reproducible on the current beta channel build (App Version, iOS Version):  No in m62, New change 

Link to :
https://drive.google.com/a/google.com/file/d/0B--UpU2GW2EpN2FIYXpERFRjMnc/view?usp=sharing

 

Comment 1 by sczs@chromium.org, Sep 27 2017

Status: Assigned (was: Untriaged)
Labels: M-63
Labels: -Pri-2 Pri-1

Comment 4 by martiw@chromium.org, Oct 11 2017

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02ea1e777049465c099af01fbc2549bce2afb911

commit 02ea1e777049465c099af01fbc2549bce2afb911
Author: Marti Wong <martiw@chromium.org>
Date: Wed Oct 11 14:07:37 2017

Stop swipe-to-delete when entering selection mode (new iOS bookmark ui)

When entering selection mode (edit mode), dismiss the swipe-to-delete
confirmation button if it is showing up.  An egtest is added to prevent
this bug from happening again.

Demo: https://drive.google.com/file/d/0B1dtd3IUt4I7bTZhcDdNOU5faFU/view

Bug:  768810 
Change-Id: I9ff11ae68f6cc9345f2417f0a66fcaa927231bb3
Reviewed-on: https://chromium-review.googlesource.com/711514
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507973}
[modify] https://crrev.com/02ea1e777049465c099af01fbc2549bce2afb911/ios/chrome/browser/ui/bookmarks/bookmark_table_view.mm
[modify] https://crrev.com/02ea1e777049465c099af01fbc2549bce2afb911/ios/chrome/browser/ui/bookmarks/bookmarks_new_generation_egtest.mm

Comment 6 by martiw@chromium.org, Oct 11 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified in:

App Version: 63.0.3239.8 beta
Devices: iPhone 5, iPhone 7, iPad Mini
iOS Versions: 9.3.5, 10.3.3, 11.0.2

Swipe-to-delete confirmation button is dismissed when user chooses 'Select' option.

Link for video:
https://drive.google.com/open?id=0B6nZ3QPCkSVccFJobmVuRlh6QTQ

Sign in to add a comment